From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EbamRh54; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 0F0315A0262 for ; Tue, 19 May 2026 09:06:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779174383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CfX/MqArFoYQ9hsYfvUPgwPFkD8K58QCesYFrnfEyNs=; b=EbamRh54uuTxadYwr5y82os0pOs2zZhNW6XqArCf59tPfwZs33rhzMOIAkffGk6NS8vYMt QqwGoQ6KNsC9/Vf/TLMAYBYoxGUvqOm/mRh0++tnX8yOXeCeEi9o1bUm1ngpakeI0uaIzE c2tQ20grYcbAdvhx3JKr1j1miw3/bh0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-OfGZNQaUOleGV9DjrAe3cg-1; Tue, 19 May 2026 03:06:21 -0400 X-MC-Unique: OfGZNQaUOleGV9DjrAe3cg-1 X-Mimecast-MFC-AGG-ID: OfGZNQaUOleGV9DjrAe3cg_1779174380 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43ff19e54beso2117653f8f.2 for ; Tue, 19 May 2026 00:06:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779174380; x=1779779180; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CfX/MqArFoYQ9hsYfvUPgwPFkD8K58QCesYFrnfEyNs=; b=OYN0QiSSG8GkinBtxnDSBRFft76UHhzs7MbKInzV7dNOTk0VzSEMRTAa7TvckaCmjG oCWwq1xT1611L25IPBDmMRI3acjA5a3rkK/P18eHJaNw2MEfU177KcCj+c9/VE1sbMEh NoKj5ZeXMjJRQYfVP+eHd6+pewJouimR3RcOC1QNQ9z8xFDmNLIX0uvnLWx6o731BDzD AdaZ2LHxwRTnwaAR8d6WrSuC7zDY7UelcASnfybbrMqlc7yzzeJyxWktF29HUBISAzCB 1OE5zcZJVaQ77yaxNo6upWgtNWLskIvgmOzBbLO8OVToAyQSBwt0F1KVkGeHQokuEbyD Mdrw== X-Forwarded-Encrypted: i=1; AFNElJ93HwoOZ9Ue2qIPTupXI3Ebd7rW/5b7EKPTVnlyvp3uXifE6w6sUH11D6AluN5DSW69+dbO0X2Pv7E=@passt.top X-Gm-Message-State: AOJu0Yw2g20k9pHSAtieDKp2e146HUntR6fqnalysDiH1wg7jxJrasr/ F2ROAsvgizjSAXvR3BGnHm9bgJklmVikxU+rynb14L3bUnWBodZjf7yH2NxcY5o3dOmbmMv5zLp 2trifuO64SqfZCdFpbVuM90mY7qPIm4rPqbXQ7PrUl2labck/Y13J6g== X-Gm-Gg: Acq92OEQIRz+zeAWVC8xN8qmPNnOvzhOcQCbOJ4u1RB6j2p+lyzGHABA7JeuTlCJJQD 3ky9IcG55AC6avb43Rise6u9FDNflrxRP6/pxuYaZRRybyid1RWwnEVf3jbYfJKznGusyEQEMdp jTIsed/QEXmQ/XZ/B3yZk1WcuMHK8ZlvI+sVnyJLsNi2BCcusNRVnOCDFXYh6aNCstESfnbHnoM 93zO7X6cg9STECh2krUpsNwTq8+cRuhSESJ6enejZ3BKmnUP28jybF/iYNsq7e7SXntAU5Yhfkr /RPKGKGCF2xC7krQDK1kNO9gKSaN/plq0og3ghZ+B2lEYwugVtVRiTjdijqp0Q86hp2KZQGeFQ7 70DJgnrPrg4Ai/MEvHLV2IqF4Ij8vupQCKO5u358uYl4Age+AgYhFiHM= X-Received: by 2002:a05:6000:25c4:b0:43d:184:8aa2 with SMTP id ffacd0b85a97d-45e5c589d93mr31328125f8f.16.1779174379851; Tue, 19 May 2026 00:06:19 -0700 (PDT) X-Received: by 2002:a05:6000:25c4:b0:43d:184:8aa2 with SMTP id ffacd0b85a97d-45e5c589d93mr31328048f8f.16.1779174379339; Tue, 19 May 2026 00:06:19 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19c2dsm44505535f8f.21.2026.05.19.00.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:06:18 -0700 (PDT) Message-ID: <87c720d8-153f-4230-af68-e0b26041791b@redhat.com> Date: Tue, 19 May 2026 09:06:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ip: Wrap CASE macro body in braces for pre-C23 compatibility To: Anshu Kumari , passt-dev@passt.top, sbrivio@redhat.com References: <20260518135806.429955-1-anskuma@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260518135806.429955-1-anskuma@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yhZWgu6z4mMGnRpDvWDlyijz8FeeCy2Ll5m2BID5W6o_1779174380 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: PHWAW5XVIP3C66IDPCDSZMFVIQNTGKS6 X-Message-ID-Hash: PHWAW5XVIP3C66IDPCDSZMFVIQNTGKS6 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, jmaloy@redhat.com, Jeskynar X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/18/26 15:58, Anshu Kumari wrote: > From: Jeskynar > > Compiling on RHEL8 (gcc-8.5) gives an error in ip.c. > ip.c:88:3: error: a label can only be part of a statement and > a declaration is not a statement due to the use of static_assert. > > The fix is to surround it with {}. > > Link: https://bugs.passt.top/show_bug.cgi?id=201 > Signed-off-by: Anshu Kumari Fixes: 93c3e351f235 ("ip: Define a bound for the string returned by ipproto_name()") Reviewed-by: Laurent Vivier > --- > ip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ip.c b/ip.c > index f2506bb..7b674e0 100644 > --- a/ip.c > +++ b/ip.c > @@ -35,9 +35,9 @@ const char *ipproto_name(uint8_t proto) > { > switch (proto) { > #define CASE(s) \ > - static_assert(sizeof(s) <= IPPROTO_STRLEN, \ > - "Increase IPPROTO_STRLEN to contain " #s); \ > - return s; > + {static_assert(sizeof(s) <= IPPROTO_STRLEN, \ > + "Increase IPPROTO_STRLEN to contain " #s); \ > + return s;} > case IPPROTO_ICMP: > CASE("ICMP"); > case IPPROTO_TCP: