From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=icloud.com header.i=@icloud.com header.a=rsa-sha256 header.s=1a1hai header.b=HeC1BShc; dkim-atps=neutral Received: from outbound.mr.icloud.com (mr-2003f-snip6-11.eps.apple.com [IPv6:2a01:b747:3000:202::3d]) by passt.top (Postfix) with ESMTPS id 3E1DC5A0262 for ; Fri, 07 Aug 2026 17:58:15 +0200 (CEST) Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-20-percent-0 (Postfix) with ESMTPS id 560531800186; Fri, 07 Aug 2026 15:58:09 +0000 (UTC) X-ICL-RepId: 019fdcf2-3782-72a9-948f-95af0f15af81 X-ICL-Out-Info: HUtFAUMEWwJACUgATUQeDx5WFlZNRAJCTQ1NHV4FRQNBF0kCVBcOVk1LFlZDXARHMFAbXwJCDxwTVhUTC1NWWxNVF0YJGQhdHRkKUFADS1oVVRcOAkIfUB9MFldDWhkcGVoUXBhTRVEfVFhDGUVWaUELTx1dGVscQmRYVwkKAlEcVg1XQ1QEX1BUEVdQC1MFBg5BXwFOXEJeThQeH1kOHBtWDXMEVAddBV1WUAJaVRIEQAhWUF4IXh9MHA== Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1786118293; x=1788710293; bh=idj+UDvM/EDN/g9BVQ24suVxSUFF5Ounedxxup2mGSM=; h=Date:Message-ID:From:To:Subject:MIME-Version:Content-Type:x-icloud-hme; b=HeC1BShcnanm4oJz6c3wTcVKawqF86/n14ooGAAmfGuDqPaqjLD8mmhDCaZiZhsgyJBmEOnlx2BUmpOD8xb63nO5zKswginkJ6NcyoZXQHpYPb9lymdSshRL4neQee/xCuecjzUUMUKpfRk79K/fIEDVlTSUAeN3Q31EQRwOg0Mph/Vnl6dhq+2dY0PuO/M69qafj70Z51eSwGRuNE8enBPDtSj7akMZcBeUIojFmnTnatCjk9VZF1a4KIA28klheroeboTbyzNLHdNzDHncO3aBxELfALZb/Ne0wWo3xK3FCQDi7tul4H7C1CnsPwns0yY3FVP248nnE1KbBlKvJA== Received: from cat-v.icloud.com (unknown [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-20-percent-0 (Postfix) with ESMTPSA id 940EB18016FE; Fri, 07 Aug 2026 15:58:07 +0000 (UTC) Date: Fri, 07 Aug 2026 23:58:02 +0800 Message-ID: <87v79lly7p.wl-rne.kou@icloud.com> From: Huang Jing To: David Gibson Subject: Re: Patch for the close_range() musl build failure In-Reply-To: References: <878q6jjvww.wl-rne.kou@icloud.com> <20260806235419.722b0a71@elisabeth> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-musl) MULE/6.0 (HANACHIRUSATO) X-Face: "0XTV&77+1.L8mei_jIv?,$SI9YMI_L16Iv!+nC/as*WE|xh_Cz]cX\.kyAyE:yR!u)"H{;QZo'_9@M.+iEKMPM2PM0Km|k\+HA2@a>eTdL"}b4H~5fcj8XFtvcHRLa*",9{Nc*>!)>hf>f|gO}8rA[>|.#IL#IBHv'?kRAiLM@A>|R/&~C\:.0A{l`7W0D2r_$Iob;)7VZiR*!uN\4n#H<](bi4a/;b'II5>qmb;SG]=Glv2hD5%]MoElN'%/FpudX/LQ^%Cd2(.~iKi&{ MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Fri_Aug__7_23:57:56_2026-1"; micalg=pgp-sha512; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: R5kZIpMR-RMujqkChChwGenfwhl9l-7j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDEyNSBTYWx0ZWRfX2bAJNAsQB80K YI9Yz+C/mKj7CsfdK4y1AC9YCx1IYbR6pwLjBtt0G1q//8q/NHMW/YAToWJxw6sRZj676jHVLZW R0zH9C6+CoafWO82bB26rEvHOdw3lpTWizE/XtsvScMHzScjuxU7vVwEE0TSxHbrads07ncIun6 0F6T2tOkYC8XU4cu8brbcGvqw0Vu4Ksy16/bkt82+TOHuZ/WJuuMfcEJT/rEf8i2AIAY1zdgggi YGIUcOMSHb+HUHjAS1LcKs20J3ncnSSnl+16Nad966D+YOfeGFl/4TUkrEvZUWVHKvSj1htnX0d rjKN92xT/AZqeVxXenSM72kNOXphzEgFqlvyci4Lkr6XBPuAo7DFRCAwQCbni8= X-Authority-Info-Out: v=2.4 cv=aaVsXBot c=1 sm=1 tr=0 ts=6a760092 cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117 a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=EW7FI4N_MPcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=v3ZZPjhaAAAA:8 a=dyIlGbjoU09TOvXP2ZIA:9 a=CjuIK1q_8ugA:10 a=FXsYUmtTBS-6qVCu9_cA:9 a=mPsO-hJUlkSWBUsxGjm6:22 a=hgpsAey8Q_doHSdeZM36:22 X-Proofpoint-ORIG-GUID: R5kZIpMR-RMujqkChChwGenfwhl9l-7j X-MailFrom: rne.kou@icloud.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: ADEL3HMZQ7RGRT6KLCPONY3AAURDQH4S X-Message-ID-Hash: ADEL3HMZQ7RGRT6KLCPONY3AAURDQH4S X-Mailman-Approved-At: Fri, 07 Aug 2026 18:12:14 +0200 CC: Stefano Brivio , Huang Jing , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --pgp-sign-Multipart_Fri_Aug__7_23:57:56_2026-1 Content-Type: text/plain; charset=US-ASCII > > Hi Huang Jing, > > > > Thanks for investigating and fixing this! A few notes, inline, > > below. > > > > They are all formal and trivial so I can fix up all of them on > > merge if you agree (but you can also choose to re-send as v2 with > > those fixed, let me know, in case). > > > > I'm pointing those out especially for the future, should you > > happen to contribute again to this project or projects following a > > similar workflow. Thanks! > > > From 25831e518c9227a31b75f2c1eb2e620fd4c5d049 Mon Sep 17 00:00:00 2001 > > > > We follow essentially the same contribution process as the Linux > > kernel, see also CONTRIBUTING.md and: > > > > https://www.kernel.org/doc/html/next/process/submitting-patches.html > > > > ...so we don't send them patches as attachments, they're simply in > > the email body, just like git send-email sends them. > > > > > From: RadioNoiseE > > > Date: Thu, 6 Aug 2026 19:58:45 +0800 > > > Subject: [PATCH] isolation: Include linux_dep.h for close_range() > > > > > > Now that close_open_files() has been moved, linux_dep.h can be safely > > > > Stated like this, it looks like a more detailed description of the > > patch, compared to the title. > > > > It's something you're adding to it instead. To avoid confusion > > about what the patch does (most importantly, what's in the title), > > I'd suggest to phrase it like: > > > > ...and now that close_open_files() ... > > > > > removed from util.c. > > > > Here we need a couple of tags to provide some context (which might > > be important when looking at this later), that is: > > > > Link: https://github.com/gentoo/gentoo/pull/46644 > > Fixes: 0a510066e916 ("isolation: Move close_open_files() to isolate_fds()") > > > > and, while at it, it's a good practice to Cc: the author of the > > change that's being fixed up (I just did). > > I second the minor procedural nits, but the patch looks good to me > too, so, > > Reviewed-by: David Gibson Will send the fixed patch in the following mail. --pgp-sign-Multipart_Fri_Aug__7_23:57:56_2026-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-Description: OpenPGP Digital Signature -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQTv68buVw1ltIiId4z1S1dSWDrj/AUCanYAhBsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQ9UtXUlg64/xRKgEAwzlkY1KX1STuF3XI6BOw zdDUjmuECXUN+AP9AcABLHwBAMb1G6t7nESEY5p65c9oqBf+zl47RW2rdrvq6mtu lbEM =soDR -----END PGP SIGNATURE----- --pgp-sign-Multipart_Fri_Aug__7_23:57:56_2026-1--