From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ECdNZ0qd; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E617A5A026F for ; Tue, 04 Nov 2025 16:25:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762269931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YF/BgQCQ/VXMgROvE0FqmnB1aG6vPwkyURrqjJUr1GI=; b=ECdNZ0qdoaSzN46H6kKvMG9GwH1oRFXMSde/uBDpi6odDGDgY3vBnUwbvqTRThqAVe0XHy j/+rwtAIxkYdpSITEcx5qmAAfaWIVUJYxQS96bSNG/gQY84jFzH+abwXT6Iui9u+wMIDUF 8OfZnLFlGgy2FVdPk7eijC3N89U1Hu0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-Barir17OOkSeqbSmWcTivA-1; Tue, 04 Nov 2025 10:25:30 -0500 X-MC-Unique: Barir17OOkSeqbSmWcTivA-1 X-Mimecast-MFC-AGG-ID: Barir17OOkSeqbSmWcTivA_1762269929 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4771e696e76so57423345e9.0 for ; Tue, 04 Nov 2025 07:25:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762269929; x=1762874729; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YF/BgQCQ/VXMgROvE0FqmnB1aG6vPwkyURrqjJUr1GI=; b=Zubm0NQHNUB4l1IcnqsLO3fA/wZo+Q2/+HJt+dAlxgDqY4Hr+n6UBi4qvA/cIw/rri 8a8ym5TyADUiolwm+9112uxl0+KmjAkv1KdVbCSAo8nEQblPMnqJLAKTAe8iGeU7wHPX 9dzihLch5s3b2kqPD05qDkZqbAqTKukHahta1n8SaJ+fNyCoZLyN3WFqKpQB2Zu228pr pK5CwCGr3B4srfv+eZ65FqfarU9w8GTGiLFva2PjL6CoLCNzRDxwZgdp0w0D5+/B/e7g AA/hYhItZW/vj4/vcALIfv2IIJIQr1uDScPx9ecER9nK4tAAosFUZScCgpy2gK3xU+KE a0JA== X-Forwarded-Encrypted: i=1; AJvYcCWWIo7WCyS1QIw8ord1Rd6c41ILh5BPRpB6+I/wnD07mczjjAyNsoYT9TPV+6wSfA7u1wmLPbecBsk=@passt.top X-Gm-Message-State: AOJu0YwhLmR7hEbk1sm8adn2fgu71/Hn+xKjoIqVb4s+eHBkSKVp+1lX GdgTyhLzNRUo7lOVqnLlCqNvmovnYodM2WbQGpMmMXNjT+6yL7l4RWCdW0OHQNjcxA+6E1MriJK BJrevA7YdUD2oik/m2iPt6Sb2mRPOvO5yG/yc471KI+MuUb3zqZjQmw== X-Gm-Gg: ASbGnct/uuAZcGWceHXqA/i7dp4x/BKOL+0iJ2OOYTVi2/LrrQVIkODhIpi9vT78D81 15hSYnuXOHp8VdUKyQG7zX7LdM8usEOBXN26s6at5xVeif8Aa7W/Vyq028+shWrAIOcTRizQq7s JjGjpHraS/eSRC/ciTV4Y7HXD8QOO4Fcnh/EYKN9B98HgcQ0ziKvJv4KjC1XgIfajwhVyoW+EBO dBLufHgvb+7xV2f1zpQqsFQppcjAUuopsUbi5p/6E2Ne2qvYfr276WEvCDOl0oGNxutJ2OhTBGl ah9GaEbpf52ZvsUMfrxvZYsNLwxLPQvtI+dtC7pNRj+AZD4V6lWVFgjtFHNpwr4LYxyQFD3tGvY M1+3n6det4ozE+ltprBRUS/BgGmUqDoNoTptVpQ== X-Received: by 2002:a05:600c:3548:b0:477:171f:65f with SMTP id 5b1f17b1804b1-477308aa6a1mr157467805e9.38.1762269929073; Tue, 04 Nov 2025 07:25:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgHtyaClt+Iu5+yOr1buucgQl+l/Km+WqAGQKf1nCU5O4gjTpPjgflfR7Osg+HbeU0h3bRxQ== X-Received: by 2002:a05:600c:3548:b0:477:171f:65f with SMTP id 5b1f17b1804b1-477308aa6a1mr157467455e9.38.1762269928620; Tue, 04 Nov 2025 07:25:28 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47754adcd08sm55590655e9.5.2025.11.04.07.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Nov 2025 07:25:28 -0800 (PST) Message-ID: <8954f888-60e8-48bb-8e87-4c1ce2d5dd97@redhat.com> Date: Tue, 4 Nov 2025 16:25:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/5] tap: Pad non-batched frames to 802.3 minimum (60 bytes) if needed To: Stefano Brivio , passt-dev@passt.top References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-2-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251103101612.1412079-2-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WOXIDpMsPGCa_CXepdrPZg50zVnlkt_wvmys-Ja3W6k_1762269929 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: G5JGCXEUBEH64EQFW7R6AO5DF5KEOUJP X-Message-ID-Hash: G5JGCXEUBEH64EQFW7R6AO5DF5KEOUJP X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/3/25 11:16, Stefano Brivio wrote: > IEEE 802.3 requires a minimum frame payload of 46 bytes, without a > 802.1Q tag. Add padding for the simple tap_send_single() case using > a zero-filled 60-byte buffer and copying data to it if needed. > > In theory, we could add a further element in the iovec array, say: > > uint8_t padding[ETH_ZLEN] = { 0 }; > struct iovec iov[3]; > > ... > > if (l2len < ETH_ZLEN) { > iov[iovcnt].iov_base = (void *)padding; > iov[iovcnt].iov_len = ETH_ZLEN - l2len; > iovcnt++; > } > > and avoid a copy, but that would substantially complicate the > vhost-user path, and it's questionable whether passing a reference > to a further buffer actually causes lower overhead than the simple > copy. > > Link: https://bugs.passt.top/show_bug.cgi?id=166 > Signed-off-by: Stefano Brivio > --- > tap.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tap.c b/tap.c > index bb139d6..8d8d84b 100644 > --- a/tap.c > +++ b/tap.c > @@ -131,9 +131,16 @@ unsigned long tap_l2_max_len(const struct ctx *c) > void tap_send_single(const struct ctx *c, const void *data, size_t l2len) > { > uint32_t vnet_len = htonl(l2len); > + uint8_t padded[ETH_ZLEN] = { 0 }; > struct iovec iov[2]; > size_t iovcnt = 0; > > + if (l2len < ETH_ZLEN) { > + memcpy(padded, data, l2len); > + data = padded; > + l2len = ETH_ZLEN; > + } > + > switch (c->mode) { > case MODE_PASST: > iov[iovcnt] = IOV_OF_LVALUE(vnet_len); with vnet_len updated: Reviewed-by: Laurent Vivier