From: Paul Holzinger <pholzing@redhat.com>
To: passt-dev@passt.top
Cc: Stefano Brivio <sbrivio@redhat.com>
Subject: Option parsing: Allow the same option multiple times
Date: Thu, 15 Jun 2023 14:57:37 +0200 [thread overview]
Message-ID: <895dae7d-3e61-4ef7-829a-87966ab0bb3a@redhat.com> (raw)
Hi all,
following up on a quick discussion with Stefano on IRC.
passt/pasta currently rejects most (not all) options when specified
multiple times, i.e. pasta -I eth0 -I eth1 ... fails. I think it makes
more sense to just use the last one instead.
My use case: In podman I added a new containers.conf option[1] which
allows users to set default pasta cli options. However users can also
add options on the podman cli with podman run --net=pasta:... For me it
would make the most sense to just append those to the config options and
then let pasta deal with it. This allows some form of overwrite
mechanism, i.e. by default I may have "-I" , "eth0" in containers.conf
but for one specific container I want to use a different interface name
and set --net=pasta:-I,eth1 on the cli. Then podman should just hand "-I
eth0 -I eth1" to pasta and then pasta picks the last one.
If we keep the current behavior it means I am forced to parse the
options in podman and dedup them which is hard to maintain as podman
would need to keep up with pasta upstream.
I am willing to send a patch to change this so please let me know if
anyone would object to that.
[1]
https://github.com/containers/common/commit/da3ac5d6d025f2933e655a0541eddbcf26070583
Thanks, Paul
next reply other threads:[~2023-06-15 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:57 Paul Holzinger [this message]
2023-06-16 21:04 ` Option parsing: Allow the same option multiple times Stefano Brivio
2023-06-19 4:49 ` David Gibson
2023-06-19 6:18 ` Stefano Brivio
2023-06-20 14:50 ` Paul Holzinger
2023-06-20 15:09 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895dae7d-3e61-4ef7-829a-87966ab0bb3a@redhat.com \
--to=pholzing@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).