Re: [PATCH] spec: use %selinux_requires macro, drop overlapping dependencies

[Max Chernoff <git@maxchernoff.ca>]

Hi Danish,

On Thu, 2025-11-13 at 12:52 +0530, Danish Prakash wrote:
> Also, drop unused preun policycoreutils requires.
>
> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> ---
>  contrib/fedora/passt.spec | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index d1bcf4a74338..cab2bb4c409b 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -34,19 +34,15 @@ for network namespaces: traffic is forwarded using a tap interface inside the
>  namespace, without the need to create further interfaces on the host, hence not
>  requiring any capabilities or privileges.
>
> -%package		selinux
> -BuildArch:		noarch
> -Summary:		SELinux support for passt and pasta
> -Requires:		selinux-policy-%{selinuxtype}
> -Requires:		container-selinux
> -Requires(post):		selinux-policy-%{selinuxtype}
> +%package		    selinux
> +BuildArch:		    noarch
> +Summary:		    SELinux support for passt and pasta
> +%selinux_requires

I think that we want "%selinux_requires_min" instead, since
"%selinux_requires" also pulls in "policycoreutils-python-utils" (and
hence all of Python).

(I'm not very familiar with spec files, but since the RPM macro
"%selinux_requires" is provided by the "selinux-policy" package, do we
also need to add a Requires/BuildRequires for that?)

> +Requires:		    container-selinux
> +Requires:		    selinux-policy-%{selinuxtype}

I think that "selinux-policy-%{selinuxtype}" is included via
"%selinux_requires" above.

>  Requires(post):		container-selinux
> -Requires(post):		policycoreutils
> -Requires(post):		libselinux-utils
> -Requires(preun):	policycoreutils
> -BuildRequires:		selinux-policy-devel
> -BuildRequires:		pkgconfig(systemd)
> -Recommends:		selinux-policy-%{selinuxtype} >= %{selinux_policy_version}
> +Requires(post):		selinux-policy-%{selinuxtype}
> +Recommends:		    selinux-policy-%{selinuxtype} >= %{selinux_policy_version}
>
>  %description selinux
>  This package adds SELinux enforcement to passt(1), pasta(1), passt-repair(1).

Everything else looks good to me.

Thanks,
-- Max