From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=maxchernoff.ca Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=maxchernoff.ca header.i=@maxchernoff.ca header.a=rsa-sha256 header.s=key1 header.b=tHvNIh0a; dkim-atps=neutral Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by passt.top (Postfix) with ESMTPS id A50AA5A061E for ; Thu, 13 Nov 2025 10:47:50 +0100 (CET) Message-ID: <8b1f10d9a674474e6d042b27cdee8d230bd15c0c.camel@maxchernoff.ca> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maxchernoff.ca; s=key1; t=1763027269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7MsIlEkKc18OkEKyOO+vlLiEkbCVWu4wvwyqJjd10rE=; b=tHvNIh0aehpVCawduMd+12XA1+sYntYBV40QDUCQgW0sAhLWpuhVvhWxIuJxVJVxEgxwN/ kcgOBq9TtiVgyULs1JYH+yhzwSUbcfdTzgkUFUh2O/naGm3PK+jf+CNKJOtrGE4egCSkoa g763r89HNDFmMybo8l7Rc7ntg6J/sVx1ZHe5EdfY1hRqNlQm6cnLwtqVSDm5/Ka+/5QPIC 70kGn1phH7ZsI7VprVnV+1fbY166tzLxN5L7OimsPzpKwh1nF6K5/on3XXOorUCRxAwHKq bkiKUEUMjH1Ey8Sqg7/B7rfr3iQwojHXWENespkcieAFV9FiwEiHxldEGALnGw== Subject: Re: [PATCH] spec: use %selinux_requires macro, drop overlapping dependencies X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Max Chernoff To: Danish Prakash , passt-dev@passt.top Date: Thu, 13 Nov 2025 02:47:42 -0700 In-Reply-To: <20251113072256.4034068-1-contact@danishpraka.sh> References: <20251113072256.4034068-1-contact@danishpraka.sh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-MailFrom: git@maxchernoff.ca X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: I3WKOHC7VD3UBJKPOPPQIO6YE6M3H22S X-Message-ID-Hash: I3WKOHC7VD3UBJKPOPPQIO6YE6M3H22S X-Mailman-Approved-At: Thu, 13 Nov 2025 12:06:00 +0100 CC: sbrivio@redhat.com, pholzing@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Danish, On Thu, 2025-11-13 at 12:52 +0530, Danish Prakash wrote: > Also, drop unused preun policycoreutils requires. > > Signed-off-by: Danish Prakash > --- > contrib/fedora/passt.spec | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec > index d1bcf4a74338..cab2bb4c409b 100644 > --- a/contrib/fedora/passt.spec > +++ b/contrib/fedora/passt.spec > @@ -34,19 +34,15 @@ for network namespaces: traffic is forwarded using a = tap interface inside the > namespace, without the need to create further interfaces on the host, he= nce not > requiring any capabilities or privileges. > > -%package selinux > -BuildArch: noarch > -Summary: SELinux support for passt and pasta > -Requires: selinux-policy-%{selinuxtype} > -Requires: container-selinux > -Requires(post): selinux-policy-%{selinuxtype} > +%package selinux > +BuildArch: noarch > +Summary: SELinux support for passt and pasta > +%selinux_requires I think that we want "%selinux_requires_min" instead, since "%selinux_requires" also pulls in "policycoreutils-python-utils" (and hence all of Python). (I'm not very familiar with spec files, but since the RPM macro "%selinux_requires" is provided by the "selinux-policy" package, do we also need to add a Requires/BuildRequires for that?) > +Requires: container-selinux > +Requires: selinux-policy-%{selinuxtype} I think that "selinux-policy-%{selinuxtype}" is included via "%selinux_requires" above. > Requires(post): container-selinux > -Requires(post): policycoreutils > -Requires(post): libselinux-utils > -Requires(preun): policycoreutils > -BuildRequires: selinux-policy-devel > -BuildRequires: pkgconfig(systemd) > -Recommends: selinux-policy-%{selinuxtype} >=3D %{selinux_policy_version= } > +Requires(post): selinux-policy-%{selinuxtype} > +Recommends: selinux-policy-%{selinuxtype} >=3D %{selinux_policy_ver= sion} > > %description selinux > This package adds SELinux enforcement to passt(1), pasta(1), passt-repai= r(1). Everything else looks good to me. Thanks, -- Max