From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AAE/Dovg; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 508635A004C for ; Fri, 08 Nov 2024 13:51:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731070265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CSXY9d6MjCyEdUkD0nvtGbUYYtbIN9rC+doSkRZqLdE=; b=AAE/Dovg4zV7x7+Y3O5q9ZwktZHKS2Y3gOufD21os2zFDrHE80ZpfUyVxhME1udJQGDh0Z fMWQAcan2AENGoG4rdjiPHqMARl3chbArP7NGvHpDElsLrUpwBLFX4Ux6K1xIh3wbeXvw8 nIYn9oWyRdULicPpxcgd7ZmbB1ljnro= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92--au7MibYMWymF7hMLAOdaQ-1; Fri, 08 Nov 2024 07:51:03 -0500 X-MC-Unique: -au7MibYMWymF7hMLAOdaQ-1 X-Mimecast-MFC-AGG-ID: -au7MibYMWymF7hMLAOdaQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4315eaa3189so18566185e9.1 for ; Fri, 08 Nov 2024 04:51:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731070262; x=1731675062; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CSXY9d6MjCyEdUkD0nvtGbUYYtbIN9rC+doSkRZqLdE=; b=WVgqsR3tmGMKDG4oJzXuG86ypqtue7ET/LKCw1OLCdwJ047Yz93NIHxBgAWPxXAuGh RESD6Yt30VQ/ee0froOdIyjoeRYmV19NMOV1E1ctbRQH59fShukovjj0W50NiTdhyRq5 koCjRdkbInetkByutFysR6CTph77e+rl27sMM1N90rhsBKLGXvUEBiwxq+tG3Q7RIpZv dtDFaer5/iGy0ocW+Dqdi3j/JqgF0O3OLP0w/N901i/WzKz9Oug/QRVHgXf82V3t71uU v3Wk+8Dk6HEOAooQouIJjxKArl/oT7loeqO7/1LLDTDqURc4v9GwEtoPCWkg+o3bTZWy 0HOw== X-Gm-Message-State: AOJu0YwX0WJ6MSkI8Ix6XS9EZXBG+Gxwqe/PzL45WJWgakGcQwkl9fUd uyjXj25TilK10LxZJ6u7whSg7F9Iw8Hp27hscgOCURqr0GppMnx0yCm9hExnVHNHHynVlCHD8Mr fqFQjp9N0otV5hK3Kd7wHiYBRITHVKWDBfV3/QRzvHWYfzxXq+A== X-Received: by 2002:a05:600c:4f10:b0:431:52a3:d9d5 with SMTP id 5b1f17b1804b1-432b74a07femr28138195e9.0.1731070262662; Fri, 08 Nov 2024 04:51:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHthwg0fJY7MHKOio2QEju/Ig+Sv5sbUwKaYNT70cn0oAX3WQvXG0PkZkBj9c4DhHlVWJVgDg== X-Received: by 2002:a05:600c:4f10:b0:431:52a3:d9d5 with SMTP id 5b1f17b1804b1-432b74a07femr28137945e9.0.1731070262271; Fri, 08 Nov 2024 04:51:02 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b05e5871sm64820205e9.37.2024.11.08.04.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 04:51:01 -0800 (PST) Message-ID: <8c2572f9-7d63-43fd-9615-9116b943e1fd@redhat.com> Date: Fri, 8 Nov 2024 13:51:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 00/12] Add vhost-user support to passt. (part 3) To: Stefano Brivio References: <20241108103733.3554357-1-lvivier@redhat.com> <20241108122728.2c8aad3d@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241108122728.2c8aad3d@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -fhG6KCjncyCBdRHAoafCKHcHWGq_cW3APRdRsY1DLI_1731070263 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: GN2B7CIXZY72JYW45BDRXQTAH5TG3FXK X-Message-ID-Hash: GN2B7CIXZY72JYW45BDRXQTAH5TG3FXK X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08/11/2024 12:27, Stefano Brivio wrote: > On Fri, 8 Nov 2024 11:37:19 +0100 > Laurent Vivier wrote: > >> v10: >> - rebase v9 on top of my changes >> - remove last 4 patches from v9 as >> 'tcp: Pass TCP header and payload separately to tcp_fill_headers[46]()' >> introduces a regression in "make check" for me. >> - addressed comments from David >> - I tried to cleanup iov management, but I was not able to remove the >> update of the first iov to point to the header or to the data >> - upd_vu_hdrlen()/tcp_vu_hdrlen() includes now the size of the >> virtio-net header >> - I didn't address comments from Stefano. >> - I didn't fix the bug with seek_offset_cap > > ...is there anything in particular you need reviewed on this revision? > No, I'm posting because it's too long I haven't shared. I'm rebasing to the top of master, perhaps there will be a new version soon. Thanks, Laurent