From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D8elXOIp; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id CF17B5A004E for ; Thu, 08 Jan 2026 14:17:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767878223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mfod1Qpi9lWqtTcWRrmYDmM+wljSTEe6CGTg3XQy1Ao=; b=D8elXOIpUtsoAOgsjBTj9DISN9uXr3YIELCP4biNRstzjlPE0yOHhWcY2x/vrGt9PjkG5i Ar00XebkA9VyEL5wG6OSpeacy/5/0aBv03AA0pQ5RY8w0rFWuu7FYkbO/ZwmwNXfvyAAhC RALOIth83aP2dNsgJB20pT6MbSvxfN4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-zbJIFL18N_qymM8NqW4Nvw-1; Thu, 08 Jan 2026 08:17:02 -0500 X-MC-Unique: zbJIFL18N_qymM8NqW4Nvw-1 X-Mimecast-MFC-AGG-ID: zbJIFL18N_qymM8NqW4Nvw_1767878221 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47d3c4468d8so21701735e9.2 for ; Thu, 08 Jan 2026 05:17:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767878221; x=1768483021; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mfod1Qpi9lWqtTcWRrmYDmM+wljSTEe6CGTg3XQy1Ao=; b=H7O0Pk8zZBseMn17tErRo9wdnxyNJCrVLJxNAXZ9N4D5BRVVsTqvHqiSMSh7dMyoua KCSJPw8HWmXPN814/luT1sKpue4Hh3rBXDNFbfBnFWGbk2j7KViWWCx+J5QUYD+8Y9V/ ijZ9CFe9KLM5R+HlIGXua2hFevTqIoUU1BNbG4CnNAKm76QFe6LizsMJCTVzVSF+SD5T A2xyktNueJZ18RcOuk3mA2BmOlRyJ5hJLDsM1h4IYtTyY34IAwXTBvNDSQwTeVd5uNub BZlNc1vZFrhBjP3dlzWlSmzOMSM+u5HvmUoZlSKM69fulLhwYBgd8d4Cw6Z/A3mNSgJA aBOQ== X-Forwarded-Encrypted: i=1; AJvYcCWR7mYulWotVPut5jXlMVF+aRLWGufzAnncciKJlE8mPgvIxhtQLLP2XT6cvunSWluDrjlukG9Uvmw=@passt.top X-Gm-Message-State: AOJu0Yzu8yWhkJeTouMWkudgGzgSxismMouJhDJw59LJ+Z8CwFFvZ8wV c2ao8grcoIgUgqeOjEr1XlLiiIOpc/LadEATwy1w3VBoWlVAb/AzgWpbkDkbXxd7Q43PpdRa1Ja DwNjNfGm88Isqm62LmwqEyyW2GPWPxvqzYkhI8QgnhRA+Aipy65pNFA== X-Gm-Gg: AY/fxX5IO3cT7yKHIsQhx7gSfPAfBrtXAsxmWXrVQTXav/CHDizeOWAYmvYyvKGNjez ErEjQMN7bt1xUj8BHXIGtmECzjgOlB5LAzG46CpibrJQrAu+qzrUnWYNJajgF2hTQ4tpfa2A1V7 ED6C+XgQx6BwKkvfZ/4Qw1gLrlOlWM0+PYRgnIpAA91yEezw0Q/5VV4VA12YH9LUaRSigFyHvBD 2uo1+HYFkcVDyCnmF+Dq0gGR34VE4RnF4oMNnDumw2agVuTenlUxbserHPhaOELslALyjguNnlv pmwLXfmRgujH/msonFOsA20TUj4r5CFlw4FYx/V1THeo8ik48J8X/Amkup2lvcTG8GZpgYXudZU OCreL9s9OWmRf7XYi2vFwQZhgAoxk+piKqO1IFukRsYntr1OV X-Received: by 2002:a05:600c:3146:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-47d84b3b513mr71652385e9.28.1767878221269; Thu, 08 Jan 2026 05:17:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpsAWjGrXl3XETaM/I102RFqFnNRI2foYxpWccI8n4hAd5WY5ztGVk5d/Ukdqz1EW1yml2XQ== X-Received: by 2002:a05:600c:3146:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-47d84b3b513mr71652105e9.28.1767878220761; Thu, 08 Jan 2026 05:17:00 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f7053f5sm148860015e9.14.2026.01.08.05.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 05:17:00 -0800 (PST) Message-ID: <8dd38f2a-e4ab-47ad-b3c7-1fcb560f57fb@redhat.com> Date: Thu, 8 Jan 2026 14:16:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/14] inany: Extend inany_ntop() to treat NULL as a fully unspecified address To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260108022948.2657573-1-david@gibson.dropbear.id.au> <20260108022948.2657573-2-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260108022948.2657573-2-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M2-TE4FghIbdheFQLpWDPd1iRw85DZcJge7AWojPfmI_1767878221 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: DMLWXCLAHTLDX2PWBH4YJOLVHA5YGRVT X-Message-ID-Hash: DMLWXCLAHTLDX2PWBH4YJOLVHA5YGRVT X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/8/26 03:29, David Gibson wrote: > In a number of places we're using a convention that a NULL inany represents > a dual-stack unspecified address, that is one which includes both 0.0.0.0 > and ::. Extend inany_ntop() to handle that convention, representing it > as "*". > > Signed-off-by: David Gibson > --- > inany.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/inany.c b/inany.c > index 7680439d..87a4d8b6 100644 > --- a/inany.c > +++ b/inany.c > @@ -22,7 +22,7 @@ const union inany_addr inany_loopback4 = INANY_INIT4(IN4ADDR_LOOPBACK_INIT); > const union inany_addr inany_any4 = INANY_INIT4(IN4ADDR_ANY_INIT); > > /** inany_ntop - Convert an IPv[46] address to text format > - * @src: IPv[46] address > + * @src: IPv[46] address (NULL for unspecified) > * @dst: output buffer, minimum INANY_ADDRSTRLEN bytes > * @size: size of buffer at @dst > * > @@ -30,9 +30,12 @@ const union inany_addr inany_any4 = INANY_INIT4(IN4ADDR_ANY_INIT); > */ > const char *inany_ntop(const union inany_addr *src, char *dst, socklen_t size) > { > - const struct in_addr *v4 = inany_v4(src); > + const struct in_addr *v4; > + > + if (!src) > + return strncpy(dst, "*", size); > > - if (v4) > + if ((v4 = inany_v4(src))) > return inet_ntop(AF_INET, v4, dst, size); > > return inet_ntop(AF_INET6, &src->a6, dst, size); Reviewed-by: Laurent Vivier