From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e524F+HV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 998B65A0269 for ; Mon, 11 May 2026 15:32:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778506337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CSCJcRcNlKt87afwm10aUc5CshgK8gaNAKVPq0gxhUk=; b=e524F+HVMSlMvY+9pPFNRdoIdtlLSANNMWPAZjBy9bD+PLfSXNZa7C8jh84H091uA6tIqd RipUQN7h0zLUnWTP2qa9Qrr12Z+iOBGbYCBvMucio7u5oEiTAV6qDt1tG7rZCPR4IH0vbP 1iK3gw081MVcwS5yUnQTjbflVs2YkeA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-djic4e6cPvezdsfM93NoXA-1; Mon, 11 May 2026 09:32:16 -0400 X-MC-Unique: djic4e6cPvezdsfM93NoXA-1 X-Mimecast-MFC-AGG-ID: djic4e6cPvezdsfM93NoXA_1778506335 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488d1b5bca0so21720245e9.2 for ; Mon, 11 May 2026 06:32:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778506334; x=1779111134; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CSCJcRcNlKt87afwm10aUc5CshgK8gaNAKVPq0gxhUk=; b=adzA31qq8qcRr2eGyn6NTIQrFx1ONDUEyw1gRJY6tEkfELuHt9K7k/sPxrNeih2/Ht TG+xcTkPULlbHorHQkeTXDwKMpMpgQddTzNxiZHTNQ4fEHTZbnBcbgIa3/TjprdB61tU z1ugvEsv0WTyG65oo0pEhjQ6nfIyJP68cBe/V5LFRNwqrRX4m2Iwrqaelk+zt/bgCBtf 53ljztdI3bGVqpvpkVflK7Vy5jMeBhGlR2WD4lis8+bgiqKu6vyVbmWto5RZM4RRxjzH Mm2tHAe+Omi61pvJgJRQS6NMEi5pvyi5etfX0F9dGbBQ6FWXFFmQs0CMJE5unWC/BN74 DGGw== X-Forwarded-Encrypted: i=1; AFNElJ/sZp5Js31EXXjFW5DfX5fm6nw30tdw5BKpIxdALsb4bqqEWdKDxBqq7e38199dkIMyEb03PdLTA94=@passt.top X-Gm-Message-State: AOJu0YxiErJcXLdmC6/ZXAjY95IH00bHBSzqIILcScB+HSi+KRQ3SABI ai6uSdEbUP0RyqXx7soG4nuviJ/7Q5l5791iFwEAxrA/vO+BvLo7F7bdOskzMHIklB5MxSRUj5g YkYCEWi9FCGo401ndL+0hcpNjESVikZhH4jPiMNAJy01d7F2GCusEWuyt3Gis0A== X-Gm-Gg: Acq92OF1MPYjTf/cJyWbwkkH3KffGUb0yOCfcfvACH16bHOXx9v5X3aiCSMhS3qYtxT HJyD8rYpSTgxJoa5xbxZjPgby3w3ejhf9MBOVIsmQEvQHzat5ZeMsHbRzMdGi0ByC0N7HDp74e9 wQlrr0oJw4o2fkZTuHw3cUfpgTd6LiQ9Z67YNBeun2xoVzZKxjFksozFGSjnLLhu3UndHroyw97 iUrJeUBzohgGq90USMz+IKz+XNRAJ9MbtokinJray68h9U6I+ukWAEDkKGj5rbifzYzffBBcT/1 pxlqDj8SQ8v4P85G7RiBkyRDm/ST1HTLKhYmzP/JEP+0BA3z0c/Mgh/mJx6VGpd3y+eZ4dU1auD hkPj2JJFIlAX3hsAJ2mLNQARABJYMSo/6MGRsOGmgZZ6nhZ6UMXcOprM= X-Received: by 2002:a05:600c:198b:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48e676a5245mr244689225e9.14.1778506334531; Mon, 11 May 2026 06:32:14 -0700 (PDT) X-Received: by 2002:a05:600c:198b:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48e676a5245mr244688685e9.14.1778506333995; Mon, 11 May 2026 06:32:13 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e80ca2666sm107923575e9.10.2026.05.11.06.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 06:32:13 -0700 (PDT) Message-ID: <8e806b90-346f-4908-bb90-1bf394b959c3@redhat.com> Date: Mon, 11 May 2026 15:32:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] clang-tidy: Suppress some new unhelpful new warnings To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-9-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-9-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AIesxfzsbj-ckLyuhQ1KhpCRQVx80AwhKsQtTY6mhCI_1778506335 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: HB5GL4RTC46PZOD4HVVSDRHLV4SLZMZR X-Message-ID-Hash: HB5GL4RTC46PZOD4HVVSDRHLV4SLZMZR X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > clang-tidy 22.1.4 (or thereabouts) introduced some new warning categories > that while theoretically useful, trip in too many silly occasions to be > useful. Suppress them. > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > .clang-tidy | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/.clang-tidy b/.clang-tidy > index 773121f5..9ba43bf0 100644 > --- a/.clang-tidy > +++ b/.clang-tidy > @@ -86,6 +86,17 @@ Checks: > # #if directives. Don't insist on #ifdef instead. > - "-readability-use-concise-preprocessor-directives" > > + # clang-tidy, at least version 22.1.4 seems to generate a heap of > + # false positives for this warning, asking us to make things > + # static that are already used in other modules. > + - "-misc-use-internal-linkage" > + > + # Warning about bool/int conversions could sometimes be useful. > + # Unfortunately (as of clang-tidy 22.1.4) it warns in some really > + # dumb situations, like not allowing !, && etc. on bool inputs to > + # be treated directly as a bool. > + - "-readability-implicit-bool-conversion" > + > WarningsAsErrors: "*" > HeaderFileExtensions: > - h