From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bLCeDq5d; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 98C515A004E for ; Thu, 08 Jan 2026 14:22:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767878545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y2k8RlYhRgx6hx/36FJbNEMadXOAjhH8Xr+pH8oUBKI=; b=bLCeDq5dJGCpqrTK7NUxi4NeVECXPadR1r9skpjG23oAYJXqmh2CCPUqQP9Vn/flnTtlnc q+P9vpmW7nc1SLIJDJ7qdQBUmQ2Ik5c1jlIyN7fzZfcuiP8KSW1wi+6Xc8+CFHlICjv8qI o1EDdxdu1QgdVS3pFDYTGzO/OkEm35g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-Vv-o__kNOiSo1moCHoJXKQ-1; Thu, 08 Jan 2026 08:22:24 -0500 X-MC-Unique: Vv-o__kNOiSo1moCHoJXKQ-1 X-Mimecast-MFC-AGG-ID: Vv-o__kNOiSo1moCHoJXKQ_1767878543 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779b3749a8so26043155e9.1 for ; Thu, 08 Jan 2026 05:22:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767878543; x=1768483343; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y2k8RlYhRgx6hx/36FJbNEMadXOAjhH8Xr+pH8oUBKI=; b=FyNfeqR3qRgx3dIHOOG8EXdTV1gPeeGpj6pn8LbSCwAnTJhssE4TnA3O5um+3raYJq 6mkQ3dcUyfUvvE5u82RZR4MEEfpKxSpp5xzGwCO7TbMB7NPEjHuMYaFYvkHZOmmRmyju 2W257F5sfKHl55USTRl+dQl/GkqqpB8MTECYhXS3FcZDIEVKh4dG78EGcnXoXMpCqvTZ rfAa1ox2tW0rj4RjnxvgWsX1PNXd3qZmw3r50GT0k4B1tPlO+OqcqcoU6SPDs6IFo+xX P9VpbFBtwZXmZ9zw70QYbtAuo4hfLlK1T7/4D0zLQ/AMFCB7DTmSCl1JF56bYnwpH47D upaw== X-Forwarded-Encrypted: i=1; AJvYcCVu3tbvKWlOOl/yIXAIvcoJyUFLfeiC9SPLskPebwW3dgBxX2E/zea18TQFqpvrkBM76Adc+0wO/AQ=@passt.top X-Gm-Message-State: AOJu0YzgrKmJ71Z+gP1wKnMmTHdCz1gvaB4A0ejsAQv/G2YGNqDKEP1d ycNDq9N2xLgu7jLfXqbVRQyCTGK3QoreOdVCXa2sKC+C29RHW+RCFNQN7lRp4lQQW19P8SV+zMo 1qSkMZAAZstMdEQ35Xh2jk4PSJCbb6AG9L6XKVEYgL7h+707kzuiXrg== X-Gm-Gg: AY/fxX6cMqlPBxfbWrIOHA/HfEJmrzXrFD6QyvaKnKVGMqdgiMEh4tFA4xNG+7avv/Y JQ4v7HW0/XDCEFtOOQRhfpgNDOS963nakgqZuEgkJYXzYbFIb8C9a2GAMTTshgF3Hw9aOegJYOi Gb2CrPNtt2cADb8uU7PSJizJq4SVtwhYfxJGvSEWxPP+a6L2M80c9hGut9s0rET+9EYHgaY8u0E 92OTK7pJdU65ZXwzuwz/xY6ZPX2XMDwdNB5yWneJL9Re00DH4KqoTtvgqYgWMH6QbvztXDrl5t4 bE+ad6h+PSSGG+tL9Rsceq9D3ALGkQB5X4nIUraX1eQ0dZpsAkuXfvE7VP4XyyWawcIYFaCT3C9 UAeCIu6+lkzbTDK8P39yeRyCLUMIXdcllj66r+lT8Dqqasg13 X-Received: by 2002:a05:600c:1f84:b0:477:7b16:5fa6 with SMTP id 5b1f17b1804b1-47d84b26cc1mr67782895e9.3.1767878542853; Thu, 08 Jan 2026 05:22:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpP9moGZIFkSGETrOF1XaXwG6M6jN2plW/9hDP+XfimgcTHgdSfm+Ki/pDlGg2CjNs42DnZA== X-Received: by 2002:a05:600c:1f84:b0:477:7b16:5fa6 with SMTP id 5b1f17b1804b1-47d84b26cc1mr67782715e9.3.1767878542496; Thu, 08 Jan 2026 05:22:22 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f4184cbsm162365675e9.6.2026.01.08.05.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 05:22:22 -0800 (PST) Message-ID: <91ab17a2-744d-4e4d-b533-f2c5849883de@redhat.com> Date: Thu, 8 Jan 2026 14:22:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/14] ip: Add ipproto_name() function To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260108022948.2657573-1-david@gibson.dropbear.id.au> <20260108022948.2657573-7-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260108022948.2657573-7-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: m37C741XDrXbOQMM7S0apkBQ290vTEuphSEnHbyiZ6g_1767878543 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: WGL6QX2HGNJBEPFUGIAFHQFCICE7M5OA X-Message-ID-Hash: WGL6QX2HGNJBEPFUGIAFHQFCICE7M5OA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/8/26 03:29, David Gibson wrote: > Add a function to get the name of an IP protocol from its number. Usually > this would be done by getprotobynumber(), but that requires access to > /etc/protocols and might allocate. We can't do either of those once we've > self-isolated. > > Signed-off-by: David Gibson > --- > ip.c | 27 +++++++++++++++++++++++++++ > ip.h | 2 ++ > 2 files changed, 29 insertions(+) > > diff --git a/ip.c b/ip.c > index 9a7f4c54..f1d224bd 100644 > --- a/ip.c > +++ b/ip.c > @@ -67,3 +67,30 @@ found: > *proto = nh; > return true; > } > + > +/** > + * ipproto_name() - Get IP protocol name from number > + * @proto: IP protocol number > + * > + * Return: pointer to name of protocol @proto > + * > + * Usually this would be done with getprotobynumber(3) but that reads > + * /etc/protocols and might allocate, which isn't possible for us once > + * self-isolated. > + */ > +/* cppcheck-suppress unusedFunction */ > +const char *ipproto_name(uint8_t proto) > +{ > + switch (proto) { > + case IPPROTO_ICMP: > + return "ICMP"; > + case IPPROTO_TCP: > + return "TCP"; > + case IPPROTO_UDP: > + return "UDP"; > + case IPPROTO_ICMPV6: > + return "ICMPv6"; > + default: > + return ""; > + } > +} > diff --git a/ip.h b/ip.h > index 5830b923..42b417c5 100644 > --- a/ip.h > +++ b/ip.h > @@ -116,6 +116,7 @@ static inline uint32_t ip6_get_flow_lbl(const struct ipv6hdr *ip6h) > } > > bool ipv6_l4hdr(struct iov_tail *data, uint8_t *proto, size_t *dlen); > +const char *ipproto_name(uint8_t proto); > > /* IPv6 link-local all-nodes multicast address, ff02::1 */ > static const struct in6_addr in6addr_ll_all_nodes = { > @@ -135,4 +136,5 @@ static const struct in_addr in4addr_broadcast = { 0xffffffff }; > #define IPV6_MIN_MTU 1280 > #endif > > + Extra blank line > #endif /* IP_H */ Reviewed-by: Laurent Vivier