From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=B14dAK2p; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D99735A0626 for ; Tue, 06 Jan 2026 08:48:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767685715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uTAzL5jURK7Mz3WkaBx+5ZKBDUumuMJ501FbgZoTGR0=; b=B14dAK2phGiQYtxkIZlpIZOM264ehkQ2uQe9e7r/GHjQFRwoDT321C72w7W8pDc7twa1Gh wrkBJlmCgi262i+jRb36L5zoNSDPj3nHC6cxQMTNslPiCLhN08yaRXuDuOgFk2DQrv7Wih F8yJzUWBhl4U6InSmb9DMOo8ugzyeMQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-DZmhJ9atOMSOw-_5XV_lZg-1; Tue, 06 Jan 2026 02:48:33 -0500 X-MC-Unique: DZmhJ9atOMSOw-_5XV_lZg-1 X-Mimecast-MFC-AGG-ID: DZmhJ9atOMSOw-_5XV_lZg_1767685713 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47a83800743so14086745e9.0 for ; Mon, 05 Jan 2026 23:48:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767685712; x=1768290512; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uTAzL5jURK7Mz3WkaBx+5ZKBDUumuMJ501FbgZoTGR0=; b=XVRdXrvwEgt6QHvyAqIQp4mYTk7P3ofOAP91IKF2fdllZr7X/KvYWRNngqqxqfyIvK RYcb0TYKibKY1K4m0VnZLCitrXJo8reJBIj8z42n4Af9X614BgWGQwOJsKcGOi8LHQIB LT4axsKnlzOD8Zux8E70RurvNAsB0/azD4TWT2ZXSn9OSiQqsJptyrcjxtOzrwA8mhvR ZAX7Y/N4qZc/sMjrS/Mq7oJ3f6vWjA8H5yMhE47aGCd92jST/A9qF/lttM0N5apyl6SW 9z+D0byGiKhWUPEBymdZmdQ4DJYlQu32UgF/PWIzmC2/cD45SiErsQi8Ymv34XgcNja3 Iy1A== X-Gm-Message-State: AOJu0YwImWdw0jY4D1+CVAeloD0GDn8oDr0DH3YFwfltkwPzNrKHcACs O6itwyZu1RV7U3pzO9XhU1T4mSC/yG10L+Qai5PTeaA9N7CwQvw1kxQ3OXkKnD/6HTZ1LAp0ohm BX3HGUbt1ietNZHxEsspZplOF9hGVMnCyOdiL+rhiaGkPU6bpftCFR4yYMGvWXA== X-Gm-Gg: AY/fxX7CWP7jTOmaxkA7BkzSznFl/HFuU9VDUjCdCidfRUYoRoyKLRbTrZ2iEhUiViE pvajXTtpOXDgRWWjtpSoSnaP/An5m/mLgc7u6+RKBZybe7LCk071x+gfen1+k3Ur8f7MGVsCSWs Scvgcm6XmT+tEUSw2SGoWxqQ4pqtNrgPIP8Zaa8E+TW1hBzkJsvz3OPUgimqs2QRDGMq14psMnF TFdifMsG2I75C4YEcV17u68npdQqkhIQAeZ3u0nmg7WpmxsnRnSqbJP/V13I5KQ6X/iVLkTx5dF 8oDsHlsP31CfQh3TLJlSCnOqPjLlmS5rYEMivjW1Fa9vklR8Ac+CuHa5QRf5trb/lbBxYSR65jE NQynRT7kMwhfJqfK3wfNWowgcu3fEjzGrXxi7d0oDVSKq/AwQ X-Received: by 2002:a05:600c:3495:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-47d7f40a95fmr22145075e9.2.1767685712401; Mon, 05 Jan 2026 23:48:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFf/1kK/GvctVVSzpzAmBdHcrudZGkQCiS6mq9uAnOiZO+100nvCdnlrBuAcL7ZIbdyfiQCXA== X-Received: by 2002:a05:600c:3495:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-47d7f40a95fmr22144885e9.2.1767685711976; Mon, 05 Jan 2026 23:48:31 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f69e13bsm27206335e9.7.2026.01.05.23.48.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 23:48:31 -0800 (PST) Message-ID: <92742f50-f095-45af-b43b-4d49254886f6@redhat.com> Date: Tue, 6 Jan 2026 08:48:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] udp_vu: Discard datagrams when RX virtqueue is not usable To: David Gibson References: <20260105145016.394828-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fGNPPqhdEVJDCxQAe6g02Uc4rbkWmcQkwI8AIjIg9oY_1767685713 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: AUO42LBWDGX3BC6W3N55CZSKE3375OQA X-Message-ID-Hash: AUO42LBWDGX3BC6W3N55CZSKE3375OQA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/6/26 00:28, David Gibson wrote: > On Mon, Jan 05, 2026 at 03:50:16PM +0100, Laurent Vivier wrote: >> During vhost-user device initialization, UDP datagrams may arrive on >> listening sockets before the guest has enabled the RX virtqueue. >> >> When this happens, udp_vu_sock_recv() returns 0 without consuming >> the datagram from the socket. The caller, udp_sock_fwd(), uses a >> while loop with udp_peek_addr() to process pending datagrams. Since >> the datagram remains in the socket buffer, udp_peek_addr() keeps >> returning data available, causing a busy loop with 100% CPU usage. >> >> Add an early check for virtqueue readiness in udp_vu_sock_to_tap(), >> mirroring tcp_vu_data_from_sock(). When the queue is not enabled or >> not started, explicitly discard the datagram with recvmsg() and >> return. The caller will drain remaining datagrams through repeated >> calls. >> >> Fixes: 28997fcb29b5 ("vhost-user: add vhost-user") >> Link: https://bugs.passt.top/show_bug.cgi?id=185 >> Signed-off-by: Laurent Vivier > > My only concern here is that this will only consume a single datagram, > whereas it looks like the loop could consume multiple datagrams. I'm > guessing something higher up will keep calling this until the queue is > empty, but I'm not certain. Otherwise LGTM. I can move the change into udp_vu_sock_recv() (inside the datagram loop), it will be closer to what udp_buf_sock_to_tap() does: reads data with udp_sock_recv() and if fd_tap is not initialized tap_send_frames() drops them. Thanks, Laurent >> --- >> udp_vu.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/udp_vu.c b/udp_vu.c >> index c30dcf97698f..67f4ee619bfb 100644 >> --- a/udp_vu.c >> +++ b/udp_vu.c >> @@ -211,6 +211,17 @@ void udp_vu_sock_to_tap(const struct ctx *c, int s, int n, flow_sidx_t tosidx) >> struct vu_virtq *vq = &vdev->vq[VHOST_USER_RX_QUEUE]; >> int i; >> >> + if (!vu_queue_enabled(vq) || !vu_queue_started(vq)) { >> + struct msghdr msg = { 0 }; >> + >> + debug("Got UDP packet, but RX virtqueue not usable yet"); >> + >> + if (recvmsg(s, &msg, MSG_DONTWAIT) < 0) >> + debug_perror("Failed to discard datagram"); >> + >> + return; >> + } >> + >> for (i = 0; i < n; i++) { >> ssize_t dlen; >> int iov_used; >> -- >> 2.52.0 >> >