From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FctkV60q; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 129235A0262 for ; Tue, 05 May 2026 12:49:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777978155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Svobru/1eHeimM1hZzBXQndCFdV3umzPwthQrcMQgts=; b=FctkV60qmjVj3tBd3IWyOGFS/Ve9g3aO3vmTMS+Tt9FTl6xSR+MkSdnuok0KVN7aAXkSbL VGxhk6f2F+de6WZ7LnHlDXRWM+UHFZwRcZIxhwOnkyCx8wm7PqdOxjTEYMGmnl26cX1CzK eX0nJe7/GZIx2vH4H7o+kZI3EOrWsso= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-0BFRfq0TO4CAbP2jycIN0w-1; Tue, 05 May 2026 06:49:14 -0400 X-MC-Unique: 0BFRfq0TO4CAbP2jycIN0w-1 X-Mimecast-MFC-AGG-ID: 0BFRfq0TO4CAbP2jycIN0w_1777978154 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488d8deb75fso43247935e9.3 for ; Tue, 05 May 2026 03:49:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777978153; x=1778582953; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Svobru/1eHeimM1hZzBXQndCFdV3umzPwthQrcMQgts=; b=c3/33IBv0FiD+TktiY0qUSH7f/8CRXJc32iNzxK8muuJ4JBDG7T964JH5sD7SQTkpa P357JHfPIhzhNvSpwI1ZoX0mT9F3MViKtrHwlEGzaTcD5MKj25gK3H5sENk1RM2kvrhE AMJbXztJLSZKQ7GWj9iYYaP+Wf8rBWSFdbKT6ZIknjF3IDMsSGoqDYMi6Xo0zZdFUa/e g12NxFKSmkRlPWsQgi5mYaQXz+SPLkNyScPeOOrce5KfKFJCg3OdidW+0GtNjvQAM09G lWKkj8cWi4giHc/s61hVaNw5SEReMR/qFoAC28JhxaPS1Ns9D7G6fKTk+JzE/vevug8t GwGw== X-Forwarded-Encrypted: i=1; AFNElJ8Cb8KEtvsnTN433qR9nNLe+CYVbLUI4G0RnNeYIZgYHLqjB2XQnbLJDJK4kxE1CSaYcfg2PtA/uoA=@passt.top X-Gm-Message-State: AOJu0YxI3hCMonkYVfjNqQiWmknfiAEFtFPHozVNIm8sOBXdH1RGAcDj TY/MVeiOtLT+e0fYYPH0j+3lwofSOEjVqv3KcoGgUZNHqo6XwEcJR/pVzivs6KKSLfhU2uHCFXJ iRszHegOJCkhDz4oKzCZE3c+TMoD3qffNBldflV0ePg2aHH0g3KYflg== X-Gm-Gg: AeBDiesQ1hNLPzc1tnloANZ6g3fKs/L+STu7+4L+d+o+1WBBoIFrs4/5vJOjzuOiD0Y XdA/ZPcVf+DKxMtc+bA+z2FtsIja/6ptDrDX2CxrktOuOP+Aq/jivB7g65UM+6fQeypL94TIFDp Sow6skBp07/+FFFxEm3MIh9YxR/MPHaecbrcCkzuF85AcLUPTlQt7iEL3m4a3VtGSa+ftFJNfpZ 2kD8HdiZOdblnhbGH3gyGekpo9ZN/ogG0xa8X4iTRHWJJImxPB3BE/wkjHk8CtCvm7YfNR86Ccb HXsXsj33OocwY7v0NkzLfTjTB6px0jC8WtBydHb7X1+Naz8YiNA2DZoSdhdslR12o6n4l26gjnT x1AU5D52rwzLWdAN7Z9zBQOuycxJVJvvEUMRNctxvQDNWTjsIa4nwS8Tt0QMdQ74z2Q== X-Received: by 2002:a05:600c:628c:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48a988be16emr228365165e9.21.1777978153658; Tue, 05 May 2026 03:49:13 -0700 (PDT) X-Received: by 2002:a05:600c:628c:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48a988be16emr228364715e9.21.1777978153171; Tue, 05 May 2026 03:49:13 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a820c865esm381354745e9.5.2026.05.05.03.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 03:49:12 -0700 (PDT) Message-ID: <945d5ad2-a900-4a43-bb80-f45e99747f20@redhat.com> Date: Tue, 5 May 2026 12:49:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/13] Makefile: Use make variables for static checker configuration To: Stefano Brivio References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-2-david@gibson.dropbear.id.au> <20260505122048.2982126f@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260505122048.2982126f@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yVo3-dAivBkNq4kdF9Kq8v3Uk7LfrtR_HuNr0a2qiT0_1777978154 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: O5WPMKV6AAIESX6EAMN6NDCIR3WTHNVG X-Message-ID-Hash: O5WPMKV6AAIESX6EAMN6NDCIR3WTHNVG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/5/26 12:20, Stefano Brivio wrote: > On Tue, 5 May 2026 12:14:02 +0200 > Laurent Vivier wrote: > >> On 4/21/26 05:23, David Gibson wrote: >>> Our cppcheck and clang-tidy rules don't really follow normal Makefile >>> conventions. Usually any commands other than the very basics have their >>> binary specified in a variable so it can be overridden on the command line >>> if they're in an unusual location. Implement that for $(CPPCHECK) and >>> $(CLANG_TIDY) >>> >>> Likewise flags to tools usually have their own Make variable. Do the same >>> with $(CLANG_TIDY_FLAGS) and $(CPPCHECK_FLAGS). Note that these only have >>> the options specifically for the static checker, not compiler flags which >>> we are also supplying to the static checker - those are derived from >>> FLAGS / CFLAGS / CPPFLAGS as before. >>> >>> As part of that we change the probing for --check-level=exhaustive from >>> being run as part of the cppcheck target, to being run when we build the >>> CPPCHECK_FLAGS variable. That doesn't make any real difference now, but >>> will make things nicer if we need multiple cppcheck targets in future (e.g. >>> for passt-repair). >>> >>> Signed-off-by: David Gibson >>> --- >>> Makefile | 32 +++++++++++++++++++------------- >>> 1 file changed, 19 insertions(+), 13 deletions(-) >>> >>> diff --git a/Makefile b/Makefile >>> index f697c12b..17e70d22 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -174,21 +174,27 @@ docs: README.md >>> done < README.md; \ >>> ) > README.plain.md >>> >>> +CLANG_TIDY = clang-tidy >>> +CLANG_TIDY_FLAGS = -DCLANG_TIDY_58992 >>> + >>> clang-tidy: $(PASST_SRCS) >>> - clang-tidy $^ -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \ >>> - -DCLANG_TIDY_58992 >>> + $(CLANG_TIDY) $^ -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \ >>> + $(CLANG_TIDY_FLAGS) >>> >>> -cppcheck: $(PASST_SRCS) $(HEADERS) >>> - if cppcheck --check-level=exhaustive /dev/null > /dev/null 2>&1; then \ >>> - CPPCHECK_EXHAUSTIVE="--check-level=exhaustive"; \ >>> - else \ >>> - CPPCHECK_EXHAUSTIVE=; \ >>> - fi; \ >>> - cppcheck --std=c11 --error-exitcode=1 --enable=all --force \ >>> +CPPCHECK = cppcheck >>> +CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ >>> --inconclusive --library=posix --quiet \ >>> - $${CPPCHECK_EXHAUSTIVE} \ >>> --inline-suppr \ >>> - --suppress=missingIncludeSystem \ >>> + $(shell if $(CPPCHECK) --quiet --check-level=exhaustive /dev/null; then \ >>> + echo "--check-level=exhaustive"; \ >>> + else \ >>> + echo ""; \ >>> + fi) >> >> Perhaps we can add a reusable function to check flags: >> >> check_flag = $(shell $(1) $(2) >/dev/null 2>&1 && echo $(2)) >> >> Then >> $(call check_flag, $(CPPCHECK) /dev/null, --check-level=exhaustive) >> \ >>> + --suppress=missingIncludeSystem \ >>> --suppress=unusedStructMember \ >>> - $(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -D CPPCHECK_6936 \ >>> - $^ >>> + -D CPPCHECK_6936 >>> + >>> +cppcheck: $(PASST_SRCS) $(HEADERS) >>> + $(CPPCHECK) $(CPPCHECK_FLAGS) \ >>> + $(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) $^ \ >>> + $^ >> >> You have duplicate '$^' here. > > Just note that it's not necessarily important to review this series > right now (I'm not sure). okay, I was reviewing it because "Dynamic configuration" series doesn't apply cleanly without it. > > I guess if we can "fix" it (see my concerns about 4/13) quickly, then > it's useful, and I'll try to pick it up like that (feel free to post a > new version yourself, of course!). > > But if it needs major reworks I'd rather try to come up with something > minimal instead, for the moment. > Thanks, Laurent