From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5CB9E5A0082 for ; Thu, 16 Feb 2023 17:53:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676566390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PC7+U/AgzcOEWG5qJOnRFT8TzsBKPLbwINY2mbJ3z5M=; b=fxlVDdtkSRz/bP8ka3qV/BsUwvSI/w+BnsnEAaxI7K8nlQyZ4qYZQJvFH+Fe6PJa2QHXui b8HKDyvtX8zuEeE9emCesq19DCHEx87kzCiYbADWyGo60FfFV21O1AYlsfiAoZoyS/wMbW zjzM9RLGPgAj4Og2iHoTqPpa9mVPrbA= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-250-Lg6mUnGOOSOUpj4bam-mig-1; Thu, 16 Feb 2023 11:53:09 -0500 X-MC-Unique: Lg6mUnGOOSOUpj4bam-mig-1 Received: by mail-qt1-f197.google.com with SMTP id bz17-20020a05622a1e9100b003b9c1013018so1519671qtb.18 for ; Thu, 16 Feb 2023 08:53:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PC7+U/AgzcOEWG5qJOnRFT8TzsBKPLbwINY2mbJ3z5M=; b=v6ys5mwm8EsHQl/LOnFbSPgRV8eT3gKVV3xf6hSagNGPw+H2q7fRoDavXdTcomtw4O m+TAP/Ap+HVhJ6CWaYobfoziN9kq/gxixveFhitCSe5OSL4/GvhQZ0KYdd+hGALEOzQ+ 0kirM9ZU/Qe7jz6QkuJ2IwF6nYU8l2DjB1JxadtQ9v8XckP9QoDwdB3+cowtgBxHBAGA nGR+FS/bAQmX038lJJDC+rdR7kq1S9r3BVnVmcPFZYXrtTKqVoDxfzZ+RR8ALdjESfsa 96hrDdUIAIFFYBkd87DI6W4EMFzTkpAqCr/QuKVjSolN4aG9ZlmlpzLM6b8cRntCEQSq B/9w== X-Gm-Message-State: AO0yUKWM9QKmRBft6ZZz/2MTemHNaPUfWazDNhcPYFiknKZ1Sze2LDf/ jYhnPdMqCcUEm6keNuCqHnaacGMllaU0d6z4g/btz9gImLCosE+SV/z9fR1/bkYZVMXfv1hnzfo 1RKjA7c7emNNmF4K1OuW5OykHCMk/dgIuyKsX6uhavC1cqC/I4h4jIy3w1dNO3SqkZw== X-Received: by 2002:a05:622a:15ce:b0:3bc:f954:3257 with SMTP id d14-20020a05622a15ce00b003bcf9543257mr10540856qty.35.1676566388681; Thu, 16 Feb 2023 08:53:08 -0800 (PST) X-Google-Smtp-Source: AK7set9xbb9ekau797WksYzY9iolmgYm1AtrCcWv0X17V6HU8Q9UR2wnArS+moZASPnPezPux70iZA== X-Received: by 2002:a05:622a:15ce:b0:3bc:f954:3257 with SMTP id d14-20020a05622a15ce00b003bcf9543257mr10540834qty.35.1676566388394; Thu, 16 Feb 2023 08:53:08 -0800 (PST) Received: from ?IPV6:2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7? ([2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7]) by smtp.gmail.com with ESMTPSA id bn3-20020a05622a1dc300b003b80a69d353sm1530255qtb.49.2023.02.16.08.53.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 08:53:08 -0800 (PST) Message-ID: <96233b85-93de-6174-b64f-3655d9fb3642@redhat.com> Date: Thu, 16 Feb 2023 11:53:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] passt.1: Fix typo, improve wording in examples of port forwarding specifiers To: passt-dev@passt.top References: <20230216072335.2238277-1-sbrivio@redhat.com> From: Laine Stump Organization: Red Hat In-Reply-To: <20230216072335.2238277-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: V7QEWCHCDMJBVQJNG2WF7BIOLCN7P5GY X-Message-ID-Hash: V7QEWCHCDMJBVQJNG2WF7BIOLCN7P5GY X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Yalan Zhang , Stefano Brivio X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/16/23 2:23 AM, Stefano Brivio wrote: > Based on a patch from Laine, and reports from Laine and Yalan: fix > the "22-80:32-90" example, and improve wording for the other ones: > instead of using "to" to denote the end of a range, use "between ... > and", so that it's clear we're *not* referring to target ports. > > Reported-by: Laine Stump > Reported-by: Yalan Zhang > Fixes: da20f57f19dc ("passt, qrap: Add man pages") > Signed-off-by: Stefano Brivio Reviewed-by: Laine Stump (if I'm allowed :-) > --- > v2: Adopted further changes proposed by David > > passt.1 | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/passt.1 b/passt.1 > index 528763b..f317c33 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -338,7 +338,7 @@ Examples: > .RS > .TP > -t 22 > -Forward local port 22 to 22 on the guest > +Forward local port 22 to port 22 on the guest > .TP > -t 22:23 > Forward local port 22 to port 23 on the guest > @@ -347,10 +347,10 @@ Forward local port 22 to port 23 on the guest > Forward local ports 22 and 25 to ports 22 and 25 on the guest > .TP > -t 22-80 > -Forward local ports 22 to 80 to corresponding ports on the guest > +Forward local ports between 22 and 80 to corresponding ports on the guest > .TP > --t 22-80-32:90 > -Forward local ports 22 to 80 to corresponding ports on the guest plus 10 > +-t 22-80:32-90 > +Forward local ports between 22 and 80 to ports between 32 and 90 on the guest > .TP > -t 192.0.2.1/22 > Forward local port 22, bound to 192.0.2.1, to port 22 on the guest > @@ -359,10 +359,12 @@ Forward local port 22, bound to 192.0.2.1, to port 22 on the guest > Forward local port 22, bound to 192.0.2.1 and interface eth0, to port 22 > .TP > -t 2000-5000,~3000-3010 > -Forward local ports 2000 to 5000, but not 3000 to 3010 > +Forward local ports between 2000 and 5000, except for those between 3000 and > +3010 > .TP > -t 192.0.2.1/20-30,~25 > -Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1 > +For the local address 192.0.2.1, forward ports between 20 and 24 and between 26 > +and 30 > .TP > -t ~20000-20010 > Forward all ports to the guest, except for the range from 20000 to 20010 > @@ -425,10 +427,11 @@ Forward local port 22 to port 23 in the target namespace > Forward local ports 22 and 25 to ports 22 and 25 in the target namespace > .TP > -t 22-80 > -Forward local ports 22 to 80 to corresponding ports in the target namespace > +Forward local ports between 22 and 80 to corresponding ports in the target > +namespace > .TP > --t 22-80-32:90 > -Forward local ports 22 to 80 to corresponding ports plus 10 in the target > +-t 22-80:32-90 > +Forward local ports between 22 and 80 to ports between 32 and 90 in the target > namespace > .TP > -t 192.0.2.1/22 > @@ -438,13 +441,15 @@ Forward local port 22, bound to 192.0.2.1, to port 22 in the target namespace > Forward local port 22, bound to 192.0.2.1 and interface eth0, to port 22 > .TP > -t 2000-5000,~3000-3010 > -Forward local ports 2000 to 5000, but not 3000 to 3010 > +Forward local ports between 2000 and 5000, except for those between 3000 and > +3010 > .TP > -t 192.0.2.1/20-30,~25 > -Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1 > +For the local address 192.0.2.1, forward ports between 20 and 24 and between 26 > +and 30 > .TP > -t ~20000-20010 > -Forward all ports to the namespace, except for the range from 20000 to 20010 > +Forward all ports to the namespace, except for those between 20000 and 20010 > .RE > > IPv6 bound ports are also forwarded for IPv4.