From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Gwyem174; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1C04F5A061C for ; Fri, 17 Jan 2025 14:58:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737122315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oxaPHqfIzN67hJc/UhejPnYdexka28yJ7L95wzA09wE=; b=Gwyem174i3icg+GZkbDQxrovlJc4zFqr0sOX0qBD7rzXR+EwlFu6nh3dFS43QVWWStDgb8 qDhiAgu7kZlUnvRRW7Gvbv3VSvWkqM2Unm9iiqhDRk2/MdUAIJYspK/k/zDRjFocCwWo2j kD1k9jY03lNX8DlbahVBelJJTWTIYy8= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-oHvRPnBUNEav3GoFuGj8aA-1; Fri, 17 Jan 2025 08:58:33 -0500 X-MC-Unique: oHvRPnBUNEav3GoFuGj8aA-1 X-Mimecast-MFC-AGG-ID: oHvRPnBUNEav3GoFuGj8aA Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-46791423fc9so43849751cf.2 for ; Fri, 17 Jan 2025 05:58:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737122313; x=1737727113; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oxaPHqfIzN67hJc/UhejPnYdexka28yJ7L95wzA09wE=; b=ZHtNoitaHNCphkHE/11Qp2yoaiUPVZpYNaufty4a178Lgt1W46egyx9YwPBVicyqeu 3C7TmW/Prnig2YeW6pj9bJ2EVi5uXaG+suUAk980TRRLv1zp2cq6fLN3P9LdRSleguG0 ItHBDv0xBPZVjxI/ESdMFBAjng0RMN5Z3e2ENbzhHhRRqkWIeLYYxRj5CDXryCqOjxlW FcJ3THLTJXUMoi6kVGhW6Wv6sjYIHJ0o/CUyWmsMDFYpRTndI9XuIUgWrgDLsOjjmUK9 rB9QXmEpGtlqy6Rl5ZczA8i19iro6Y2nbFmMF/DWSxevZCCSXE3Ok9q+0FCvcsxEssj5 CrrA== X-Gm-Message-State: AOJu0YzJCn1N5wMA/NQV/Q4XwvF2L43y2Xu4Rg5BQzbj72eaXWiCsiQD 1WEFB1WYjVDxdrsdVOxSlWAhbXy62BInDJxFt2hZ7OH91Z1qIUKOQwuHdfCzDWphB7gHS+lWuOc 4RpTH8XXkc0iE5dvSAgnWEBSSsV9UHHvsuJ8rZIBmPjbFpNKqtA== X-Gm-Gg: ASbGncsblzQW3G1zf793quYUQN67B7L8mPkH45tyoEzpaJtWVmr+uDunI9BF7LyWbRk DowiEEdntvclqkaU8Av4TPjBHzRjLEk3Bnrv8pmFgS43cHb7YYI7moKhmMlNbEgMIF49Gaap9nE 7Kt7IComEZwHC8b7iKZZQcBZZhyn842M4fvUp2KyoLq1BPZMs43QwxDd3KaT+YDVW2MzBWWYKcq yBA7aAMtd1mpNN119rWswbyQcTfd5envEnqyFbumeLWq4uXHp55LAzbh4EZZARTxUPLMA9oBbVq 9yK6UuBCUjDLJ+UygOI= X-Received: by 2002:a05:622a:20b:b0:466:9ab3:c2d0 with SMTP id d75a77b69052e-46e12bbc9b7mr45735181cf.44.1737122313454; Fri, 17 Jan 2025 05:58:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IES0bVo7moCH//10BTJy+ajZArJ3PYvQWsZ8JwqLTqg6P/XMyTadHtm20znP/Z8gC0GQxE3Ew== X-Received: by 2002:a05:622a:20b:b0:466:9ab3:c2d0 with SMTP id d75a77b69052e-46e12bbc9b7mr45734891cf.44.1737122313140; Fri, 17 Jan 2025 05:58:33 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46e10402997sm11329211cf.56.2025.01.17.05.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 05:58:32 -0800 (PST) Message-ID: <96f413e1-462f-4417-bd5c-ca80a72e326c@redhat.com> Date: Fri, 17 Jan 2025 14:58:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] vhost-user: Migration support To: Stefano Brivio References: <20241219111400.2352110-1-lvivier@redhat.com> <329e349d-f86c-479b-97ee-61397aa28c60@redhat.com> <20250117134445.5b341bdd@elisabeth> <20250117143829.7e861cac@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20250117143829.7e861cac@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -InN35lukQcaaAfvPhnkv1xfXQITceqbGDdbXDT_qas_1737122313 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: PFQR74KRSZFZUHJGRES5DZY2BGBD4ZIC X-Message-ID-Hash: PFQR74KRSZFZUHJGRES5DZY2BGBD4ZIC X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 17/01/2025 14:38, Stefano Brivio wrote: >> So we can implement VHOST_USER_SEND_RARP with an empty function (at least to silence the >> "Vhost user backend fails to broadcast fake RARP" message). > Oh, sure, if it's so annoying. And we can't just keep > VHOST_USER_PROTOCOL_F_RARP off in the feature flags? VHOST_USER_PROTOCOL_F_RARP is already off in passt. So vhost_user_migration_done() returns -ENOTSUP in QEMU. And then in vhost_user_receive(): r = vhost_net_notify_migration_done(s->vhost_net, mac_addr); if ((r != 0) && (display_rarp_failure)) { fprintf(stderr, "Vhost user backend fails to broadcast fake RARP\n"); fflush(stderr); display_rarp_failure = 0; } Thanks, Laurent