From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tcp: Close timer fd when removing it from epoll
Date: Tue, 20 Jan 2026 09:08:20 +0100 [thread overview]
Message-ID: <9b5a2108-b08d-4b8b-a8d7-9487437217be@redhat.com> (raw)
In-Reply-To: <aW21obJ6hLfiJOwE@zatzit>
On 1/19/26 05:40, David Gibson wrote:
> On Fri, Jan 16, 2026 at 01:55:57PM +0100, Laurent Vivier wrote:
>> When tcp_epoll_ctl() handles a CLOSED connection, it removes the timer
>> from epoll but leaves the fd open until tcp_flow_defer() eventually
>> closes it.
>>
>> Close the timer fd immediately when removing it from epoll, since
>> there's no reason to keep an fd around that's no longer monitored.
>> Set conn->timer to -1 to prevent a double-close in tcp_flow_defer().
>
> This seems safe to me, but is there any actual advantage to it?
>
No, you're right, there's no real advantage. Please drop this patch.
Thanks,
Laurent
prev parent reply other threads:[~2026-01-20 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 12:55 Laurent Vivier
2026-01-19 4:40 ` David Gibson
2026-01-20 8:08 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5a2108-b08d-4b8b-a8d7-9487437217be@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).