From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Gl6s7Vp7; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id BBC655A026F for ; Tue, 04 Nov 2025 16:50:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762271447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LmUPFoc2EuZurB4rfFKtdd45zuQDkAjEC4UgzPHn/O0=; b=Gl6s7Vp7+wshBI+QAmvXHNm/CAtp1WJ5tvPsvyI6EA5utG2To/FxGD6cGqtUh4xA48//44 /16NJky0tDNOnQR2yrp+8snLtgVTftMjRLDl3BaE+LA8mLMOrxCWaJGVeACF7wjkvSXB2B EkVA9e268mZSyU66rwMSRHbZXMlQDQ8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-TGe7M5l1NN21oZzvfAZ9HA-1; Tue, 04 Nov 2025 10:50:46 -0500 X-MC-Unique: TGe7M5l1NN21oZzvfAZ9HA-1 X-Mimecast-MFC-AGG-ID: TGe7M5l1NN21oZzvfAZ9HA_1762271445 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-429cce847c4so1695184f8f.2 for ; Tue, 04 Nov 2025 07:50:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762271445; x=1762876245; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LmUPFoc2EuZurB4rfFKtdd45zuQDkAjEC4UgzPHn/O0=; b=KNem8k+jCPGXPNCW9eD9QXvotLJGeZOyMtwbae3aNnyeDZJi92btjmmrG0t3ue1Cxa fQHh6GlYRGicoKvLA5N5ZaF7j42CVX8rydjAQPsVYCkPh/Vzyk10d/Vk7554U5QBWgRb ymTtqj7NeW7tJhh2sDLhIucpuz8MDq9GvHt9lWIRTcJmFevQWn4raR0ug7njUTOJ0WFV a+DS7lS+FMxWgsaiPBkG6rnsLTb6yiTa1pCAXLljf6CNW03wrqXaG/A+E5P5uV7cZIkf wk0Z7SWKrknphew0+7FEtvuS5zhCn0qrx/X3ZLKUIzyHp/a61P5jm6IuR5SrT42YBxK+ CzYA== X-Forwarded-Encrypted: i=1; AJvYcCXuxi2JL0EM2GnXLCT5F0yThG/ziQUvSVXuIoxZcBG063WiiwV8T3f9TKIaEKxTqKDq4GAGf/hpXN4=@passt.top X-Gm-Message-State: AOJu0Yw2/IL5bVWbi+yXvmG6yYQzi+hE9u5eTx2zIpT1R9bMUW+tfVBz jjDwtxAw4VAHrJJtGWa1hMfXuKFkOiy2Ouv9okV6yTwXG2auIveO+bb64QSrPx9UlYmoe914EN/ C3z1e6ef7J+C9xfBEcsuI7CTgZdusy/s3Efo58pAGbUsR94OgoCUrhowKgKUeDb1D X-Gm-Gg: ASbGncveZhaqy/juWDmntnoqow/xkkeeh8Zi4TRMfwPhEWRWmYurpahEhSNkKVsJo7P 28ekw+Caq52HYgZz5hUZq0vwfAF5hiWn1ZeQBdvVly1Mlc5U0pfgmkk5vXVKPNad4ybEk/e8UAg XBTTQWZfwypUcRS4hnPK+2QzitRoeDopK/pBgYuW5xeRYnirZsVJ2SFDnaxbvFa32W2aN1iA2lH ZdDf0gv8kJA3QPkmyIiBGsM/GIaI6CyOQuyAymY8BfOKx1Z0W7u+7g2DQZyKszqSAYXA6Wqt6uG Bk0xMy52DZOGSYCyyMLGK+d99n3jBzz6no7f2yFS5tB3cIbJ2sC2eMUsVUXiloegPetIxigdRIL 8/Qvp5QgP19lW1FLpT6YZPOyzUSK0akmCZt23Rg== X-Received: by 2002:a05:6000:258a:b0:429:cd3f:f42f with SMTP id ffacd0b85a97d-429cd3ff727mr9742721f8f.61.1762271444879; Tue, 04 Nov 2025 07:50:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6PK1XQW1avvn9PEsR8Q1MpfNq4vDz5GvvubUwDCxc6sAsEqGMWcGcBh5GVR95zPAdlzrMZA== X-Received: by 2002:a05:6000:258a:b0:429:cd3f:f42f with SMTP id ffacd0b85a97d-429cd3ff727mr9742698f8f.61.1762271444465; Tue, 04 Nov 2025 07:50:44 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47755a550dfsm44960475e9.17.2025.11.04.07.50.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Nov 2025 07:50:44 -0800 (PST) Message-ID: <9d79c64e-e222-4444-8677-81891cd8fea3@redhat.com> Date: Tue, 4 Nov 2025 16:50:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] tcp, udp: Pad batched frames for vhost-user modes to 60 bytes (802.3 minimum) To: Stefano Brivio , passt-dev@passt.top References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-6-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251103101612.1412079-6-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WLEhpqBMlE40ejUrJJTeZswZ0JJzKrMg5BoJciG5uVY_1762271445 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 47UYNYI3ADI4FDUGZHKZZYOV2F37R35G X-Message-ID-Hash: 47UYNYI3ADI4FDUGZHKZZYOV2F37R35G X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/3/25 11:16, Stefano Brivio wrote: > For both TCP and UDP, we request vhost-user buffers that are large > enough to reach ETH_ZLEN (60 bytes), so padding is just a matter of > increasing the appropriate iov_len and clearing bytes in the buffer > as needed. > > Link: https://bugs.passt.top/show_bug.cgi?id=166 > Signed-off-by: Stefano Brivio > --- > tcp.c | 2 -- > tcp_internal.h | 1 + > tcp_vu.c | 27 +++++++++++++++++++++++++++ > udp_vu.c | 11 ++++++++++- > 4 files changed, 38 insertions(+), 3 deletions(-) > > diff --git a/tcp.c b/tcp.c > index e91c0cf..039688d 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -335,8 +335,6 @@ enum { > }; > #endif > > -/* MSS rounding: see SET_MSS() */ > -#define MSS_DEFAULT 536 > #define WINDOW_DEFAULT 14600 /* RFC 6928 */ > > #define ACK_INTERVAL 10 /* ms */ > diff --git a/tcp_internal.h b/tcp_internal.h > index 5f8fb35..d2295c9 100644 > --- a/tcp_internal.h > +++ b/tcp_internal.h > @@ -12,6 +12,7 @@ > #define BUF_DISCARD_SIZE (1 << 20) > #define DISCARD_IOV_NUM DIV_ROUND_UP(MAX_WINDOW, BUF_DISCARD_SIZE) > > +#define MSS_DEFAULT /* and minimum */ 536 /* as it comes from minimum MTU */ > #define MSS4 ROUND_DOWN(IP_MAX_MTU - \ > sizeof(struct tcphdr) - \ > sizeof(struct iphdr), \ > diff --git a/tcp_vu.c b/tcp_vu.c > index 1c81ce3..7239401 100644 > --- a/tcp_vu.c > +++ b/tcp_vu.c > @@ -60,6 +60,29 @@ static size_t tcp_vu_hdrlen(bool v6) > return hdrlen; > } > > +/** > + * tcp_vu_pad() - Pad 802.3 frame to minimum length (60 bytes) if needed > + * @iov: iovec array storing 802.3 frame with TCP segment inside > + * @cnt: Number of entries in @iov > + */ > +static void tcp_vu_pad(struct iovec *iov, size_t cnt) > +{ > + size_t l2len, pad; > + > + ASSERT(iov_size(iov, cnt) >= sizeof(struct virtio_net_hdr_mrg_rxbuf)); > + l2len = iov_size(iov, cnt) - sizeof(struct virtio_net_hdr_mrg_rxbuf); > + if (l2len >= ETH_ZLEN) > + return; > + > + pad = ETH_ZLEN - l2len; > + > + /* tcp_vu_sock_recv() requests at least MSS-sized vhost-user buffers */ > + static_assert(ETH_ZLEN <= MSS_DEFAULT); > + > + memset(&iov[cnt - 1].iov_base + iov[cnt - 1].iov_len, 0, pad); I think it should be memset((char *)iov[cnt - 1].iov_base + iov[cnt - 1].iov_len, 0, pad); > + iov[cnt - 1].iov_len += pad; > +} > + > /** > * tcp_vu_send_flag() - Send segment with flags to vhost-user (no payload) > * @c: Execution context > @@ -138,6 +161,8 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags) > tcp_fill_headers(c, conn, NULL, eh, ip4h, ip6h, th, &payload, > NULL, seq, !*c->pcap); > > + tcp_vu_pad(&flags_elem[0].in_sg[0], 1); > + > if (*c->pcap) { > pcap_iov(&flags_elem[0].in_sg[0], 1, > sizeof(struct virtio_net_hdr_mrg_rxbuf)); > @@ -456,6 +481,8 @@ int tcp_vu_data_from_sock(const struct ctx *c, struct tcp_tap_conn *conn) > > tcp_vu_prepare(c, conn, iov, buf_cnt, &check, !*c->pcap, push); > > + tcp_vu_pad(iov, buf_cnt); > + > if (*c->pcap) { > pcap_iov(iov, buf_cnt, > sizeof(struct virtio_net_hdr_mrg_rxbuf)); > diff --git a/udp_vu.c b/udp_vu.c > index 099677f..1b60860 100644 > --- a/udp_vu.c > +++ b/udp_vu.c > @@ -72,8 +72,8 @@ static int udp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, int s, > { > const struct vu_dev *vdev = c->vdev; > int iov_cnt, idx, iov_used; > + size_t off, hdrlen, l2len; > struct msghdr msg = { 0 }; > - size_t off, hdrlen; > > ASSERT(!c->no_udp); > > @@ -116,6 +116,15 @@ static int udp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, int s, > iov_vu[idx].iov_len = off; > iov_used = idx + !!off; > > + /* pad 802.3 frame to 60 bytes if needed */ > + l2len = *dlen + hdrlen - sizeof(struct virtio_net_hdr_mrg_rxbuf); > + if (l2len < ETH_ZLEN) { > + size_t pad = ETH_ZLEN - l2len; > + > + iov_vu[idx].iov_len += pad; > + memset(&iov_vu[idx].iov_base + off, 0, pad); It should be: memset((char *)iov_vu[idx].iov_base + off, 0, pad); Perhaps clearer to write (off is not obvious, we need to check above): memset((char *)iov_vu[idx].iov_base + iov_vu[idx].iov_len, 0, pad); iov_vu[idx].iov_len += pad; > + } > + > vu_set_vnethdr(vdev, iov_vu[0].iov_base, iov_used); > > /* release unused buffers */ Thanks,Laurent