public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Christian Korneck <christian@korneck.de>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] pasta: Add --no-pidns to keep spawned command in caller's PID namespace
Date: Thu, 17 Sep 2026 18:25:21 +0200	[thread overview]
Message-ID: <CA+5nQ15Zm0DmwgRNg12mWvzA66--svrwn1NtE7CLGkfjtp7vBw@mail.gmail.com> (raw)
In-Reply-To: <20260916105050.5e4bb12d@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

On Wed, Sep 16, 2026 at 10:50 AM Stefano Brivio <sbrivio@redhat.com> wrote:

>
> Applied, thanks for the patch, and welcome to the git log!
>

Apologies for my late response. I really appreciate both the good comments
and the merge.

On Tue, Sep 8, 2026 at 8:03 AM David Gibson <david@gibson.dropbear.id.au>
wrote:

> Note that it
> is always possible to create a namespace using unshare(1) with
> arbitrary options and then connect it with pasta, rather than having
> pasta create its own.
>

Just a brief comment on my motivation here. I like to use pasta's spawn
mode in
"low effort" things like shell scripts.

Creating a namespace and connecting it to pasta requires (imho) more effort
as
it inverts the process model. A wrapper that simply
execs the command inside the namespaces can't start pasta afterwards:
Something outside has to fork, wait for the namespaces to exist, start
pasta against the PID, then signal the command that networking is up,
and stay around to tie pasta's lifetime to the command's. Spawn mode
already does all of that in the right order with one process and no
handshake to get wrong. --no-pidns keeps that and only drops the one
namespace that can't work inside a container.

Again, thank you so much for accepting the patch.

--
Chris

[-- Attachment #2: Type: text/html, Size: 2410 bytes --]

      reply	other threads:[~2026-09-17 16:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06 13:17 Christian Korneck
2026-09-08  6:03 ` David Gibson
2026-09-08  9:45   ` Stefano Brivio
2026-09-08 11:09     ` David Gibson
2026-09-08 15:32       ` Stefano Brivio
2026-09-09  6:00         ` David Gibson
2026-09-09 21:02           ` Stefano Brivio
2026-09-08  9:45 ` Stefano Brivio
2026-09-16  8:50 ` Stefano Brivio
2026-09-17 16:25   ` Christian Korneck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+5nQ15Zm0DmwgRNg12mWvzA66--svrwn1NtE7CLGkfjtp7vBw@mail.gmail.com \
    --to=christian@korneck.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).