From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from mail-yx2-x04.google.com (mail-yx2-x04.google.com [IPv6:2607:f8b0:4864:41::4]) by passt.top (Postfix) with ESMTPS id E93205A0269 for ; Sat, 21 Nov 2026 12:00:50 +0100 (CET) Received: by mail-yx2-x04.google.com with SMTP id 956f58d0204a3-67dc3b0f2cdso561501d50.0 for ; Sat, 21 Nov 2026 03:00:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1795258850; cv=none; d=google.com; s=arc-20260327; b=bBsQ6D6FvTlIVt3ktt5SL08DRNgDstcQNCyxtUAMThBaInUrmtK1UgMASMVcXogOHo AAwDl1k1FpmwLpt+oT9AQiiU0NyRzvg9qoIO7m7zl8BgCG4h1n8ykAl2cJABwLIykIHu xhKytex4dS3Rh0SD790lN9mmZEhgJ5hK/+yn/bWKAJkV5tZ/2DNDVEonah/TD/wDdC9F b/i6TvIsoHWl9DHIgWsmp3pNy/YbuuicQo3MOJHQqCb4VojhcRa9NaeuVEIbBbmtnBdk /Zipv64eN7Natv4E8KXJ4ECw6ea1ot4Rx7HC5qer0enJybR2ZtWJ0gGfXnnGOM0BKJKa l1qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Hr77FS4te53xW87DHSv4NoSOqFIrThbYGMDuNNpYyeY=; fh=raaI9l2/4dNTyL9OY2Eu4NSA8yooS3X6hDeB8ZxdkY0=; b=hIWstSiULFVMPVK9shKPR1ys1hhRtcsLItPOhSyhPZUYMx/nmib4eMb+7zQm/3ubUH SRJ9Pc7T7h5/d5/01VUVW0LaDLlNQwXD055oVNxoqJvsZ3QeORab82PKY9IKcG1KEZyl g4ikyykyORhCuoXmYQ8Mpz8C68XlN4FYCntAc2TnpfoaBbpkvNWUrO5Bgk+O+Gqq55km 8XdRETJ82anaFFZ9tJ8GJr+lFqXeYELFG79mv0qKgn7wktvhPR9mF57vSH/E7BxkNITz BPC1sYjc1wejcCqWK3qAu1dmrxEOnnIaH5F35NIhPsCgYvpYqQdB5KeUQ3lWRDguupyu CbUQ==; darn=passt.top ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795258850; x=1795863650; darn=passt.top; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Hr77FS4te53xW87DHSv4NoSOqFIrThbYGMDuNNpYyeY=; b=RghgyLW9AkRRDniOJuhvETNQYpt0eIN6GBOsE/xHp1wqo6jV+E5l/qTu4YjIBL2ZhF fgx9XbPbhPWIuK2qVybM8AXqoQNz+mlUt/Zk8WguvOPQAcG/N/XPPFjHuZzHwmUvN1kr 5p7QM2JJQq/xtDPPB6foL+XF2Kpwp1AaAI4GbAnLPoKu+DF7VFEHpAXN96V7fFCoNJO2 zXWcR78ilQhwdqEKSlVuzkgojSNjsXIn0q6b2bt/Ww8K754zZ22c+Oq2WRu2dwG3mIIe LlQGqX3hcndCAjanG+EhhHqyHHAUue6tRti9kF5B5AgsKXHmy/t2BJBeOKreutOqupiU Lf/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795258850; x=1795863650; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hr77FS4te53xW87DHSv4NoSOqFIrThbYGMDuNNpYyeY=; b=NNBzf5ZMCWIqxHH6aV1x9fbfxDkZ+knCQztMkLrGaqgK8Iy1wmW5bdEBezo+aiUoRj o40QsMlz1CQw6QVABoebx+1KCPDkwmKD4SCu2tDmtaobPczJ96jQdv6NeLS8ZBibXhCC Rbu5jL0eugSKtOht5/+1zuK9fRrnasRUkiIy6R75QruypKFFOThsJvbHmJjEvzg1jVZU jXx5UCYLdUdg49RtWLAiQ4FJELn4m9gZ13co8scFRpD8DCr1yN99JBrm0TcfTtyicrPe Pvm/DTcTI/FFyPWTdwQ3uDqrCUEGEMXRp0+YdEpcB+O+JPY7OhxkJ866xiZ65EDiCIST rWNQ== X-Forwarded-Encrypted: i=1; AL+hErHD+miePVbTJQtvTzS3DPI0IEgu20hmS1ZM8PwRyq+Ihn1KhX24FVqL0hZDFZhkRRIjS5Ng6x+oTD4=@passt.top X-Gm-Message-State: APuU4Z+IYy1GALxskfKFj7Np7U3xund5FgK2N+Evi9n5FCD+12F8muUx 7YN5gi5WGIZlDjDs5h4lu23x0SgZi9+OLNPIprK/G0WNgragu1NoKO9VETbd+sKme6bDr7CBci5 D4fGAQ0X9MV7UOJGX+LQ+NqDtvCuMV4uegpvL X-Gm-Gg: AZFdTZfougnyCFE43eKuk3MSqHQlqcbybd5Y3Kx4jZQekvtRaGqcIHOD4dVd0cHVM9d 3wqDOjC7gSZpgSdFbGHEb/oANL3YZdPwdJ2r3yL4UX62ESRlTWLncg67VyjjjBqvCbDYdj0Dv6u QceEo3yIwdw1M54FWNMmG+wMIncOo7R5t8c7ymiMgIhhjeSPkCGewtJfGIo/3uXfajTb7VoqsOA i4nnwrmz120BV30+WExX8WjkTbYcsCkK3ZJhFypFzLfPHhUmHzdQX3mUEQqW+CKS0kprSA7ZZBo BqbFvU61Nde0Ozh1xpg4aLUc4l7/reVJQYBTe5sDQaqRG9s/nLMlysqRieelmYgd3hDsTiCNyaX lM1yLdg4thl8eMfyJ7fFlb8fUV0mZgFh6uCwDdycvyKvmVwQI603dqkLw9vcSo+RGuS5UuJpkfQ 0fHhXZ1HfxacKQOpC/ X-Received: by 2002:a05:690e:d5b:b0:67d:a31c:4fb with SMTP id 956f58d0204a3-67df44234e4mr1846465d50.18.1795258849615; Sat, 21 Nov 2026 03:00:49 -0800 (PST) MIME-Version: 1.0 References: <20261120173756.2000624-1-anskuma@redhat.com> <20261120211833.656426f0@elisabeth> In-Reply-To: From: Ada Urbaniec Date: Sat, 21 Nov 2026 12:00:38 +0100 X-Gm-Features: Aa3M54p5L_Vpe_243-6sIyqzxtKYBhQ95oF8CC1NSEnODUdaTmZcwBVTJfaIkPM Message-ID: Subject: Fwd: [PATCH v3] tcp: Limit fast retransmit to one per loss event To: Anshu Kumari , passt-dev@passt.top Content-Type: multipart/alternative; boundary="00000000000002e27d0660c74656" X-MailFrom: ada.urbaniec@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: Q6PKPDVMOC22TIS4DWJVY33W4CYZFXVN X-Message-ID-Hash: Q6PKPDVMOC22TIS4DWJVY33W4CYZFXVN X-Mailman-Approved-At: Sat, 21 Nov 2026 13:16:37 +0100 X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --00000000000002e27d0660c74656 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefano, Anshu, Thanks! Yes, I would be happy to have a Reported-by tag. Happy to help! I tested v3 as sent on my laptop, using source revision 6aa4f88 and Linux 7.0.0-43. I used an extended version of the reproducer I uploaded to bug 224 (attachment 73), with added periodic ACKs, delayed ACKs, zero-window cases and retry timing measurements. With both directions open, dropping the first data segment stops causing a retransmission storm. If the segment remains missing, v3 retries after about two seconds. With a half-closed connection (the client sends FIN, then waits for the response), v3 also stops the storm. Two cases still fail when the client sends the same ACK every 10 ms: * If the missing segment is never accepted, there is no further retry during the four-second test. * If the client starts accepting that segment after 100 ms, there is still no retry, and the transfer does not complete within four seconds. Without those repeated ACKs, the half-close recovery case completes after about two seconds. V3 stops the storm, but repeated ACKs can still prevent a half-closed connection from retrying. The earlier patch with the timer fix does retry under the same conditions. On Fri, Nov 20, 2026 at 9:18=E2=80=AFPM Stefano Brivio = wrote: > On Fri, 20 Nov 2026 23:07:56 +0530 > Anshu Kumari wrote: > > > Every duplicate ACK unconditionally triggered a fast retransmit, > > even when the ACK sequence hadn't advanced. > > > > Guard fast retransmit on !conn->retries, and increment retries > > after the first retransmit. This is a quick fix to stop the > > amplification storm. Full compliance with RFC 5681 Section 3.2 > > (three duplicate ACKs) is left to a later patch. > > Ada, would you have a chance to try this patch out? Would you like to > be credited with a Reported-by: tag? > > -- > Stefano > > --00000000000002e27d0660c74656 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefano, Anshu,

Thanks! Yes, I would be= happy to have a Reported-by tag. Happy to help!

I tested v3 as sent= on my laptop, using source revision 6aa4f88 and Linux 7.0.0-43. I used an = extended version of the reproducer I uploaded to bug 224 (attachment 73), w= ith added periodic ACKs, delayed ACKs, zero-window cases and retry timing m= easurements.

With both directions open, dropping the first data segm= ent stops causing a retransmission storm. If the segment remains missing, v= 3 retries after about two seconds.

With a half-closed connection (th= e client sends FIN, then waits for the response), v3 also stops the storm. = Two cases still fail when the client sends the same ACK every 10 ms:
* If the missing segment is never accepted, there is no further retry duri= ng the four-second test.
* If the client starts accepting that segment a= fter 100 ms, there is still no retry, and the transfer does not complete wi= thin four seconds.

Without those repeated ACKs, the half-close recov= ery case completes after about two seconds.

V3 stops the storm, but = repeated ACKs can still prevent a half-closed connection from retrying. The= earlier patch with the timer fix does retry under the same conditions.
On F= ri, Nov 20, 2026 at 9:18=E2=80=AFPM Stefano Brivio <sbrivio@redhat.com> wrote:
On Fri, 20 Nov 2026 2= 3:07:56 +0530
Anshu Kumari <an= skuma@redhat.com> wrote:

> Every duplicate ACK unconditionally triggered a fast retransmit,
> even when the ACK sequence hadn't advanced.
>
> Guard fast retransmit on !conn->retries, and increment retries
> after the first retransmit. This is a quick fix to stop the
> amplification storm. Full compliance with RFC 5681 Section 3.2
> (three duplicate ACKs) is left to a later patch.

Ada, would you have a chance to try this patch out?=C2=A0 Would you like to=
be credited with a Reported-by: tag?

--
Stefano

--00000000000002e27d0660c74656--