public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Peter Foley <pefoley@google.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Avoid clang warnings in fwd.h
Date: Wed, 4 Mar 2026 14:14:32 -0500	[thread overview]
Message-ID: <CAAAKUPMsvfTCaURfkPOiur8dut7mv5DOWpLAyP=h=okq_ktrZw@mail.gmail.com> (raw)
In-Reply-To: <20260303201143.1d3aac40@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

On Tue, Mar 3, 2026 at 2:11 PM Stefano Brivio <sbrivio@redhat.com> wrote:

>
> Peter, unless you see a problem with that, this patch would be
> superseded by:
>
>   [PATCH 2/3] fwd, pif: Replace with pif_sock_l4() with pif_listen()
>
> https://archives.passt.top/passt-dev/20260302043135.800803-3-david@gibson.dropbear.id.au/
>
> as it avoids the need for this static_assert() altogether. So I would
> drop this patch (carrying a Reported-by: tag) in favour of that one.
>

Sounds good, I'm mostly concerned with having a warning-free clang build.
The specific fix doesn't particularly matter.

Thanks,

Peter

[-- Attachment #2: Type: text/html, Size: 1147 bytes --]

      reply	other threads:[~2026-03-04 19:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 17:29 Peter Foley
2026-02-24  5:48 ` David Gibson
2026-02-24  8:50   ` Stefano Brivio
2026-03-02  4:34     ` David Gibson
2026-03-03 19:11 ` Stefano Brivio
2026-03-04 19:14   ` Peter Foley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAAKUPMsvfTCaURfkPOiur8dut7mv5DOWpLAyP=h=okq_ktrZw@mail.gmail.com' \
    --to=pefoley@google.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).