From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=U7KNcA2g; dkim-atps=neutral Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by passt.top (Postfix) with ESMTPS id B399B5A0262 for ; Wed, 04 Mar 2026 20:14:45 +0100 (CET) Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-463b3697846so6181840b6e.0 for ; Wed, 04 Mar 2026 11:14:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772651684; cv=none; d=google.com; s=arc-20240605; b=AGDyFbE/v4kotypL3ih8zVE39qu2sLFP24bpMF5U9uZV81c2djJsbta9BhPM+MCiQT plviuulyeTkCXhLDWUkhjb+VdUc4ylps+uaTLffwYIVn2frrLln0NddGWzF6pcyhBh+3 fCYxZg1lgf+EBpZ4iqd4QM/ErPGRUnbB0rf2G3Ft7G81pNy20/oEvcogMr4x9k9RGhhV P5NrhHaDC88tCg77F75QeCSoTwBEwY6918oNQgkMxiRhxebPWx8YB1+f0BX8mAZ6vvMz Bt7BLVjz7Wm+2KxH4Je2c12AOAkNeTdDmVqAjQkOCuS4j5snG10GGYbYZITx+AM03gMb 37Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=fOx+uTTYRss7QV0Lpzu+jZngmAN/YXuucjq2UMajNsM=; fh=htis3z6nDPD3FFPmKX7SGQyhLv1B9tDlnJYWrC8d10o=; b=gBw0q3xBgEel7g7y2zVOYJqQC/WfxPpZudKmfPQUgBr94p1EtKnaZ4sHn8MwJWF7ic P/A3rjgs17Ncpc53S7Grmj6luzsq9HSBjuAEMHMAE8prcHvs9azuzIV7GGvzJG3bPjpt Rd49NpyndiKysbW+Szrd/WK7xvRsM/AsCUndic/yRc5so03L4HchyD6/qhUQnoDhw31A kpEWLyeaSRHMWxA4XIm3w96uBlwkYlF1RZZNnKkU/uNIvXiURcr8e2xaYO9jKohxCOO0 GIigEVw4eRsrxb6OcW+5IvHew6XOxVwICx0n4NUcOofSvHSXFVWrAcPw6vpzJWv4HJQz rM1A==; darn=passt.top ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772651684; x=1773256484; darn=passt.top; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fOx+uTTYRss7QV0Lpzu+jZngmAN/YXuucjq2UMajNsM=; b=U7KNcA2gjEXoIqxjf3vv/7NsHFV8DbMvDufAeWwLvSLrbnGm7bSf6Uzm7USmemfJ6U RGqmZQrmSs5v/JckpfY5qmka/yi3+Nm+4l6tqaartnlWdwbXi5APTcZr8v+28JbhEhXh IUXmWwy1obwkXHW0vDH6lUn0WAniI6YwzY2Rxth7hqQ7rHMPAkazQXfDgPtrTHUpuyyc 0o2XLTjBMna9yYcT5URsq7K15eX+t14wHQktDB372aIQMmIxrwjWrAvXotz893++eXwP OPy2ewRbtMu7tS21ae6Ho+s5WwGOrt8fmcrn9RbeGekpYZAPgVMK3BWWDStOx5RxEKUg vl+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772651684; x=1773256484; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fOx+uTTYRss7QV0Lpzu+jZngmAN/YXuucjq2UMajNsM=; b=mRRyNkJiz83rK1nxshF+QxxlK1aIU22BiMmbexC22gyhz1Q47gT8JOW7OLhtCT8eW6 sDrX5vaHh732orrrXY71xzkN0kQcqNpLTn74kvwII6FeiidabjzSljqe4UZzRlf0hcbn oZRB+KI111pnHc6TMWw3xv6wj++PfhQV20zoQUcZr6pQojhR0jW5KHDA/H/101ukG4jl JdC6TU/azm2VK8+EVkCS+NZo36tqZl4oLQvYlCVsUG0UnoBup8ft6uslaLYtOFhrsaIr K8CclOrax1KrIMySxd9yGEFDaJdd46SMAbi4vU0zmYorckWzj3NyGROenla5ra/U4/sX +5pQ== X-Gm-Message-State: AOJu0YyfAkbuP6BU8nqEcjXbHfd82bPHdo7zjOYnR/ruy0Wh08GrkbeK MYM8/X80GJLEUCN7IVZuuwxQ5rlkbbRePYvAh40SY/A3g6UT1gba6JZkG5Zo4Y0hlax9mPqZVs7 HUymy3DAvXtpbIDFOmAntgcen04mz4tMjW47k45nA X-Gm-Gg: ATEYQzzLXcKAwnwDKm5TJ6Ff2orvL54vB8jBMNs+v0nPe6GV9zLIZ6F4+B7Om2QT5H7 HS+SM5yZsn7Sfmsy2dxDhGHHvwMwhnWPzkv2adtSIBHEyDY+IFwbkfTIX3emL1IkKyYdw+w/iHu aufJ7+Gt4bitMYYVUvSZll2nsrpIuF4bjE3DXTc5VMG1fumyaYJJgCykAa1nQh8zHxF2oCo65dk cXcCcil4XN9FC2s9Ibbhlpa83uba0wOXMeFH5HDL9xlSIAX6EQMtG5azpY9anVSLGPvg8OYMWTU 7ZN4/v25k2iOrX9IudtuWi21LtdGQFZHae9BZw== X-Received: by 2002:a05:6808:1990:b0:45f:103c:2483 with SMTP id 5614622812f47-4651aede1f5mr1321869b6e.23.1772651683813; Wed, 04 Mar 2026 11:14:43 -0800 (PST) MIME-Version: 1.0 References: <20260223172920.146057-1-pefoley@google.com> <20260303201143.1d3aac40@elisabeth> In-Reply-To: <20260303201143.1d3aac40@elisabeth> From: Peter Foley Date: Wed, 4 Mar 2026 14:14:32 -0500 X-Gm-Features: AaiRm53uj8WL2iQG9qU8g2kDHGx33zSpnqbqVYIcYD7N7GWVQIB0j2_I8GkxBmU Message-ID: Subject: Re: [PATCH] Avoid clang warnings in fwd.h To: Stefano Brivio Content-Type: multipart/alternative; boundary="000000000000ede3b6064c37a1ca" X-MailFrom: pefoley@google.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: D6AQHAT47BOMRHYB4TRVPH6CHOLW3IA7 X-Message-ID-Hash: D6AQHAT47BOMRHYB4TRVPH6CHOLW3IA7 X-Mailman-Approved-At: Wed, 04 Mar 2026 20:24:57 +0100 CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --000000000000ede3b6064c37a1ca Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2026 at 2:11=E2=80=AFPM Stefano Brivio = wrote: > > Peter, unless you see a problem with that, this patch would be > superseded by: > > [PATCH 2/3] fwd, pif: Replace with pif_sock_l4() with pif_listen() > > https://archives.passt.top/passt-dev/20260302043135.800803-3-david@gibson= .dropbear.id.au/ > > as it avoids the need for this static_assert() altogether. So I would > drop this patch (carrying a Reported-by: tag) in favour of that one. > Sounds good, I'm mostly concerned with having a warning-free clang build. The specific fix doesn't particularly matter. Thanks, Peter --000000000000ede3b6064c37a1ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 3, 2026 at 2:11=E2=80=AFPM St= efano Brivio <sbrivio@redhat.com> wrote:

Peter, unless you see a problem with that, this patch would be
superseded by:

=C2=A0 [PATCH 2/3] fwd, pif: Replace with pif_sock_l4() with pif_listen() =C2=A0 http= s://archives.passt.top/passt-dev/20260302043135.800803-3-david@gibson.dropb= ear.id.au/

as it avoids the need for this static_assert() altogether. So I would
drop this patch (carrying a Reported-by: tag) in favour of that one.

Sounds good, I'm mostly concerned with ha= ving a=C2=A0warning-free clang build.=C2=A0
The specific fix does= n't particularly matter.

Thanks,
Peter
--000000000000ede3b6064c37a1ca--