From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B5C875A0082 for ; Wed, 22 Feb 2023 13:47:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677070055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=//r2wkgEeqqfPjiITrN8njjXOfW7sJ0iLjrNSJzgCwc=; b=QLVt1GcCtB6kfN8ofy7OA4EZ0iz56pDhYBxh31izmGKNqk8Suvdw6nM/K5bfWTzYqudCb2 F92Uz0LEOBvSBcMUX88FLRFcWtCb6JM5tstpbBVQN2uQnI9O5cqnByML4Byb7DIPt1Rb5f tmvsmt2hE7EKeTy2Uq+OUTx5C/ppevU= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-462-LIopq8FGPO6P3o6crgR-OA-1; Wed, 22 Feb 2023 07:47:34 -0500 X-MC-Unique: LIopq8FGPO6P3o6crgR-OA-1 Received: by mail-pf1-f200.google.com with SMTP id d8-20020a62f808000000b005d8047f3bc0so417719pfh.6 for ; Wed, 22 Feb 2023 04:47:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:in-reply-to:mime-version:references :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=//r2wkgEeqqfPjiITrN8njjXOfW7sJ0iLjrNSJzgCwc=; b=pRlSTyWAlWMPeVeemWuwynWN3kOwU8QkcWh4U9J8lxdp+JT/BOVQPrQza+5yE6ESSc kW6Lc+q/LwEI9tnfS4UvToepiRAFjBpHV+hBWP9TxKv4yZcF/ysIQNkTmG2PtbECjV7v uWqPHc7iAeFJABDmfgRe7sXoS6p/2rbhkhXHmZRHJlXL/sQ9ez1gr8hJgIWpX52UUAfH kLeX2FyVKwwl116S32Gn5MpeIgcH5uSePI8gurzCtMilZ3vVnm05GFBAR3VsTyxrU0Dw IxbxGR261W7Nw6rP52rYbKsPCF8DNA96fRBI5GF48I3/Hhbtw7rIGxBkudPvP5WJDn1C fhpg== X-Gm-Message-State: AO0yUKXpbtNlTrabONYZNirVxhZTROOIBoMgXBEb4x//fbIcG1x6QbEH o1TDrHzQWFf6r2YeipORgWOQ1tZ3eu5GZX1P+wKDcK/b8G7WUfer+xBjplrs1V4AP59+tNNW69A bAd8tWpFcnHekHtI5TlSYyIFPu7kY X-Received: by 2002:a17:903:124e:b0:19a:5a38:5d8b with SMTP id u14-20020a170903124e00b0019a5a385d8bmr1363373plh.11.1677070053283; Wed, 22 Feb 2023 04:47:33 -0800 (PST) X-Google-Smtp-Source: AK7set+twADGAhoHDczgvtiwJv799x902PsOTjjACHsfdLx4uwDsFcKZsYpS0hfjhoeh6XPsbsOoDP1MyhOe2UR8Tiw= X-Received: by 2002:a17:903:124e:b0:19a:5a38:5d8b with SMTP id u14-20020a170903124e00b0019a5a385d8bmr1363368plh.11.1677070052883; Wed, 22 Feb 2023 04:47:32 -0800 (PST) Received: from 744723338238 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Feb 2023 04:47:32 -0800 From: Andrea Bolognani References: <20230221192425.3745394-1-sbrivio@redhat.com> <20230222114508.10c0fd74@elisabeth> MIME-Version: 1.0 In-Reply-To: <20230222114508.10c0fd74@elisabeth> Date: Wed, 22 Feb 2023 04:47:32 -0800 Message-ID: Subject: Re: [PATCH] qrap: Pass PCI device numbers to qemu in base 10, not in base 16 To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: SVD4SFHQ7Q6YQME26JAXXI4ES2JPM2QL X-Message-ID-Hash: SVD4SFHQ7Q6YQME26JAXXI4ES2JPM2QL X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Alona Paz X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Feb 22, 2023 at 11:45:08AM +0100, Stefano Brivio wrote: > On Wed, 22 Feb 2023 02:40:32 -0800 Andrea Bolognani wrote: > > What I think needs to happen, is that each pci_dev should contain a > > base value (16 for i440fx and 10 for q35), which is used both in the > > strtol() call used to parse the command line produced by libvirt and > > to decide whether %x or %i should be used with snprintf() to generate > > qrap's own arguments. > > Right, I think it makes sense. Will you prepare a patch in this sense > or should I try? Sure, I can give it a shot. It might take a bit, because the code is kinda tricky and there is no test suite (that I'm aware of?) for this part. -- Andrea Bolognani / Red Hat / Virtualization