From: Hector Cao <hector.cao@canonical.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] apparmor: Add attach_disconnected flag to passt profile
Date: Mon, 16 Nov 2026 16:11:34 +0100 [thread overview]
Message-ID: <CABjvBV5GJF02zAP0=bWxrhGUsz-6a27JiNOc222YiF-T96ZCmA@mail.gmail.com> (raw)
In-Reply-To: <20261114134727.76eb9245@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 3724 bytes --]
Hello Stefano,
Thanks for the info and the pointers. I missed that this was already
addressed upstream, so I'll definitely look into backporting it into Ubuntu.
If you have any topic you want to address for Ubuntu, feel free to let me
know (either via Matrix or direct email). I am maintaining qemu/libvirt for
Ubuntu and passt might be a part of my work.
Best,
Hector
On Sat, Nov 14, 2026 at 1:47 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> Hi Hector,
>
> On Fri, 13 Nov 2026 13:07:52 +0100
> Hector Cao <hector.cao@canonical.com> wrote:
>
> > In isolate_prefork(), passt detaches from the host filesystem: it
> > pivot_root()s into an empty tmpfs and lazily unmounts the old root.
> > Paths to objects opened before this point, such as the listening UNIX
> > domain socket for the hypervisor, can't be resolved from the new
> > root any longer, and AppArmor sees them as disconnected paths.
> >
> > The visible effect is that accept4() on the hypervisor socket fails
> > with EACCES once passt is sandboxed, so the guest can't connect,
> > and have networking functional.
> >
> > Set flags=(attach_disconnected), so that disconnected paths are
> > attached to the root of the namespace and mediated against the
> > existing rules, as other sandboxing profiles (e.g. libvirt's) do.
> >
> > Signed-off-by: Hector Cao <hector.cao@canonical.com>
> > ---
> > contrib/apparmor/usr.bin.passt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/apparmor/usr.bin.passt
> b/contrib/apparmor/usr.bin.passt
> > index da49e37..ccc2ea9 100644
> > --- a/contrib/apparmor/usr.bin.passt
> > +++ b/contrib/apparmor/usr.bin.passt
> > @@ -15,7 +15,7 @@ abi <abi/4.0>,
> >
> > include <tunables/global>
> >
> > -profile passt /usr/bin/passt{,.avx2} {
> > +profile passt /usr/bin/passt{,.avx2} flags=(attach_disconnected) {
>
> Thanks for the report and for the patch. Note that I already added
> this flag more than a month ago in commit 032f082ffad0 ("apparmor:
> Fixes for new user namespace detaching procedure"):
>
>
> https://passt.top/passt/commit/?id=032f082ffad094649066fa94822c5a78a246a766
>
> and I see you now created trees on Ubuntu's Launchpad so I guess you
> can backport this from the debian/sid tracking branch instead? See:
>
>
> https://git.launchpad.net/ubuntu/+source/passt/commit/contrib/apparmor/usr.bin.passt?h=debian/sid&id=e05c3ae80ca0ae6a7b227ff074893fa74a59961b
>
> By the way, I added that flag as part of the fix for:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1149683
>
> and in general we tend to fix Debian bugs quite promptly:
>
> https://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=both;src=passt
>
> but it looks a bit more complicated to get them fixed in Ubuntu:
>
> https://bugs.launchpad.net/ubuntu/+source/passt
>
> and I have to say that I was trying to figure out how to make things
> smoother a few years ago, but then I couldn't register a Launchpad
> account (because my email address was already in the database as
> Debian maintainer) and I gave up. Eventually I got the Launchpad
> account with some effort but then I didn't have the change to look
> into it anymore.
>
> But now that I looked into your patch I saw:
>
>
> https://git.launchpad.net/~hectorcao/ubuntu/+source/passt/commit/?id=66f3b374796304982db143624bf83e9d6fcec267
>
> so I take that as a good sign. :)
>
> --
> Stefano
>
>
--
Hector CAO
Software Engineer – Server Team / Virtualization
hector.cao@canonical.com
https://launc <https://launchpad.net/~hectorcao>hpad.net/~hectorcao
<https://launchpad.net/~hectorcao>
<https://launchpad.net/~hectorcao>
[-- Attachment #2: Type: text/html, Size: 6023 bytes --]
prev parent reply other threads:[~2026-11-16 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 12:07 Hector Cao
2026-11-14 12:47 ` Stefano Brivio
2026-11-16 15:11 ` Hector Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABjvBV5GJF02zAP0=bWxrhGUsz-6a27JiNOc222YiF-T96ZCmA@mail.gmail.com' \
--to=hector.cao@canonical.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).