From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Snbg+ls8; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id ED1665A0271 for ; Fri, 10 Jan 2025 10:44:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736502278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kl3t+Et0CICRmiJk22tgh+joJlaYhiv/c1fAN+HAt6Y=; b=Snbg+ls8RX6X4mSxeu0aSo/C5WABNsUPxs3SRn2C9C9If+4oJzqTxq82J6QC9kfgAtW5zg nJgQqEBtoWIr4ouLAtz4ZDz3T3Y+tAE7iQbKlY3RVent38QkWlTsF09ZGWlzIomb0hS4Lw LYO6E1ki9Uq2yEKF+5UONXikenp8/3U= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-wiW_rd1-OduiPz9D9ZPCRA-1; Fri, 10 Jan 2025 04:44:37 -0500 X-MC-Unique: wiW_rd1-OduiPz9D9ZPCRA-1 X-Mimecast-MFC-AGG-ID: wiW_rd1-OduiPz9D9ZPCRA Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aa6732a1af5so177352666b.3 for ; Fri, 10 Jan 2025 01:44:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736502275; x=1737107075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kl3t+Et0CICRmiJk22tgh+joJlaYhiv/c1fAN+HAt6Y=; b=OFWhoXPpFHfQ4dBg+PzQwfyHBJYvhH1gU19TTld8JjsY5ZKa/18ef3Kwz9UYDBJ/Uq PG+/vgMkr4BbjRRx2Qn5mzNQKAYRMEQv2WdkVa5kSVpHEBQl3KT2fBuXvSz2fmbiDFcG vlls4u9U4bViydRV403ov7vqctROK+M9zL033VBVGsoFlRslcOES0MgSAWsuYOnxh0dO PqU3DBHVrh1NqvOclvU65t68f8mC9cyeB0F7VUivNO3UVpdkvJPBgjxBxvVkl+sRToEx ynW9jCu7+bmmAz2+WnpA5QxQSlhsnAShwHunX9+AgwxZCqm8znIws16W9Uh1AUVR7vJT HDlw== X-Gm-Message-State: AOJu0YycBD2KboV7reB21Cj26S2kjsYz3+2gQnra2WfWptfT1YxXxXiW ZshDV2r48VpyR1nzjjCqwpDSEeGGbMnVbQco2VSERi/eyWXLxaynncSPusoAtvUgPYzLj7IoJwq JGK1ltmdWos49Q0OTDnMMKoxQlVE/ivX1CfDsyd7kW4G75lPQjpUOFm6Ji1wlW8WNosEtdVmRjW IeVxusckYAivEQs9nA6SNjS2HlQUKsW8U6DZCu/A== X-Gm-Gg: ASbGnctvoNZbyyo+JxFGwgxwpwd89FD2eNxT6EIBzo6otOQM/D/DfGOucJOuxR/IfCV eccxnbQ2sZXjxaboRhCwPbH+MvnNGSed/1/jutfiBxj6rrhRPB8Mn7855nIGU3FBkNjtth6Vu X-Received: by 2002:a17:907:2d2c:b0:aaf:8720:d192 with SMTP id a640c23a62f3a-ab2ab6fe02cmr801393166b.21.1736502275509; Fri, 10 Jan 2025 01:44:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhQHEzVldSIEPontXD15pdPnQITAG7V/PXaUvYxwmNbqtY6/0b5xrtim5mvwo3/Sv3NHwNxOJxX10XPRIQkz0= X-Received: by 2002:a17:907:2d2c:b0:aaf:8720:d192 with SMTP id a640c23a62f3a-ab2ab6fe02cmr801391966b.21.1736502275156; Fri, 10 Jan 2025 01:44:35 -0800 (PST) MIME-Version: 1.0 References: <20250108145811.833308-1-ellorent@redhat.com> <20250109091631.03fefb0e@elisabeth> <20250109143358.334ef58a@elisabeth> <20250110095955.11024478@elisabeth> In-Reply-To: <20250110095955.11024478@elisabeth> From: Enrique Llorente Pastora Date: Fri, 10 Jan 2025 10:44:24 +0100 X-Gm-Features: AbW1kvakVSe_nc8xVBepa2nvsBr_exdDIFAot6L82geWctXVnVEatsXfkrANKUU Message-ID: Subject: Re: [PATCH v7] dhcp, dhcpv6: Add hostname and client fqdn ops To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lOAeIBXr_L_bbnd2qjZN9OG85JjTodOq12voLulmkaM_1736502276 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JFHRI2BXXL2Y3U4CWE73ARYKWA44ODXV X-Message-ID-Hash: JFHRI2BXXL2Y3U4CWE73ARYKWA44ODXV X-MailFrom: ellorent@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 10:00=E2=80=AFAM Stefano Brivio wrote: > > On Fri, 10 Jan 2025 09:39:09 +0100 > Enrique Llorente Pastora wrote: > > > On Thu, Jan 9, 2025 at 2:34=E2=80=AFPM Stefano Brivio wrote: > > > > > > On Thu, 9 Jan 2025 13:57:38 +0100 > > > Enrique Llorente Pastora wrote: > > > > > > > Also I have to move the list buffer or I will be storing it at the > > > > first element. > > > > encoded_name_len =3D encode_domain_name(srch->list + srch->hdr.l, > > > > NS_MAXDNAME, > > > > c->dns_search= [i].n, > > > > name_len); > > > > > > Oh, right. I didn't test this. Can't you just follow along where you > > > are with 'offset'? I'm not sure, I didn't look into it. > > > > I cannot use offset since it's initialize with + header > > > > offset +=3D sizeof(struct opt_hdr); > > Right, but doesn't that need to point to where we want to write anyway? > That will be after the header, so it's good that it's past the header. > Again, I didn't try this. > Ahh right we can use offset directly encode_domain_name(offset, c->dns_search[i].n); > -- > Stefano > --=20 Quique Llorente CNV networking Senior Software Engineer Red Hat EMEA ellorent@redhat.com @RedHat Red Hat Red Hat