From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Qx19zLRS; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 8E9CA5A0272 for ; Mon, 17 Feb 2025 10:24:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739784283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XjCmWY2TJCUvz/7LVuas4rBQl/fwgmAzWs6cbHXjfM=; b=Qx19zLRSIKVGCQRC9aSKEu/02liMsBcJ1R7nKfqo0WVjvm+l/QuIjcbHwRLoWNrqu3fd2W 2SrAsMbKD1H0uvIDITjxKNBt5EeN3r36hkLEY7GmbQMInnXlvokwsKMooCMEULPMxeeKs0 sKS32HIMLH9EGL3nmfBbbQYbTZTlHq0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-7CeUY2XVNW20z91f2q0OxA-1; Mon, 17 Feb 2025 04:24:41 -0500 X-MC-Unique: 7CeUY2XVNW20z91f2q0OxA-1 X-Mimecast-MFC-AGG-ID: 7CeUY2XVNW20z91f2q0OxA_1739784280 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-aba3a9da84fso570582166b.0 for ; Mon, 17 Feb 2025 01:24:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739784279; x=1740389079; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5XjCmWY2TJCUvz/7LVuas4rBQl/fwgmAzWs6cbHXjfM=; b=Qc4IVwXkVY0lqzt58QdI9hlyIHbj8fDBnA/xHOw3J3Wb9KYa6qwq2s50058CPoswVw DfZNQsZsXag9L8wSA3ZZ0fN5OSDt4fC3utHgM+yZ0aZrFRy74+qebjek/y1Eh2JeEmKN paikLLhbTWNY/xHdmXvS51PV0oyj8t97pZBgEtPjbohH+LiOi5PPGa+8QVROZvYVfVL5 59WH568fxHXDCCkCqoIlseI1RwiCe6rBbyxGeboSjQfkKgbaUGA2mgvgTSyw1JTcHzjD We+KAMQ3sKssqEpfNEycE9L0Yct1a60fSWUA+vc8+u3V6Nfo9SdWc/WflV2tcbcsj1DL pJpw== X-Forwarded-Encrypted: i=1; AJvYcCURwNkn5kjhHGx9aKWo1HymSD8SbAL5Gwwc+byclYwkXBlNDeOcSw1eFEHn7DZFShCpE1133cayDr4=@passt.top X-Gm-Message-State: AOJu0YyFGzk+afiV3jg6+fCodzVWgCi4CVopV5jj8dJMd6LX8CXc/lsV o/6QBsTMRMfdQVPx1PoLaZ7RaTU4/CBuF+fjRmPg2fMg/0hKVhsrCWyIFI5lKqxt1cNxh1XOuTa ZVol/eWvBO75vbrkRkd582iEeaDv9hmH/wntZ6wRDeTDtZmOejyUfpNn/G5meaepzGDYE/Z4zRu WTELx57kdDk6PQ/V7LQ3CEKfDMNz2KEbKcZDA= X-Gm-Gg: ASbGncslNSeTdjh/jFeOYyEcikKGmlqexn8fgptO9iVtdCUuFmGZTWrtVxjb7TqD4ZF UfY9rodk/ecCIjm3XLa83GB0V1n8Phe1LPEjhUzMMbrSdue6q49gF9HWWRUx3XTqsp2LoJhM5F2 MLcMIyE6uEWSvOzvuaYg7G X-Received: by 2002:a17:906:4116:b0:ab7:ea59:2120 with SMTP id a640c23a62f3a-abb70a7c980mr767017366b.10.1739784279625; Mon, 17 Feb 2025 01:24:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcwwrzs4fI5i5XqqZMwmUF7xacbJt6Wk/MIOBgBctua2BmvBmxkLWARoL60KLC1FdsIgCFxC9t1RCXrZHP0mE= X-Received: by 2002:a17:906:4116:b0:ab7:ea59:2120 with SMTP id a640c23a62f3a-abb70a7c980mr767015466b.10.1739784279213; Mon, 17 Feb 2025 01:24:39 -0800 (PST) MIME-Version: 1.0 References: <20250211111434.945152-1-ellorent@redhat.com> <20250212023845.51cec050@elisabeth> In-Reply-To: <20250212023845.51cec050@elisabeth> From: Enrique Llorente Pastora Date: Mon, 17 Feb 2025 10:24:27 +0100 X-Gm-Features: AWEUYZluM472d_U8kcXMRn2XUotf_AJKLl7l8mpU1IXtS8RAyY3IOoo06vGQtTw Message-ID: Subject: Re: [PATCH] dhcp: Remove option 255 length byte To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qhee0zQ0oAxWAzyszSuyYlCKB9Bj-rvlgyt3TukYU0Y_1739784280 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BTEZUE4SCWRS5CA6MY3C7ZSEKOH3S2XT X-Message-ID-Hash: BTEZUE4SCWRS5CA6MY3C7ZSEKOH3S2XT X-MailFrom: ellorent@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 2:38=E2=80=AFAM Stefano Brivio = wrote: > > On Wed, 12 Feb 2025 12:14:32 +1100 > David Gibson wrote: > > > On Tue, Feb 11, 2025 at 12:14:34PM +0100, Enrique Llorente wrote: > > > The option 255 (end of options) do not need the length byte, this cha= nge > > > remove that allowing to have one extra byte at other dynamic options. > > > > > > Signed-off-by: Enrique Llorente > > > > Thanks, change is good. However, could you also update the comment on > > OPT_MAX's definition that appears to have the same error in it. > > I was about to apply this by amending the comment, but... it's not just > the comment (hence it needs to be re-tested a bit): OPT_MAX should be > 307 now, otherwise you don't actually use the extra byte. > Good catch, changing. > -- > Stefano > --=20 Quique Llorente CNV networking Senior Software Engineer Red Hat EMEA ellorent@redhat.com @RedHat Red Hat Red Hat