From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WtzPpNz+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id C54565A0279 for ; Mon, 28 Jul 2025 18:45:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753721102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNmxAciOcTp1in+Cou9a7RQoDepIamOEOaVqDcqWq8o=; b=WtzPpNz+DW/zki6eTMV3dgovmKDcqhzatOraHkbulR6vWCCyIewGNInVc6KbMS8KpUeaXJ qlOvRXpWNka67SpI3VPC/BAoPstEKuRxzImbIqs21vyLsA9LaEYpBhpvmgsHscNj157mPf 0+HGk2zL5SnMUH6XYKedBSKgJF7rVrc= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-eoDygVwYOgaW52ljHnnJEg-1; Mon, 28 Jul 2025 12:45:01 -0400 X-MC-Unique: eoDygVwYOgaW52ljHnnJEg-1 X-Mimecast-MFC-AGG-ID: eoDygVwYOgaW52ljHnnJEg_1753721100 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b2c36d3f884so3422744a12.2 for ; Mon, 28 Jul 2025 09:45:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753721100; x=1754325900; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNmxAciOcTp1in+Cou9a7RQoDepIamOEOaVqDcqWq8o=; b=w0hVpc/a8I9b3E87ena2PoHgWId3D3YNvlAJxkmqsA5X1XWP4Sf2xYyV4CsvNvE77+ UDT8+NPHfkdzY07Li9cw7PNvws3g2ZETrwfGUbDhfVlSatDqyT8q3uhIPiNTfHudaPJK 65v2pEHh1oFy85uGZ/FeU0zlvkg+KMhKc0nmc+BNd7EspeqLtB76vvJKcv38QqFE3Pp2 Zk6etJEc+1tsuK0odGO6EzDMfujYlCBsqq0irZN0no5kV69BwIqm6vd9OgSI5tT1tVg5 BkdWgw4mNdBnXaqbvjK2DTWjGrCnRiW/x9tDkhpVCDJvaNqrgDrXLGa7rag38wHsCsP6 LeGA== X-Gm-Message-State: AOJu0Yze+gSuUBGMHQwUhBcq7rVmxkjksj421ZGvQ2smsc2dyE752vP9 naNDqCbeOsGW3EJIthQ2s/NGBt1C4eP/zyQ5WF+xCii1rWyxvX56oi5ntiSLYJHIIeX2/zTZAjV Zr6IAt97oKg7ml/E0Z06wxfx4wVqTACfbT2NJ12Al7ZgJoI/RFRUaZl8GyfT9yU2y5E2B6Qce5X WHBg15cqpitrS/hZHm/TUJAAVsaPlS X-Gm-Gg: ASbGncu6J1GutA3YCVoqBaoHlHeOVLZHvmydQLSTLDRlMbf/O1iXCY+vjaB0GQpy4Wz QRLyH2YPQb2xWY/0wzQAVVPgagrq0a12b+u6JCMNCFDCTFu20G/0v/ABfLSmkLNwp3ybuS+ZTQM HMw0tlWJfJCY3e3VCQqfie X-Received: by 2002:a17:90b:254c:b0:313:5d2f:54f8 with SMTP id 98e67ed59e1d1-31e77a1a3edmr19164026a91.33.1753721099976; Mon, 28 Jul 2025 09:44:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEO/jRzOmX8fLD7s+7cHPiJxBRMN1ag9uMdzxXPJlfjBAaYnaadajhAjiw1hHwGdODo4tadkpeW0RY6ORuJsXI= X-Received: by 2002:a17:90b:254c:b0:313:5d2f:54f8 with SMTP id 98e67ed59e1d1-31e77a1a3edmr19163997a91.33.1753721099657; Mon, 28 Jul 2025 09:44:59 -0700 (PDT) MIME-Version: 1.0 References: <20250709174748.3514693-1-eperezma@redhat.com> <20250709174748.3514693-6-eperezma@redhat.com> In-Reply-To: From: Eugenio Perez Martin Date: Mon, 28 Jul 2025 18:44:22 +0200 X-Gm-Features: Ac12FXxp1_VOsG1or-IrHYUI5k79pLXDr5H1M_6QAeRLzN-UNf_JuihjsBhcRNw Message-ID: Subject: Re: [RFC v2 05/11] virtio: Fill .next in tx queue To: David Gibson X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QfhTlQE-Zw6Lm0Q18kouK4Ce95cwkxMbGGmvfnPMFLs_1753721100 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2II3XNJ6K2TXPYFXSRBNMNO43BLX3QU7 X-Message-ID-Hash: 2II3XNJ6K2TXPYFXSRBNMNO43BLX3QU7 X-MailFrom: eperezma@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jasowang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Jul 23, 2025 at 9:22=E2=80=AFAM David Gibson wrote: > > On Wed, Jul 09, 2025 at 07:47:42PM +0200, Eugenio P=C3=A9rez wrote: > > This way we can send one frame splitted in many buffers. TCP stack > > English usage node: s/splitted/split/. > > > already works this way in pasta. > > > > Signed-off-by: Eugenio P=C3=A9rez > > --- > > tap.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tap.c b/tap.c > > index 8b3ec45..5667fbe 100644 > > --- a/tap.c > > +++ b/tap.c > > @@ -1727,6 +1727,9 @@ static int tap_ns_tun(void *arg) > > vring_desc[0][i].len =3D PKT_BUF_BYTES/VHOST_NDESCS; > > vring_desc[0][i].flags =3D VRING_DESC_F_WRITE; > > } > > + for (i =3D 0; i < (VHOST_NDESCS - 1); ++i) { > > + vring_desc[1][i].next =3D i+1; > > + } > > passt style omits { } here. > Fixing both for the next revision, thanks! > > for (i =3D 0; i < VHOST_NDESCS; ++i) { > > vring_avail_0.avail.ring[i] =3D i; > > } > > -- > David Gibson (he or they) | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you, not the other wa= y > | around. > http://www.ozlabs.org/~dgibson