From: Jason Xing <kerneljasonxing@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: jmaloy@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, passt-dev@passt.top, sbrivio@redhat.com,
lvivier@redhat.com, dgibson@redhat.com, eric.dumazet@gmail.com
Subject: Re: [net] tcp: add SO_PEEK_OFF socket option tor TCPv6
Date: Sun, 21 Jul 2024 16:14:16 [thread overview]
Message-ID: <CAL+tcoBQPspUNJ2QDxy=m2iut+gZJBPEkRg6yA83TsjnL==S_A@mail.gmail.com> (raw)
In-Reply-To: <CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com>
On Sun, Jul 21, 2024 at 11:23 PM Eric Dumazet <edumazet@google.com> wrote:
>
> On Sat, Jul 20, 2024 at 7:09 AM <jmaloy@redhat.com> wrote:
> >
> > From: Jon Maloy <jmaloy@redhat.com>
> >
> > When we added the SO_PEEK_OFF socket option to TCP we forgot
> > to add it even for TCP on IPv6.
> >
> > We do that here.
> >
> > Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
> >
> > Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
>
> It would be nice to add a selftest for SO_PEEK_OFF for TCP and UDP,
> any volunteers ?
If Jon doesn't have much time, I volunteer :) :p
Thanks,
Jason
next prev parent reply other threads:[~2024-07-21 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 14:09 [net] tcp: add SO_PEEK_OFF socket option tor TCPv6 jmaloy
2024-07-21 13:22 ` Eric Dumazet
2024-07-21 14:14 ` Jason Xing [this message]
2024-08-14 17:47 ` Jon Maloy
2024-07-23 0:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL+tcoBQPspUNJ2QDxy=m2iut+gZJBPEkRg6yA83TsjnL==S_A@mail.gmail.com' \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).