From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LDD9xl9C; dkim-atps=neutral Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by passt.top (Postfix) with ESMTPS id 6C5EE5A004E for ; Sun, 01 Sep 2024 02:33:34 +0200 (CEST) Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-39d4a4e4931so12003485ab.2 for ; Sat, 31 Aug 2024 17:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725150813; x=1725755613; darn=passt.top; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FIFYBB5d/DjVuL/KRdGWSSyy3J0ccWBnOJQj3l4eicU=; b=LDD9xl9CFSxYGTaTztZGo0x5jsYg0R3Zbyu057dku06+qCD5z6q/TzMu68L3XGcSlr M+QVsgKT+wLFUGXxLu6YsZkH7YVartGt9SQ0n49up3ePlTpGnJXYR4pJqQ1VC4P1EuJS Zy24TYNl9REs+CgcrvkkokLV+lj6mNnihcJeRDVn9cO85qGnc7zm8oGc3oE0UmqEW2j5 gazDou0K+6QwHY5Q6Uyq1isp2W27/HzH1TZKX56xYVy9HxMaxdWED6+5eZ6+RWqqr3rD s6riLlG0YYMKEXyr0gqyYMIdK3RcmTK5ppo6NMghSeQKW/CZ68D5V16BOaoMjkw/Sq3F DBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725150813; x=1725755613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FIFYBB5d/DjVuL/KRdGWSSyy3J0ccWBnOJQj3l4eicU=; b=a3Zu6KfbFXdgGH7q0W9qxscrjMGO6znI4ylVCfL2uUKnx16xqD3MEWAiw2Xx5nvneV 4uaofiG9d9Z4IAlxJr+3qai2hTM4d7XXXmPp+TNUIie3zL86qT18f5x5439ywjEY6rT9 rYgdMAtzy4vY/Ki3EGoSZK19LoWliChLB23cIbRUi6IQW2OSlk31ZfTr88nVK1ztC3DE yTSe5ZhglXv0egfvN04HyIwKvxjZRTRBb5MGIr+glRFQU4j71dfpCSIPIA3wx1a9c++s 7VnKpyPa7I2b2BSRanxeO4nPJV7oyczkLLKXYkV6mh3IeQRWRyGVSJ/U97ZgmWMhrz3e ilsg== X-Forwarded-Encrypted: i=1; AJvYcCXI8qPmJF9w9PXdGjoAWrfwUTJBQtUHtqNkxSVbRD5X5hyv0aIk5tCGiWWfcNiNDgnCs8RLWiVz8F8=@passt.top X-Gm-Message-State: AOJu0YwuxNfomsShaflXR+o4lSMcNvowh0wqA3ZoRofLG7Xs5XFJ1w7u 20+2nfnb+d/ZzJBEafSIYXhgNI/3QTszH7SE+dv3A4nGAgPDd4wwF3VL91w39h52pTkCd/prhA8 GBG3B6CMWg4br7ZwAPqQDutMqibU= X-Google-Smtp-Source: AGHT+IGAuVE5H8OI7mCNt6Ix3Wwb302ZPbbpuB6ddxAUy0um/AJ7EiW+n5jRqTbA7bQ1iYSBEZht0P9U307WACvd+xE= X-Received: by 2002:a05:6e02:b4e:b0:39d:514b:311a with SMTP id e9e14a558f8ab-39f379e39f5mr101626025ab.27.1725150813050; Sat, 31 Aug 2024 17:33:33 -0700 (PDT) MIME-Version: 1.0 References: <20240823211902.143210-1-jmaloy@redhat.com> <20240823211902.143210-3-jmaloy@redhat.com> <9f4dd14d-fbe3-4c61-b04c-f0e6b8096d7b@redhat.com> In-Reply-To: <9f4dd14d-fbe3-4c61-b04c-f0e6b8096d7b@redhat.com> From: Jason Xing Date: Sun, 1 Sep 2024 08:32:57 +0800 Message-ID: Subject: Re: [PATCH 2/2] selftests: add selftest for tcp SO_PEEK_OFF support To: Jon Maloy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: kerneljasonxing@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: 4FGSR5E6BU6Y3QN4DSI24OAZK5W3YJDH X-Message-ID-Hash: 4FGSR5E6BU6Y3QN4DSI24OAZK5W3YJDH X-Mailman-Approved-At: Sun, 01 Sep 2024 11:22:17 +0200 CC: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com, eric.dumazet@gmail.com, edumazet@google.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello Jon, On Tue, Aug 27, 2024 at 3:58=E2=80=AFAM Jon Maloy wrote= : > > > > On 2024-08-23 19:44, Jason Xing wrote: > > Hello Jon, > > > > On Sat, Aug 24, 2024 at 5:19=E2=80=AFAM wrote: > >> From: Jon Maloy > >> > >> We add a selftest to check that the new feature added in > >> commit 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") > >> works correctly. > >> > >> Reviewed-by: Stefano Brivio > >> Tested-by: Stefano Brivio > >> Signed-off-by: Jon Maloy > > Thanks for working on this. Sorry that I just noticed I missed your > > previous reply :( > There is still the ditto UDP selftest to be done ;-) The reason why I didn't respond at that time is because I was unsure if I had enough time to finish it. Now it's time. After digging into this, there will be a lot of duplicated code if I write a new one named like "udp_so_peek_off". I think adjusting your tcp_so_peek_off.c to complete the UDP part is just fine. Of course, tcp_so_peek_off.c will be renamed :) I will post one later to see if it's reasonable... Thanks, Jason