public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: jmaloy@redhat.com
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	davem@davemloft.net, kuba@kernel.org, passt-dev@passt.top,
	sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com,
	eric.dumazet@gmail.com, edumazet@google.com
Subject: Re: [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6
Date: Sat, 24 Aug 2024 07:51:05 +0800	[thread overview]
Message-ID: <CAL+tcoDgq+MmNz6Eo_61eBJ2fduyxL1j+kbo_9AYtB4o3tJO5w@mail.gmail.com> (raw)
In-Reply-To: <20240823211902.143210-2-jmaloy@redhat.com>

On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@redhat.com> wrote:
>
> From: Jon Maloy <jmaloy@redhat.com>
>
> When we added the SO_PEEK_OFF socket option to TCP we forgot
> to add it even for TCP on IPv6.

Even though you said "we forgot", I'm not sure if this patch series
belongs to net-next material...

>
> We do that here.
>
> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Tested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>

You seem to forget to carry Eric's Reviewed-by tag, please see the link :)
https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com/

Thanks,
Jason

  reply	other threads:[~2024-08-23 23:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 21:19 [PATCH 0/2] Adding SO_PEEK_OFF for TCPv6 jmaloy
2024-08-23 21:19 ` [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6 jmaloy
2024-08-23 23:51   ` Jason Xing [this message]
2024-08-26 22:25     ` Jon Maloy
2024-08-24  8:55   ` Eric Dumazet
2024-08-23 21:19 ` [PATCH 2/2] selftests: add selftest for tcp SO_PEEK_OFF support jmaloy
2024-08-23 23:44   ` Jason Xing
2024-08-26 19:58     ` Jon Maloy
2024-09-01  0:32       ` Jason Xing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL+tcoDgq+MmNz6Eo_61eBJ2fduyxL1j+kbo_9AYtB4o3tJO5w@mail.gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dgibson@redhat.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jmaloy@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).