From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: passt.top;
	dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=E8UMKohq;
	dkim-atps=neutral
Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a])
	by passt.top (Postfix) with ESMTPS id 8F7AE5A004E
	for <passt-dev@passt.top>; Sat, 24 Aug 2024 01:51:42 +0200 (CEST)
Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-81f861f369aso119837539f.0
        for <passt-dev@passt.top>; Fri, 23 Aug 2024 16:51:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1724457101; x=1725061901; darn=passt.top;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=t5HUwo6cdVCM2XIrnsKrCMxJG7bNZEl/+y37rKj1YDw=;
        b=E8UMKohqVVLZCqsyJba5WsH0g9gDInSJU75SOL3UThxYFbunIIAZqZzJOCkJE8e+vQ
         mOHukgle5cCZun2rxhPFjFcALt/zmPywbEy6J0z9TSV8dmxmBfqG50GVrdqNx4sqncDx
         hZjphPkDyHN/ZyWGVyqrj7NG50yMjZVrMSo1CoJm7yhIIzV2ohUmzyfzVYqaqzlo1lJ/
         tMlsNwqlKiJA/CTRH2EcOdIiBFqCs9nrWH3w2RwNofokTrzN4ySNQnHnoaOfpuD2pJWA
         /qSS8ttQNCQNMJ3fgkASsU/0nkpaufz0peDDxbfwW01FdPZWAmvRQFa9Inpj4yuniPjC
         Myow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1724457101; x=1725061901;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=t5HUwo6cdVCM2XIrnsKrCMxJG7bNZEl/+y37rKj1YDw=;
        b=vmLfRj11CHujvtT5KLj68zQwRKGfD5B3QSUtFyLx1wsPhAJHiBz3GeTORuCPs5Gkgp
         g64y5gaypPWiu7iUYcc/YcbnmzeaKRDJLno7R3I0v3xSnpHp2nBUdqV0sYNAogb8B/iK
         EdFhpuT6dVzNCDgZ7w2sYxieXwwNFsl4uGNXryRoXRY+of07TYPWZTns5dXTUuyhOBw6
         jznRbZPFs6tPpbOSCbcMSQw196TtLnDQRrlRerIWf9IWLKdBZknKd/J43r6oVzIjJFnF
         jP5z5ldvyTT12unUBjLEbJuqwlPIByBUb6JY9l2QpPesZ/EsSBrK64Mh6SXa7xoSOoP9
         3ZgA==
X-Forwarded-Encrypted: i=1; AJvYcCWdU0EGFWIi1mgVm7sJvP47yKlhx46NOVGugevFjhXGMZxp/OoSMHLH7+O/Ohrcdx0Xh5rGjHzHkcU=@passt.top
X-Gm-Message-State: AOJu0YywEA/+BYwQ+epKJxgB+fyKAdGSg1XA21DYFp5NsG9qP7mG7q+e
	dKFFESc3ckv54B0lkE5/3xLDerEVd9ljO9qpcCxSDdslddoz36a5+c9IDHwN9YSElyOXenq1Lp6
	LaMpeJGfGDZOFUIeN0pfbgw9MnRg=
X-Google-Smtp-Source: AGHT+IEOp0Aze6/p+aJG8xuawPHV4qNnF8TwSxUbO1nxw7/XjufAV+sUiSwOhvlkvDUlLkk4nl3yRB7B3Wx+neeKxkw=
X-Received: by 2002:a05:6e02:1d1b:b0:37a:76af:3fca with SMTP id
 e9e14a558f8ab-39e3bdee4edmr45457335ab.3.1724457101113; Fri, 23 Aug 2024
 16:51:41 -0700 (PDT)
MIME-Version: 1.0
References: <20240823211902.143210-1-jmaloy@redhat.com> <20240823211902.143210-2-jmaloy@redhat.com>
In-Reply-To: <20240823211902.143210-2-jmaloy@redhat.com>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Sat, 24 Aug 2024 07:51:05 +0800
Message-ID: <CAL+tcoDgq+MmNz6Eo_61eBJ2fduyxL1j+kbo_9AYtB4o3tJO5w@mail.gmail.com>
Subject: Re: [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6
To: jmaloy@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-MailFrom: kerneljasonxing@gmail.com
X-Mailman-Rule-Hits: nonmember-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation
Message-ID-Hash: F2GEACSTUYCSSHMVARP2YRT7N7QSLRH4
X-Message-ID-Hash: F2GEACSTUYCSSHMVARP2YRT7N7QSLRH4
X-Mailman-Approved-At: Sat, 24 Aug 2024 17:54:08 +0200
CC: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com, eric.dumazet@gmail.com, edumazet@google.com
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/CAL+tcoDgq+MmNz6Eo_61eBJ2fduyxL1j+kbo_9AYtB4o3tJO5w@mail.gmail.com/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/F2GEACSTUYCSSHMVARP2YRT7N7QSLRH4/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

On Sat, Aug 24, 2024 at 5:19=E2=80=AFAM <jmaloy@redhat.com> wrote:
>
> From: Jon Maloy <jmaloy@redhat.com>
>
> When we added the SO_PEEK_OFF socket option to TCP we forgot
> to add it even for TCP on IPv6.

Even though you said "we forgot", I'm not sure if this patch series
belongs to net-next material...

>
> We do that here.
>
> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Tested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>

You seem to forget to carry Eric's Reviewed-by tag, please see the link :)
https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=
=3D8OQ@mail.gmail.com/

Thanks,
Jason