From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=ji9H/tqM; dkim-atps=neutral Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by passt.top (Postfix) with ESMTPS id BA77E5A004E for ; Tue, 28 Jan 2025 18:12:01 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-ab68a4ab074so521061866b.0 for ; Tue, 28 Jan 2025 09:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738084321; x=1738689121; darn=passt.top; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hcQD1fdJZynbKTTaiAhfOXu+zrcKSjiO0b418sCTMgk=; b=ji9H/tqMKIEDX8Z+Xh7bnl6SpdGfKUeujBtU4T/GueSVMQXRJpkpZVhaMmPJ3Qq3xz 3PC6qoGgqGiTWygV3MM0tzJpktthNOGvoeARxCJTKg2zICLF+T3OySlnTW0Q+b+gxFZ7 HjBtVgRNnP5D64rX6u7syrpJf7lpDl14PUslwm8WuOsri7VxzkUYONf60ThTIzzz9Csc QyFAQ6A9/vOFk21PYlMLb0N5DQZzff/3MHhokr+QfWTGNLUuqRxHz7S5H+2ZZVsdGSJ7 lo3XcQER7vu/s8+omuiRZNhOJBHmxVnMdKc0kH22QvTeLKkU2JTmVK8LTXWa0proiKHB EpiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738084321; x=1738689121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hcQD1fdJZynbKTTaiAhfOXu+zrcKSjiO0b418sCTMgk=; b=WzD2WJCDiextz8ayJByS6hlqkjh3WSsX18iXkAfRw3qLhJsGg5HD2Y8g51MhrkGkLX gsfKymvppAT525C/mpsMa7Z1BVbmBm4y9Zt6yea9FCQeebKvLXiVzdZpGymXSLGc3HXG vITSNw9YeumVtyY8yXKPHvp/RtGJJHTavE69sa7S/ccAQw5y8QipBBOMjyVgjvw38W4y FW2J31nl/m561NNymcnd7uYpnK/nyQuxK/VipC/axvNIPXW/zjdz7z9GpiuT11MVUGvL m4FJufh1XpFe7FxrzVryQvAqHS2+79VzKMIItxlm3Ita1qE0vteUkvCCLKPhIY8UXTTB 8p+Q== X-Forwarded-Encrypted: i=1; AJvYcCUZOyTuABS9sH+g945Mngckz4QlSd5b8/zLErNrzLKWbdSiErOTz0jFRuF8RdczzNj5riXKgsGAkpU=@passt.top X-Gm-Message-State: AOJu0YyU91sLyX3VCkfm54SI1baLi7bKHDJJsRE3wC/7Ful2jOXSb9mg bR0BHA4toVRfrveLzNXRbxvlnZcJzR5TbRUtDNLKXKhBG1Xz/aQYYXS/uJTQqOOjdslkNU6/9WX 6OxQrpYgsatSVsE6wgwEfsB+kFLVWP6bJRqjD X-Gm-Gg: ASbGnct+StY50NxT0Pn9WFnzL13enufqCjNpZysyQFRkT+T7PwtJF39SQxP/WvGXFuE UlQefEO+Qq8MLnv1b6nsagIZDbzT9U2rMHRZsBU9jaj85wY/ANrMzsCHDkHSaBtf1zp6CA6lo X-Google-Smtp-Source: AGHT+IGktr9mwYEMzeQ/Y1KJ5FNYumRp4sqnIdMw0E2QJUIbcbrvObVgW0Bw1Pe11l0DKyfu5SCpEaSxTyPgbUft/qI= X-Received: by 2002:a05:6402:4406:b0:5d9:84ee:ff31 with SMTP id 4fb4d7f45d1cf-5db7d2dc6d2mr106600123a12.3.1738084321123; Tue, 28 Jan 2025 09:12:01 -0800 (PST) MIME-Version: 1.0 References: <20250127231304.1465565-1-jmaloy@redhat.com> <415dde0a-2272-45d2-8fa8-473fe7637a78@redhat.com> In-Reply-To: <415dde0a-2272-45d2-8fa8-473fe7637a78@redhat.com> From: Eric Dumazet Date: Tue, 28 Jan 2025 18:11:49 +0100 X-Gm-Features: AWEUYZlm7d16TwJ9isgMknDvaIJJ0fd-5Wq54l2xoSSxmRybdwYXu7YVBF1qNv4 Message-ID: Subject: Re: [net,v3] tcp: correct handling of extreme memory squeeze To: Jon Maloy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: edumazet@google.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: WQCT6MBE7JICWEAAIBRPQFKZ34GJPRE2 X-Message-ID-Hash: WQCT6MBE7JICWEAAIBRPQFKZ34GJPRE2 X-Mailman-Approved-At: Tue, 28 Jan 2025 18:16:33 +0100 CC: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com, memnglong8.dong@gmail.com, kerneljasonxing@gmail.com, ncardwell@google.com, eric.dumazet@gmail.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jan 28, 2025 at 5:51=E2=80=AFPM Jon Maloy wrote= : > I clearly stated in a previous comment that this was the case, and that > it has been fixed now. My reason for posting this is because I still > think this is a bug, just as I think the way we use rcv_ssthresh in > _tcp_select)window() is a bug that eventually should be fixed. I was referring to a wrong statement in the changelog, claiming a 'deadlock situation' ... It is pretty clear there is no deadlock here, unless the remote TCP stack is _absolutely_ _broken_. If you still want to capture this in an official changelog, it would be nice to clarify this, to avoid yet another CVE to be filled based on scary sentences misleading many teams in the world. Keep changelogs accurate and factual, so that we can find useful signals in them. All your __tcp_cleanup_rbuf() repetitions are simply noise. It does not mat= ter if it is called once or ten times.