From: Eric Dumazet <edumazet@google.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: jmaloy@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, passt-dev@passt.top, sbrivio@redhat.com,
lvivier@redhat.com, dgibson@redhat.com,
memnglong8.dong@gmail.com, kerneljasonxing@gmail.com,
eric.dumazet@gmail.com
Subject: Re: [net,v3] tcp: correct handling of extreme memory squeeze
Date: Tue, 28 Jan 2025 17:01:30 +0100 [thread overview]
Message-ID: <CANn89iLufFGyW0V-RJRhp928HV4+2JF=8BCPQJvTgpagn_OpOQ@mail.gmail.com> (raw)
In-Reply-To: <CADVnQyn7afmGhuUOEzvFV099476pxrAUHE+FVnmiwwbo1tu1oA@mail.gmail.com>
On Tue, Jan 28, 2025 at 4:57 PM Neal Cardwell <ncardwell@google.com> wrote:
>
> Yes, thanks for the fix. LGTM as well.
>
> Reviewed-by: Neal Cardwell <ncardwell@google.com>
>
> BTW, IMHO it would be nice to have some sort of NET_INC_STATS() of an
> SNMP stat for this case, since we have SNMP stat increases for other
> 0-window cases. That could help debugging performance problems from
> memory pressure and zero windows. But that can be in a separate patch
> for net-next once this fix is in net-next.
This is LINUX_MIB_TCPRCVQDROP ( TCPRcvQDrop )
next prev parent reply other threads:[~2025-01-28 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 23:13 [net,v3] tcp: correct handling of extreme memory squeeze jmaloy
2025-01-28 0:52 ` Jason Xing
2025-01-28 15:04 ` Eric Dumazet
2025-01-28 15:18 ` Stefano Brivio
2025-01-28 15:56 ` Neal Cardwell
2025-01-28 16:01 ` Eric Dumazet [this message]
2025-01-28 16:51 ` Jon Maloy
2025-01-28 17:11 ` Eric Dumazet
2025-01-30 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLufFGyW0V-RJRhp928HV4+2JF=8BCPQJvTgpagn_OpOQ@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jmaloy@redhat.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=lvivier@redhat.com \
--cc=memnglong8.dong@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).