From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QrfdwTnX; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 0A5645A0271 for ; Wed, 03 Sep 2025 04:09:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756865387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mvfPnM6RSkyAASVAzIv+lsc9FVi1GW/IBNukGkGBZIw=; b=QrfdwTnX4IKxLy1YXYAEljtGuvu7UiP5ax5uvDgIVVxby3jHifJwLA8BS/DC7a2vs9aMcW MHCoXHIVXxGrOf1LcxZFq4+UAoJb1jcOUFR52mQDxzEn7Sa8XJwZ7n+ZvTdQToL8+KLSGt P1bEWd4UupNV8qd3sZlR6Rgl4s//T70= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-Bi_N7NpHMymr_9N36A7gyg-1; Tue, 02 Sep 2025 22:09:45 -0400 X-MC-Unique: Bi_N7NpHMymr_9N36A7gyg-1 X-Mimecast-MFC-AGG-ID: Bi_N7NpHMymr_9N36A7gyg_1756865385 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-afe81959e5cso571125566b.1 for ; Tue, 02 Sep 2025 19:09:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756865385; x=1757470185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvfPnM6RSkyAASVAzIv+lsc9FVi1GW/IBNukGkGBZIw=; b=VbxJzM6MkYQL+ReBAQlY/kFCfbzGfQYkkSeaUS6HzI5BAIaa/4jIkKXudMsE6fvTp2 0lJvszBG6iJ4gnUOmN0HqDDdngX077Qrq34EYVGff/Tgepa/WDnua2H7KkQUT/2LvZg4 /+OFacBrV5mGnXGsf21q152AYyxFzPSbIHhD5AXD5iey+OGTAVQ+vbBzyinzF6hjF4eQ c5QVP/b+PHpVYbndBbFhmto4wIrzeyDcw++HuFLmJgZDo1z/jrQV9PbGEMgZm2klrHi2 k7w6v7YC/m143TVCQNSBFwdEfvDYfe6/MmcMFSXEAEJYyioHIdrJdiwDOMIx4yRdCSVc 2qzQ== X-Gm-Message-State: AOJu0YxdswIwNTAT6QC81SoxMQfeLBphbPgM9DqsWDhHNZK822EMJ6eM 88QvHHlzkn+G01G+Ir+lLvgH/fw+hJpNU83bRu0y1O4/bW6mgn6ZUMZPHAnujBdZd2ZEIzx61V1 8mrbJZNQGheYd7ZDWQllZDoM1GxVK7fdpwQKPbHE8rbIi/mrXMnz3A0HhxI9+OuOGVwXLIydoeO 7w3crHv6xi88/4oy9DDCV/lWHFCZf+ X-Gm-Gg: ASbGnct8hhe2sX4Le4PxvysIqNiW2Gl6+rGv+r7nnj04ejlDXAYiBRGzmKLGpbKN9oL hC5JKDzMPzCz/JssoZ9euaa5Mnn3epwmb3aY5szbh5jbTFIFH912yvKXQe019VBvEMohDlDLbQm 8IzLAlcBfUsPrN/y+RyJGSVg== X-Received: by 2002:a05:6402:5108:b0:61c:fb8e:ab61 with SMTP id 4fb4d7f45d1cf-61d26eb420emr12576761a12.28.1756865384699; Tue, 02 Sep 2025 19:09:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOvYVEXGuWZBvsNPjpR3P5tShSPg1O1T3fUPcvkJtGhl7cEBEbbX4dvoiUugvs80nsgDz4DU0ga31FYZ/l2O4= X-Received: by 2002:a05:6402:5108:b0:61c:fb8e:ab61 with SMTP id 4fb4d7f45d1cf-61d26eb420emr12576751a12.28.1756865384332; Tue, 02 Sep 2025 19:09:44 -0700 (PDT) MIME-Version: 1.0 References: <20250902021728.6889-1-yuhuang@redhat.com> <20250902190656.00c02de9@elisabeth> In-Reply-To: <20250902190656.00c02de9@elisabeth> From: Yumei Huang Date: Wed, 3 Sep 2025 10:09:33 +0800 X-Gm-Features: Ac12FXyNynb5zP89LLi4clYrz0gOPdeVxT5OsQG5cGcOU26gpLqB9RfSZcr-cck Message-ID: Subject: Re: [PATCH v2] build: Fix errors of TCP_REPAIR_* undeclared To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 19GNNx5d-GtnfMJ4hW8yNkZOlM7ZkAsLcuLilEMTwuk_1756865385 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: X2JJLCOV5RVYT77WOSNYUBDSBDAFCIZP X-Message-ID-Hash: X2JJLCOV5RVYT77WOSNYUBDSBDAFCIZP X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, dgibson@redhat.com, dongsheng.song@gmail.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Sep 3, 2025 at 1:07=E2=80=AFAM Stefano Brivio = wrote: > > On Tue, 2 Sep 2025 10:17:28 +0800 > Yumei Huang wrote: > > > Based on an original patch by Dongsheng, fix the following errors on sy= stems with glibc < 2.29: > > > > tcp.c: In function =E2=80=98tcp_flow_repair_on=E2=80=99: > > tcp.c:2787:38: error: =E2=80=98TCP_REPAIR_ON=E2=80=99 undeclared (first= use in this function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? > > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_ON))) > > ^~~~~~~~~~~~~ > > TCP_REPAIR > > tcp.c:2787:38: note: each undeclared identifier is reported only once f= or each function it appears in > > tcp.c: In function =E2=80=98tcp_flow_repair_off=E2=80=99: > > tcp.c:2807:38: error: =E2=80=98TCP_REPAIR_OFF=E2=80=99 undeclared (firs= t use in this function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? > > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_OFF))) > > ^~~~~~~~~~~~~~ > > TCP_REPAIR > > make: *** [Makefile:94: passt] Error 1 > > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D121 > > Reported-by: Dongsheng > > Signed-off-by: Yumei Huang > > Applied, thanks, and welcome to the git log! Thanks, I see it! > > -- > Stefano > --=20 Thanks, Yumei Huang