From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VaTrq+6D; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id A4CD35A026F for ; Wed, 22 Oct 2025 05:37:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761104241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZOjiQu4IgPZY6u2V5ZnzLzO7HtGBOxssyIk+f+DqLhU=; b=VaTrq+6DJ82tP8BuY6bVPLZbOLk6NF8mwulevANbNS2TxlG9LsVLvHYU8oHimQwAAIuxSZ uwfLWs65QBzITaCROSz20358BpPtu223befN8SPWc+Haraz0yOvqhrLsRJVV1pKYebOiIZ 9SO738ALn6FpBoh+tThhRZkYpDURGVY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-TGxco3_gPB-MTQ6R9PXi8g-1; Tue, 21 Oct 2025 23:37:19 -0400 X-MC-Unique: TGxco3_gPB-MTQ6R9PXi8g-1 X-Mimecast-MFC-AGG-ID: TGxco3_gPB-MTQ6R9PXi8g_1761104238 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b5a8154aa38so706450566b.3 for ; Tue, 21 Oct 2025 20:37:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761104238; x=1761709038; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZOjiQu4IgPZY6u2V5ZnzLzO7HtGBOxssyIk+f+DqLhU=; b=uNPVNKHEQ5TOyUPIMFUF9GTBUF87mafTfzbd3sZNa5RQleM2yCsHmFG1Fl87ioVSc0 sI3pSuT8T8eWzpdb+scDLvmdFY4thaoWDLLaIROVAQJ77t+8khQxizusOPYHYSb5ZW4X U8Kf41DLiIRou1Lc33l/9sjc/15CBcUr6zRH0rhbog0ADXKV4U/WGWnY5ANbsO9pw2G6 /eZwgV/nTP/a9jrNTun7/HFYz6zlHPHyhpE9gYzdJJh1fRjViNt6yj0UR5qX+m+CJLMn no2ONvGXP4kE5sNF3RHQV0nVexo2wRQgizTPtROI3NIshg0vJ2ZkrpbI4AbdDb1xe+7o h4VQ== X-Gm-Message-State: AOJu0YwRNk0z1Jt/3TbA7e8w0T13zTNUjzdb/6cTfsABaeLrirQl3TfW 47Qv29Xp4zh0dFTFZqiQnYLX7dZLDg8ljpOjz/9C9a6mQoWSmdzcrbCw7E3vSFZfnmYp3OlmKxL Lkydp8NscCCWsXoy9BFMV+MfXZ9bRJgwxwNXQavIzLHumU5mQ9k3w+qarmQgFo5TG2/lHCbdfdu aVQSJ5Uf0mzWNHhtu1fDEvmkuYX6+w X-Gm-Gg: ASbGncszSzLlCicVKiiaxSOxfPZFVgPYQcpo/jfpewL5CbUOodbsj1hLGSlrKAOU2jJ Dc+ziqKWkmgRd8xH2tCDERUg5AJp8zVIu5oaCIq1FBXSd5gC6mNLk3r6pLZkcC2uultUEhZO6wf rgwGDnsaC6dHBHLWYeNNKjipjhg9hsiciL2utQqSsgezV1IuzgnsgLwIkH X-Received: by 2002:a17:906:ef04:b0:b40:6e13:1a82 with SMTP id a640c23a62f3a-b64747339f8mr2107042966b.26.1761104237890; Tue, 21 Oct 2025 20:37:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVov8Om4Tg7zg7GfQbWvgOxz1MJSkO/0xBe2Ym7/vHp3GplEWfoPFevMuBZ5TppoEivqLuwTieQHyTc9eA6ZQ= X-Received: by 2002:a17:906:ef04:b0:b40:6e13:1a82 with SMTP id a640c23a62f3a-b64747339f8mr2107040966b.26.1761104237378; Tue, 21 Oct 2025 20:37:17 -0700 (PDT) MIME-Version: 1.0 References: <20251015080402.18822-1-yuhuang@redhat.com> <20251021235103.4496c153@elisabeth> In-Reply-To: <20251021235103.4496c153@elisabeth> From: Yumei Huang Date: Wed, 22 Oct 2025 11:37:06 +0800 X-Gm-Features: AS18NWCrzWqHwdf0DhkkSnW87A0yHpEf5YnOQJkKvWg_Rg8K1_SPxmOY0Riscig Message-ID: Subject: Re: [PATCH] test: Fix the escaping issue in memory/passt test To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ouZz2fENWOaFnA8-C8Tzd4-gS7LllR5zqD0bcNvpJVs_1761104238 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2YS65UVYFRCRTOCTWQIZ35TN4EBQKFUE X-Message-ID-Hash: 2YS65UVYFRCRTOCTWQIZ35TN4EBQKFUE X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Oct 22, 2025 at 5:51=E2=80=AFAM Stefano Brivio = wrote: > > On Wed, 15 Oct 2025 16:04:02 +0800 > Yumei Huang wrote: > > > Test memory/passt failed with error "objsize: No such file or > > directory" because of an escaping issue. Fix it. > > Sorry for the delay. > > I tested the patch and it works for me, it simply adds a \ at the > beginning of the line, and that print simply shows results in the test > log. The output is not used in any automated way. > > But I never ran into the issue, so I was looking for an explanation for > this: > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D155 > > Signed-off-by: Yumei Huang > > --- > > test/memory/passt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/memory/passt b/test/memory/passt > > index 7e45724..c5142ea 100644 > > --- a/test/memory/passt > > +++ b/test/memory/passt > > @@ -51,7 +51,7 @@ guest sed /proc/slabinfo -ne 's/^\([^ ]* *[^ ]*= *[^ ]* *[^ ]*\).*/\\\1/p' > /tmp > > guest kill \$(cat /tmp/pid) > > guest diff -y --suppress-common-lines /tmp/meminfo.before /tmp/= meminfo.after || : > > guest nm -td -Sr --size-sort -P /bin/passt.avx2 | head -30 | te= e /tmp/nm.size > > -guest sed /proc/slabinfo -ne 's/\(.*\).*$/\1/p' | tail= -1; (diff -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.af= ter | sort -grk8) > > +guest sed /proc/slabinfo -ne 's/\(.*\).*$/\\\1/p' | ta= il -1; (diff -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.= after | sort -grk8) > > Without the \ at the beginning, we have this line: > > # name > > and... maybe you have a file in the directory where you run the tests > that's called num_objs, or objsize, created as a result of a previous > failure (and some other issue), and ' so it's taken as a redirection? > > Perhaps a \# at the beginning, instead of #, makes Bash ignore the > whole line, and for some reason it's not ignored otherwise? > > It shouldn't have anything to do with the guest image because that's > read-only. > > Could you have a look if you see any "strange" file name in your test > directory? I don't see any strange file either num_objs or objsize in my test directory. The cmd is supposed to run inside the guest, and the error appears in pane_guest.log. I guess it's not related to the files on the host? > > Otherwise I would be tempted to just go ahead and apply this because > it's harmless and it's not *that* important that we find a solution to > this. We're going to rewrite this test eventually. > > -- > Stefano > -- Thanks, Yumei Huang