From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EvjbBY8M; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 8BDF75A0279 for ; Thu, 11 Sep 2025 03:11:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757553063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FcF+BomCMwkMZMg5TI1mA7XS/9l8C/18VGUd49lVzjQ=; b=EvjbBY8MVfk4UefqemjeFdQo93SEgFLqCn8pC2bZNsVlpqwNzVal3XgAADZgeaBl+5yQyf Iy3z8DxBsRs4CQ3gui9V0zHC4U/wD+HQ9TfEOcvdYNSOVm2CE97jTE2zxbvRU+aFv2rAIk NY4kd1safMGeiBmIuUsYw4LFVOPIDug= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-O6b28uMvOnqRPEHypvWvuw-1; Wed, 10 Sep 2025 21:11:02 -0400 X-MC-Unique: O6b28uMvOnqRPEHypvWvuw-1 X-Mimecast-MFC-AGG-ID: O6b28uMvOnqRPEHypvWvuw_1757553061 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62806a204d9so161936a12.3 for ; Wed, 10 Sep 2025 18:11:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757553061; x=1758157861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FcF+BomCMwkMZMg5TI1mA7XS/9l8C/18VGUd49lVzjQ=; b=PS0VAKdv4M1BABMt8hhfpBMwQIY4ChTS+25I4cZO8m5vwmFCk3Kry1ktxjV5kPJ8vm gkQF/5AigjV0xQLdtXU8Tg+f2XZZKK1y9guxb+xIgUGcDR2yY7zshH8/dWwv/0Zf/IJE A4JFjs1zx7wSxVEwg1J0FxB3rn0tD6C0rmE40sKpgkA+DFSda0+RPeenUPJpI1AOrS8M hsJIgSaeCCGrDcd1YXQ7ueuojxS8vFXS/SxeI0Q7zyzf1jKdsjo5x6/09htM9d2SYWoS XXPp7tzTTDdsuMfVckcOnelW/Sito6cD3OHzI8t5DF3lDbWXaMWI7HX1hhX1TnRrjgde lPDA== X-Gm-Message-State: AOJu0Ywc8gLSjlKnTvi59BeCUrvBr31cFvyJgz6CLBs/WhGJjyMzch0Q HwLy6exB9X93ZttLx/ivThlMnGdT72m0Xp2myC1tgsoB5ZuYfYdiTiV+VFMq8bQx85p8ExA8DOs bB9f50BUabghi6X/gmDES6dMgkGgGB0X2F6Lldy/mfMVKuEjB+03tfSMDCoVLGkZkkYVCWPZmeQ OeMbX+l+t4KpIXXlPzvJ3IAwD4eALl X-Gm-Gg: ASbGncs3Hw0ovl+bdLzRwy40oA56finRGyyytIVablGS1zP2ByJ2AXmKMJ+i2AX389D Xr4oULKMMGodd9BwZ6z5AptDwA35uwjXAnbC75QNpj+HOyhS3UpH7B56S8fiZBjWeWIH/T/FdDw os5OzfU2LwavusBuFvC1yTKQ== X-Received: by 2002:a05:6402:5242:b0:623:4a7:c670 with SMTP id 4fb4d7f45d1cf-623728d6fabmr15416340a12.8.1757553060772; Wed, 10 Sep 2025 18:11:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHISBiqp6flFaUg7bNsZOHwtTENRUv4VbsPkkDjxCavSN+8J6vghuH78o7yUPe4FRLt9SJVoK3ght3v4Sm5vZQ= X-Received: by 2002:a05:6402:5242:b0:623:4a7:c670 with SMTP id 4fb4d7f45d1cf-623728d6fabmr15416320a12.8.1757553060433; Wed, 10 Sep 2025 18:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20250910095647.25279-1-yuhuang@redhat.com> In-Reply-To: From: Yumei Huang Date: Thu, 11 Sep 2025 09:10:49 +0800 X-Gm-Features: AS18NWCDrFn9-3kemQXtA5mQDTDbI83ZNaKLbfDZyIb9OAobt11CH5uCAH6AQS4 Message-ID: Subject: Re: [PATCH v2] tcp: Store the owner connections for flags frames To: Volker Diels-Grabsch X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SHH7XlPVB-Jz8aLRPzzZd9A7LK1x27HwGHCao0lOPgQ_1757553061 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LXNATV3MW4MJYDBD5KHGQWJBOPRNXHUV X-Message-ID-Hash: LXNATV3MW4MJYDBD5KHGQWJBOPRNXHUV X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, dgibson@redhat.com, boleyn.su@gmail.com, david@gibson.dropbear.id.au, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Sep 10, 2025 at 6:50=E2=80=AFPM Volker Diels-Grabsch wro= te: > > Dear Yumei, > > Thanks a lot for providing a proper fix for that issue. Just a minor > nitpick from my side: > > Yumei Huang wrote: > > @@ -209,13 +209,14 @@ int tcp_buf_send_flag(const struct ctx *c, struct= tcp_tap_conn *conn, int flags) > > if (ret <=3D 0) > > return ret; > > > > - tcp_payload_used++; > > + tcp_frame_conns[tcp_payload_used++] =3D conn; > > l4len =3D optlen + sizeof(struct tcphdr); > > iov[TCP_IOV_PAYLOAD].iov_len =3D l4len; > > tcp_l2_buf_fill_headers(conn, iov, NULL, seq, false); > > > > if (flags & DUP_ACK) { > > struct iovec *dup_iov =3D tcp_l2_iov[tcp_payload_used++]; > > + tcp_frame_conns[tcp_payload_used - 1] =3D conn; > > I find it a bit strange to read that way, incrementing tcp_payload_used > just to subtract one from it in the next step. I, personally, would > find it easier to read and to understand that way around: > > struct iovec *dup_iov =3D tcp_l2_iov[tcp_payload_used]; > tcp_frame_conns[tcp_payload_used++] =3D conn; Good point. Sent v3. Thanks! > > But maybe it's just me. > > > Best regards, > Volker > > -- > .---<<<((()))>>>---. > | [[||]] | > '---<<<((()))>>>---' > -- Thanks, Yumei Huang