From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S6VOGfMU; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 5DEE25A0278 for ; Mon, 08 Sep 2025 09:57:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757318229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NwofqMaMEofKj5AV4PTNzVYuY7JfsT2Jjk6aehx5d8=; b=S6VOGfMU1hY+tU+N9fx/QfnN5uJLVPbE2PU2VjikPeei6ZSD2MuqQSgPBMrm80NxG0Bktm uAsBnWR4tP79x1e9E+vChMBzBxZNs8qlfHUWY3pWyIDBoZQK1Y9RhL+S2MSlUKmZESrjYp YKDFyPQG2doF/E3II5g2vIYf3tasKqc= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-2laP5B7BMEyBFo68CLt4Pw-1; Mon, 08 Sep 2025 03:57:07 -0400 X-MC-Unique: 2laP5B7BMEyBFo68CLt4Pw-1 X-Mimecast-MFC-AGG-ID: 2laP5B7BMEyBFo68CLt4Pw_1757318227 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-628cda89219so586761a12.2 for ; Mon, 08 Sep 2025 00:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757318226; x=1757923026; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0NwofqMaMEofKj5AV4PTNzVYuY7JfsT2Jjk6aehx5d8=; b=kfxWvjsxxhvAieVyuR5fPJe9nHNz1jnw+mapasQlmTfNtQNTCWiNh/wFNaXMG5vq3S jyptOavuWPP97PCii6QLiavIl4iv6gmaoj3pvidOVGgHBDsbeBn+43Asft4DjPW/Y74n Q4E7qe7s/nhuskAojk0nRQdg3a29shgayULXG/mzd29KWj5j1wUm09y7OIH1BWbl5uYY vyb3yGWOVvKY7kZq/AgMSrQ/jMpgshXsgbfIbFshze5BaTokDz9yJSTr5dHfnXB2cERK Uxo+GXAfQS+twOwgpa4CQiAO/WGu0Cf5W5cdBHyicoPhRZm6d7YtsrCN7MQjP7zzw9xb 2XCA== X-Gm-Message-State: AOJu0YyGwbdb7W68rQiTTgDLxIvrdaIXL5odlAESgwoam/VnfCpoPrrw dnHOvftoyWoGciXWQUxs5DbHiJdsVdjHrbfTfeStQJY99ZsXy324vxlTFZ9qd8Wd5JbGlcdGlkg 25qv4HEnlvf3JisMKrEhXMh9EA2ZTel38CNOVKq1pq6s5iEDwYjEBSu3RzheV2q/aCZobmA4vXT uIRhLwc/zNcXDUzqsg/iRssSVh0uST X-Gm-Gg: ASbGnctG/++Q0KcCYz4nvFYGR4cx8dHHIrPIhH8/Bc1EQtAgnCJQRUiiLaQI34d/xwo V6HIqMOZoxix6c28UCDMWFyZiiffifycuZrcDzTJy8tcJiq8ftgwL8ozSyuVpqIk5II25atzPc8 hiUb1GAvl8lgPc9QVhb+AYdQ== X-Received: by 2002:a05:6402:510d:b0:628:d916:9d3 with SMTP id 4fb4d7f45d1cf-628d9255082mr1944418a12.6.1757318226476; Mon, 08 Sep 2025 00:57:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6R5LSLG14DZ4voivDzGs8z+tQFqNt/Rbvmw5OQpamXS8/ao3CWHSBU2XM+lKqd70qpU0/ORwkXVmOCgNzyME= X-Received: by 2002:a05:6402:510d:b0:628:d916:9d3 with SMTP id 4fb4d7f45d1cf-628d9255082mr1944388a12.6.1757318225977; Mon, 08 Sep 2025 00:57:05 -0700 (PDT) MIME-Version: 1.0 References: <20250908060921.13839-1-yuhuang@redhat.com> In-Reply-To: From: Yumei Huang Date: Mon, 8 Sep 2025 15:56:54 +0800 X-Gm-Features: AS18NWDw6LihU1_gcA_yJyWUqSHxUMbiGI6aSY8oPBGcEWAYQ6M7PSkMfdPFgF0 Message-ID: Subject: Re: [PATCH] test: Remove unused distro images To: David Gibson X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dPilP6nwA73RK2iW4w4kI2IuXFMjog1QLCCnaJrEDGw_1757318227 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WB7VHMIXAXTEWSAYHVNSYFO6K5Q2DJGS X-Message-ID-Hash: WB7VHMIXAXTEWSAYHVNSYFO6K5Q2DJGS X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Sep 8, 2025 at 3:10=E2=80=AFPM David Gibson wrote: > > On Mon, Sep 08, 2025 at 02:09:21PM +0800, Yumei Huang wrote: > > Some of the download links are broken, and none of the images are > > used in current tests. Removing them so it won't block make. > > > > Signed-off-by: Yumei Huang > > Ah, sorry. I realised I forgot some information when I suggested you > make this change. > > Although we're not using these images at the moment, we hope to use > them again some time in future. For that reason it's useful to keep > the information about what the images were and how they worked in > place. > > So, rather than removing this completely, it would be better to keep > the {DEBIAN,...}_IMGS variables and the download targets, but just > don't include them in DOWNLOAD_ASSETS for now. That will make it > easier to put a fixed version of this back when we're ready. Makes sense. I=E2=80=99ve updated the patch accordingly in v2, thanks! > > > --- > > test/Makefile | 124 +------------------------------------------------- > > 1 file changed, 1 insertion(+), 123 deletions(-) > > > > diff --git a/test/Makefile b/test/Makefile > > index a774285..d7c37d6 100644 > > --- a/test/Makefile > > +++ b/test/Makefile > > @@ -9,51 +9,7 @@ BATS =3D bats -j $(shell nproc) > > EXETOOL =3D exeter/exetool/exetool > > WGET =3D wget -c > > > > -DEBIAN_IMGS =3D debian-8.11.0-openstack-amd64.qcow2 \ > > - debian-10-nocloud-amd64.qcow2 \ > > - debian-10-generic-arm64.qcow2 \ > > - debian-10-generic-ppc64el-20220911-1135.qcow2 \ > > - debian-11-nocloud-amd64.qcow2 \ > > - debian-11-generic-arm64.qcow2 \ > > - debian-11-generic-ppc64el.qcow2 \ > > - debian-sid-nocloud-amd64-daily.qcow2 \ > > - debian-sid-nocloud-arm64-daily.qcow2 \ > > - debian-sid-nocloud-ppc64el-daily.qcow2 > > - > > -FEDORA_IMGS =3D Fedora-Cloud-Base-26-1.5.x86_64.qcow2 \ > > - Fedora-Cloud-Base-27-1.6.x86_64.qcow2 \ > > - Fedora-Cloud-Base-28-1.1.x86_64.qcow2 \ > > - Fedora-Cloud-Base-28-1.1.aarch64.qcow2 \ > > - Fedora-Cloud-Base-29-1.2.x86_64.qcow2 \ > > - Fedora-Cloud-Base-29-1.2.aarch64.qcow2 \ > > - Fedora-Cloud-Base-30-1.2.x86_64.qcow2 \ > > - Fedora-Cloud-Base-30-1.2.aarch64.qcow2 \ > > - Fedora-Cloud-Base-31-1.9.x86_64.qcow2 \ > > - Fedora-Cloud-Base-31-1.9.aarch64.qcow2 \ > > - Fedora-Cloud-Base-32-1.6.x86_64.qcow2 \ > > - Fedora-Cloud-Base-32-1.6.aarch64.qcow2 \ > > - Fedora-Cloud-Base-33-1.2.x86_64.qcow2 \ > > - Fedora-Cloud-Base-33-1.2.aarch64.qcow2 \ > > - Fedora-Cloud-Base-34-1.2.x86_64.qcow2 \ > > - Fedora-Cloud-Base-34-1.2.aarch64.qcow2 \ > > - Fedora-Cloud-Base-35-1.2.x86_64.qcow2 \ > > - Fedora-Cloud-Base-35-1.2.aarch64.qcow2 > > - > > -OPENSUSE_IMGS =3D openSUSE-Leap-15.1-JeOS.x86_64-kvm-and-xen.qcow2 \ > > - openSUSE-Leap-15.2-JeOS.x86_64-kvm-and-xen.qcow2 \ > > - openSUSE-Leap-15.3-JeOS.x86_64-kvm-and-xen.qcow2 \ > > - openSUSE-Tumbleweed-ARM-JeOS-efi.aarch64.raw.xz \ > > - openSUSE-Tumbleweed-ARM-JeOS-efi.armv7l.raw.xz > > - > > -UBUNTU_OLD_IMGS =3D trusty-server-cloudimg-amd64-disk1.img \ > > - trusty-server-cloudimg-i386-disk1.img \ > > - trusty-server-cloudimg-ppc64el-disk1.img > > -UBUNTU_NEW_IMGS =3D xenial-server-cloudimg-powerpc-disk1.img \ > > - jammy-server-cloudimg-s390x.img > > -UBUNTU_IMGS =3D $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) > > - > > -DOWNLOAD_ASSETS =3D exeter mbuto podman \ > > - $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS) > > +DOWNLOAD_ASSETS =3D exeter mbuto podman > > TESTDATA_ASSETS =3D small.bin big.bin medium.bin \ > > rampstream > > LOCAL_ASSETS =3D mbuto.img mbuto.mem.img podman/bin/podman QEMU_EFI.fd= \ > > @@ -150,81 +106,3 @@ clean: > > realclean: clean > > rm -rf $(DOWNLOAD_ASSETS) > > > > -# Debian downloads > > -debian-8.11.0-openstack-%.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/OpenStack/arc= hive/8.11.0/debian-8.11.0-openstack-$*.qcow2 > > - > > -debian-10-nocloud-%.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/latest= /debian-10-nocloud-$*.qcow2 > > - > > -debian-10-generic-ppc64el-20220911-1135.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/202209= 11-1135/debian-10-generic-ppc64el-20220911-1135.qcow2 > > - > > -debian-10-generic-%.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/latest= /debian-10-generic-$*.qcow2 > > - > > -debian-11-nocloud-%.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/bullseye/late= st/debian-11-nocloud-$*.qcow2 > > - > > -debian-11-generic-%.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/bullseye/late= st/debian-11-generic-$*.qcow2 > > - > > -debian-sid-nocloud-%-daily.qcow2: > > - $(WGET) -O $@ https://cloud.debian.org/images/cloud/sid/daily/lat= est/debian-sid-nocloud-$*-daily.qcow2 > > - > > -# Fedora downloads > > -Fedora-Cloud-Base-26-1.5.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/26/CloudImages/$*/images/Fedora-Cloud-Base-26-1.5.$*.qcow2 > > - > > -Fedora-Cloud-Base-27-1.6.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/27/CloudImages/$*/images/Fedora-Cloud-Base-27-1.6.$*.qcow2 > > - > > -Fedora-Cloud-Base-28-1.1.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/28/Cloud/$*/images/Fedora-Cloud-Base-28-1.1.$*.qcow2 > > - > > -Fedora-Cloud-Base-29-1.2.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/29/Cloud/$*/images/Fedora-Cloud-Base-29-1.2.$*.qcow2 > > - > > -Fedora-Cloud-Base-30-1.2.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/30/Cloud/$*/images/Fedora-Cloud-Base-30-1.2.$*.qcow2 > > - > > -Fedora-Cloud-Base-31-1.9.%.qcow2: > > - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedor= a/linux/releases/31/Cloud/$*/images/Fedora-Cloud-Base-31-1.9.$*.qcow2 > > - > > -Fedora-Cloud-Base-32-1.6.%.qcow2: > > - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedo= ra/linux/releases/32/Cloud/$*/images/Fedora-Cloud-Base-32-1.6.$*.qcow2 > > - > > -Fedora-Cloud-Base-33-1.2.%.qcow2: > > - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedo= ra/linux/releases/33/Cloud/$*/images/Fedora-Cloud-Base-33-1.2.$*.qcow2 > > - > > -Fedora-Cloud-Base-34-1.2.%.qcow2: > > - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedo= ra/linux/releases/34/Cloud/$*/images/Fedora-Cloud-Base-34-1.2.$*.qcow2 > > - > > -Fedora-Cloud-Base-35-1.2.%.qcow2: > > - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedo= ra/linux/releases/35/Cloud/$*/images/Fedora-Cloud-Base-35-1.2.$*.qcow2 > > - > > -# OpenSuSE downloads > > -openSUSE-Leap-15.1-JeOS.x86_64-kvm-and-xen.qcow2: > > - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.= 1/jeos/openSUSE-Leap-15.1-JeOS.x86_64-kvm-and-xen.qcow2 > > - > > -openSUSE-Leap-15.2-JeOS.x86_64-kvm-and-xen.qcow2: > > - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.= 2/appliances/openSUSE-Leap-15.2-JeOS.x86_64-kvm-and-xen.qcow2 > > - > > -openSUSE-Leap-15.3-JeOS.x86_64-kvm-and-xen.qcow2: > > - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.= 3/appliances/openSUSE-Leap-15.3-JeOS.x86_64-kvm-and-xen.qcow2 > > - > > -openSUSE-Tumbleweed-ARM-JeOS-efi.aarch64.raw.xz: > > - $(WGET) -O $@ http://download.opensuse.org/ports/aarch64/tumblewe= ed/appliances/openSUSE-Tumbleweed-ARM-JeOS-efi.aarch64.raw.xz > > - > > -openSUSE-Tumbleweed-ARM-JeOS-efi.armv7l.raw.xz: > > - $(WGET) -O $@ http://download.opensuse.org/ports/armv7hl/tumblewe= ed/appliances/openSUSE-Tumbleweed-ARM-JeOS-efi.armv7l.raw.xz > > - > > -# Ubuntu downloads > > -trusty-server-cloudimg-%-disk1.img: > > - $(WGET) -O $@ https://cloud-images.ubuntu.com/trusty/current/trus= ty-server-cloudimg-$*-disk1.img > > - > > -xenial-server-cloudimg-powerpc-disk1.img: > > - $(WGET) -O $@ https://cloud-images.ubuntu.com/xenial/current/xeni= al-server-cloudimg-powerpc-disk1.img > > - > > -jammy-server-cloudimg-s390x.img: > > - $(WGET) -O $@ https://cloud-images.ubuntu.com/jammy/current/jammy= -server-cloudimg-s390x.img > > -- > > 2.47.0 > > > > -- > David Gibson (he or they) | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you, not the other wa= y > | around. > http://www.ozlabs.org/~dgibson --=20 Thanks, Yumei Huang