From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Huk8+pSi; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 0A1A55A0619 for ; Mon, 27 Oct 2025 04:05:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761534325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MopSJijHrDA8xXvt7LnBN9GuztIVaMOpCVFS64PVZNM=; b=Huk8+pSiVJXuo6Ze/6PT5Kngak7+4/R62K2/opw4PzxtG/C9NDFLjS9KZ2VAmJ2P+5WN/u MGY3xd9Mv/j7c/RSYjMousIqBHtlSNvk4kZLNL1yZresGUgD3qo7G3U6hiXgM9hFB8WOCh JLPpq4pwlQMlIZIODFPkIgvZNNHMuYE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-sINcXT5sMMmoSHdNaRYFlA-1; Sun, 26 Oct 2025 23:05:23 -0400 X-MC-Unique: sINcXT5sMMmoSHdNaRYFlA-1 X-Mimecast-MFC-AGG-ID: sINcXT5sMMmoSHdNaRYFlA_1761534322 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-63c4999fa3dso377275a12.3 for ; Sun, 26 Oct 2025 20:05:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761534322; x=1762139122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MopSJijHrDA8xXvt7LnBN9GuztIVaMOpCVFS64PVZNM=; b=n/OY5wznruay6l/990z1Nnbl/CXdVVOjG8Sg2Y/aepgYYSHVRxPRtH5eHZob6FSW/R nZbmZKGDwjOzeqpetD3+odJKcBARpexrHtNr3+Kbxsr3p8eSNYFyiakJj91iJYoq8yt3 64gSFvejZtDYEpCp2AuZWLEColHQ+lnL1OmATl7mo46pCirIk5NtoQuDtkCZENszL9R2 +KtTHF9lSEyw4rAndt2+yqsOKl/eg18TmTp2j9pogj6F5Xv36f+nIGWfRW/clfQi8HwD ebuvEYTZzlnQ0cYk/4Z5O53mCWdNbn6c3z7zu9RGyibxE5qSoMkD3dI53hp0ncB0LyHv 3uvw== X-Forwarded-Encrypted: i=1; AJvYcCXqf38WLX61LzxwJ4ndtQIZjxEOYR9t8Cu5u5zurwfYdz9chU75fUQC35jN1qRldV0gjL1MYFDuzFk=@passt.top X-Gm-Message-State: AOJu0YzrgyTp4DfNC2bnSn6Wqd17zZ4KT0p1sgP63I76x+nHMJ0krJ4h RCMs/wi1MuD8kqvccWXUvP+ajUpJf6Hg2LlgtpPfbhJxvNsnZ3nKcj0lBWRDpoqzr1hVjq3IsMv xKDTmMoV7aVR9ufOEfdF3XEwuUuJgw/XEtkvSTbaOBDFQC5Rc/PESWad56H8Cs8vB43u0lmLnWJ JRCbYHmD79wC8rGcJZqQB5AYB5BDeb X-Gm-Gg: ASbGncuvoWzGbcYtnGTEEzHzPhrokWEZEQSBW1r5L3u+nlYLHk3N6y7O0rUKym6k3t/ QtEo9tHC6RPrLIVCKn9wFunbvGfKF21Pj2PWvT4I2ZBWWKjoItldjsL+5OU4htI6kTx9NhEmMWl hk2FUzmK/XYh12u6XsxO0f2w76ysdarHsH8SQK26DBQJWyPPN7j1UnP7OY X-Received: by 2002:a05:6402:5107:b0:629:e50c:b058 with SMTP id 4fb4d7f45d1cf-63c1f6c21a7mr35073410a12.28.1761534321914; Sun, 26 Oct 2025 20:05:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLTp8ZQ9rRGHr982KfC0JRHsnpItbwtNwBT4k/vf69/HGYMcezt21xdaKWkIm9X7xjhw5qUk2xNoBv5upg95E= X-Received: by 2002:a05:6402:5107:b0:629:e50c:b058 with SMTP id 4fb4d7f45d1cf-63c1f6c21a7mr35073394a12.28.1761534321300; Sun, 26 Oct 2025 20:05:21 -0700 (PDT) MIME-Version: 1.0 References: <20251022043054.12491-1-yuhuang@redhat.com> <20251023042754.6112f428@elisabeth> In-Reply-To: <20251023042754.6112f428@elisabeth> From: Yumei Huang Date: Mon, 27 Oct 2025 11:05:09 +0800 X-Gm-Features: AWmQ_bnkr7DDf0eaDs3hJbo8TejQRqlAXRI82Q8Seoo7VixHxIxQSwIA9RMAly8 Message-ID: Subject: Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LXMF7A5lbT5cGKacbaMPNmbzAjshKntZVeDlhM9FHXo_1761534322 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AXZJSTESEGVAIG4PTWOUQL4UEK3XO4WW X-Message-ID-Hash: AXZJSTESEGVAIG4PTWOUQL4UEK3XO4WW X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Oct 23, 2025 at 10:28=E2=80=AFAM Stefano Brivio wrote: > > On Thu, 23 Oct 2025 11:40:10 +1100 > David Gibson wrote: > > > On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote: > > > Also fix the copyright line. > > > > > > Suggested-by: Stefano Brivio > > > Signed-off-by: Yumei Huang > > > > Stefano, do we actually encourage that style for any "list of similar > > items"? Or just for local variable declarations? > > Just for local variable declarations, thanks for noticing. > > I was rather focusing on the fact (https://lwn.net/Articles/758552/) > that it's actually called "Reverse Christmas tree", not pyramid style. > > I can't find a convenient reference right now, maybe it's hidden > somewhere in https://lore.kernel.org/netdev/?q=3Dreverse+christmas+tree, > ...or maybe it's actually "documented" in checkpatch.pl? I found it in Documentation/process/maintainer-kvm-x86.rst as below: " Using reverse fir tree, a.k.a. reverse Christmas tree or reverse XMAS tree,= for variable declarations isn't strictly required, though it is still preferred= . " I will update the name and make it only for local variable declarations. Do I need to update the reference link as well? The name would be different from the current pyramids link (https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/). Not sure if it would be a little bit confusing if not. > > Or prehaps just trust us/me on that, sorry, I know it's not ideal :( > ...but I can absolutely guarantee it's called Reverse Christmas tree. > > -- > Stefano > --=20 Thanks, Yumei Huang