From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GITQBTsF; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 498D15A026F for ; Sun, 28 Sep 2025 03:40:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759023618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHAfMADea4AihUdgOwPh9eHSL+objPGJhU18PnU6Jew=; b=GITQBTsF9i809OMHccQd3ancr7F6M0klZy0ddUZbO483Wdmaoa+L6/Skdt80/timy2tFtN DkskERlN2kSpqMBlRjec2By2Y43TeEx2Xb92knh3F6l8rlJ9pZI35zaNIKd2XE3gcEVhiO szpkA0i7KJepdtMFMxiIrPBM4XAA/sQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-pKnWZZEGMg22--gGoTJIFQ-1; Sat, 27 Sep 2025 21:40:16 -0400 X-MC-Unique: pKnWZZEGMg22--gGoTJIFQ-1 X-Mimecast-MFC-AGG-ID: pKnWZZEGMg22--gGoTJIFQ_1759023615 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62fab44a479so2370215a12.0 for ; Sat, 27 Sep 2025 18:40:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759023615; x=1759628415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHAfMADea4AihUdgOwPh9eHSL+objPGJhU18PnU6Jew=; b=tbQwK7wsDiLf4Y2rjEu68syDseKAG0uJ015G6N8pJ2aqKojSe/GO1IN2HWja74x7rM Z3Jfbjqh2r4zMCZzTae9Sq1k2V7FLIOdwFBCRI+o96J/uTXyJ5LkCo758nqBhLGfWJxk YEXmJWZ5FZIMktJjKi7f/D3wDMIOfxX7onZVT9RMoqmuy+YNZqBzq17+XqtiBYPn1CSO j+S9KX5L+BSiTU6b7+wS/6zkuXDGGbexTaBg1UprAn3vuR8fRIDLGIQuH/6uqXLQ0hby uLHKMOZQgh8deOe1a2T6UQmsweWAjJQqWPWjVAkkGW4uWhSezsl4SQfrxz9rG4QPFWl+ rr2g== X-Forwarded-Encrypted: i=1; AJvYcCXqvDqiNLv5WHxtyApIbsjDOETq4SY6LTyRiodgDRuMwyaCPyPYYgG1b0YPsmAFcQinEw+yXisICAg=@passt.top X-Gm-Message-State: AOJu0YyuBI6xeMdkFmwW8ziOlfGoNGSQun6Uu7WbO0HFGkwLPVOG/+Hp GijGCpS+wEnyKyxCVi7Dsdp31TTslM2VO+JxWnt6W1tNmlloUBbB0mLrI+6u7DYglkHrWJ9+TdI VYFaXgnoODmsxYUTKFE8b7bw2iUzEL7sOnPd71+lwZWhN6fh9LbCQd80UuRtoTSGrxS4DpQu1lg kq1qkHuEfUHEXBuE70v/5sc4EHQYSF X-Gm-Gg: ASbGncuCwNsrDzcjl/vzw5L04dxps4UC+2ObMJ6drZ+Ef+KWoSObQCOe0cpXRoUIIJ2 KZCIGWASbzaPLcZ+1p0s0dDJtaZ287A7TiUuw0negvU5FWiso47F59haE+qKMsOxbXGRS9G/WGp JmWE+nyQB+IUL7k4tajuupLw== X-Received: by 2002:aa7:d604:0:b0:62e:de67:6543 with SMTP id 4fb4d7f45d1cf-6349f9cba2bmr7880122a12.4.1759023614855; Sat, 27 Sep 2025 18:40:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJXFxhkbwioQwpbPKwJfSkD7FgqM0tJqc8uL9alfvTpa82oY9mu67DOGPhq5RihzF+3eY18MLcOIo5WUVqeBY= X-Received: by 2002:aa7:d604:0:b0:62e:de67:6543 with SMTP id 4fb4d7f45d1cf-6349f9cba2bmr7880118a12.4.1759023614530; Sat, 27 Sep 2025 18:40:14 -0700 (PDT) MIME-Version: 1.0 References: <20250926061553.16039-1-yuhuang@redhat.com> <20250926143751.14a4d072@elisabeth> In-Reply-To: <20250926143751.14a4d072@elisabeth> From: Yumei Huang Date: Sun, 28 Sep 2025 09:40:03 +0800 X-Gm-Features: AS18NWBZv1Pp1G5WagqZ108mRsOe2tBy3tuvN5SpnGeamJGyShgIUVe3nqGbzBo Message-ID: Subject: Re: [PATCH] test: Update lib/term for clearer output when DEBUG is enabled To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LOuGEVPHFY0YLTXqYHiGGzazLlq_wGK2-xJzJsJlISM_1759023615 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RUD3NP6YN2D4Q4UKBYKKZKJVTZHSQG67 X-Message-ID-Hash: RUD3NP6YN2D4Q4UKBYKKZKJVTZHSQG67 X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Sep 26, 2025 at 8:38=E2=80=AFPM Stefano Brivio = wrote: > > On Fri, 26 Sep 2025 16:23:48 +1000 > David Gibson wrote: > > > On Fri, Sep 26, 2025 at 02:15:53PM +0800, Yumei Huang wrote: > > > When running tests with DEBUG=3D1, we used to get some > > > "DEBUG:DEBUG:DEBUG:" in logs, which is not very helpful for > > > debugging. > > > > > > With this patch, the log would show the steps like below: > > > > > > DEBUG: g1tools ip jq dhclient socat cat > > > DEBUG: htools ip jq > > > DEBUG: > > > DEBUG: set MAP_HOST4 192.0.2.1 > > > DEBUG: set MAP_HOST6 2001:db8:9a55::1 > > > > > > Suggested-by: David Gibson > > > Signed-off-by: Yumei Huang > > > > Reviewed-by: David Gibson > > > > Some extra background that might be useful in the commit message: > > > > > > The problem here is that "${@}" is magic and expands to multiple > > arguments, even though it's quoted. That means instead of the whole > > message going into a single string, the "DEBUG:" becomes the format > > string and the rest goes into unused parameters. > > Applied, with this addition to the commit message. Thank you for helping merge this so quickly. I just found this patch introduced a regression issue to some tests. Will fix it with a new patch. Sorry about that. > > -- > Stefano > --=20 Thanks, Yumei Huang