From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i8LpKrIU; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 6B74D5A0619 for ; Wed, 29 Oct 2025 06:12:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761714724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4tFMOjaeU0mQV73WaEH20GxIoBJFSYmlKnSPp//qVqg=; b=i8LpKrIUZemEokDFAypL4o3fYnGk4EjW7KyCeGO85n8/JexsZLcBKOtkRm000Sm6mXCIJo Ww5QKqzKWwHHJ/4L/t1srYEUEA0GaDTzxt0XOUa72IBn8/5mdru07KIhreQOxV92D0Pb9E H9O8p6Gvrrz+X8SzXU/2v9/kzOcZncI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-rh7MgzzHPMGyC2htSY_n6w-1; Wed, 29 Oct 2025 01:12:01 -0400 X-MC-Unique: rh7MgzzHPMGyC2htSY_n6w-1 X-Mimecast-MFC-AGG-ID: rh7MgzzHPMGyC2htSY_n6w_1761714720 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-63c074c62b6so9853882a12.3 for ; Tue, 28 Oct 2025 22:12:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761714720; x=1762319520; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4tFMOjaeU0mQV73WaEH20GxIoBJFSYmlKnSPp//qVqg=; b=RRf3JZX3gBwx886g97tGWyg+FbgA30c2PGb4+j/upWHWTnbA4kExRCqJ9O4Y5tgRzP Z6N4MjUF//PRX2vBP7ZZeBi1B0FLBLvDpfnhQLQNZowb8kZPLSv0AyB5rBWi/fCYDtQz hpoxHril/8GLS7JBds7IHv8agki18blfFwbtUJ3qPFEDl8RU5VFwRZ0Ew2Ff8qADor1P avoj3Z7LkGKncuzWdjyKSNWtpdt2bnoYGZePBER1zC6OrZ+cyxScwwLTVPFniJH/UxVQ SPu5MnNbtl20tkqmWsw1JUHlYRLrLkMBIZ4CZJGZSXOtK/JR3enbDulKMZHsc9kg3Xeh 2fIA== X-Gm-Message-State: AOJu0Yy7da6UaUUhYZL1GTxTF5wTyAdmgfHZ14dn/cYht2CsUQ3MELiC uNCvDG4Z3wqFibHauTn4yR6iSwOSHrqegYSqqeDSrFNJuYH3wi0/K9l8KWwalttDMSX07GMkp4U TfOUconEMrnqL6GPSnjW20klr3sn3PTIU2Une4RghjKURSxn2udeNjUg67PkNhsPzrg/tNYbkBa DKUEo7l0JZfjXr0P6aPxRe0ARrTJU2vbhd1c5fp4Y= X-Gm-Gg: ASbGncuU/trtOc6M3KsLVUBS1HjzcNbnGx8qO6DgZ5Ynf63mqgaP9ebCxnXTcc+Hxy2 8WzpT57UYdNgfkuEBzVL2VusgncVh+SOyyAcbmrHcWV0r7kwld5iNRlQKxbSrLqgol9ScVAdTuN CUdRGY5U07r9zTAiqBLwZKV6fbkIDZTkVsApv+cdkvhCIdWvlIHSQsM+T2 X-Received: by 2002:a05:6402:4415:b0:640:3210:6e48 with SMTP id 4fb4d7f45d1cf-640441aedf1mr1110224a12.4.1761714719962; Tue, 28 Oct 2025 22:11:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYidiwZ2tkpWBvUEzkA/zXntHlQbHVRAFF3hGvbZx9CSSMs+kkenP0TDGWjgLrhK/k3TBn5g0rkzoU5yJdbcY= X-Received: by 2002:a05:6402:4415:b0:640:3210:6e48 with SMTP id 4fb4d7f45d1cf-640441aedf1mr1110211a12.4.1761714719463; Tue, 28 Oct 2025 22:11:59 -0700 (PDT) MIME-Version: 1.0 References: <20251017062838.21041-1-yuhuang@redhat.com> <20251017062838.21041-5-yuhuang@redhat.com> <20251024010438.16e19757@elisabeth> <20251028124426.534fd236@elisabeth> <20251029053804.711716aa@elisabeth> In-Reply-To: <20251029053804.711716aa@elisabeth> From: Yumei Huang Date: Wed, 29 Oct 2025 13:11:48 +0800 X-Gm-Features: AWmQ_bmbd8GmmA2vszGDl4cZI7eZSg9kLJuIn1z2ntobUfPl1LIC5wDbGddTltE Message-ID: Subject: Re: [PATCH v6 4/4] tcp: Update data retransmission timeout To: Stefano Brivio X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TfknEfC1cBdx9dp_g5LWHidlR2K5oEO9TVMoLNsvyxA_1761714720 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BRUXN52IC7ISOWNFPOMI2QV7UP5QZYDI X-Message-ID-Hash: BRUXN52IC7ISOWNFPOMI2QV7UP5QZYDI X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Oct 29, 2025 at 12:38=E2=80=AFPM Stefano Brivio wrote: > > On Wed, 29 Oct 2025 11:06:44 +0800 > Yumei Huang wrote: > > > On Tue, Oct 28, 2025 at 7:44=E2=80=AFPM Stefano Brivio wrote: > > > > > > On Tue, 28 Oct 2025 16:09:03 +0800 > > > Yumei Huang wrote: > > > > > > > On Fri, Oct 24, 2025 at 7:04=E2=80=AFAM Stefano Brivio wrote: > > > > > > > > > > On Fri, 17 Oct 2025 14:28:38 +0800 > > > > > Yumei Huang wrote: > > > > > > > > > > > Use an exponential backoff timeout for data retransmission acco= rding > > > > > > to RFC 2988 and RFC 6298. Set the initial RTO to one second as = discussed > > > > > > in Appendix A of RFC 6298. > > > > > > > > > > > > Also combine the macros defining the initial RTO for both SYN a= nd ACK. > > > > > > > > > > > > Signed-off-by: Yumei Huang > > > > > > Reviewed-by: David Gibson > > > > > > --- > > > > > > tcp.c | 27 ++++++++++++--------------- > > > > > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > > > > > > > > > > diff --git a/tcp.c b/tcp.c > > > > > > index 9385132..dc0ec6c 100644 > > > > > > --- a/tcp.c > > > > > > +++ b/tcp.c > > > > > > @@ -179,16 +179,14 @@ > > > > > > * > > > > > > * Timeouts are implemented by means of timerfd timers, set ba= sed on flags: > > > > > > * > > > > > > - * - SYN_TIMEOUT_INIT: if no ACK is received from tap/guest du= ring handshake > > > > > > - * (flag ACK_FROM_TAP_DUE without ESTABLISHED event) within = this time, resend > > > > > > - * SYN. It's the starting timeout for the first SYN retry. I= f this persists > > > > > > - * for more than TCP_MAX_RETRIES or (tcp_syn_retries + > > > > > > - * tcp_syn_linear_timeouts) times in a row, reset the connec= tion > > > > > > - * > > > > > > - * - ACK_TIMEOUT: if no ACK segment was received from tap/gues= t, after sending > > > > > > - * data (flag ACK_FROM_TAP_DUE with ESTABLISHED event), re-s= end data from the > > > > > > - * socket and reset sequence to what was acknowledged. If th= is persists for > > > > > > - * more than TCP_MAX_RETRIES times in a row, reset the conne= ction > > > > > > + * - RTO_INIT: if no ACK segment was received from tap/guest, = either during > > > > > > + * handshake (flag ACK_FROM_TAP_DUE without ESTABLISHED even= t) or after > > > > > > + * sending data (flag ACK_FROM_TAP_DUE with ESTABLISHED even= t), re-send data > > > > > > + * from the socket and reset sequence to what was acknowledg= ed. This is the > > > > > > + * timeout for the first retry, in seconds. If this persists= too many times > > > > > > + * in a row, reset the connection: TCP_MAX_RETRIES for estab= lished > > > > > > + * connections, or (tcp_syn_retries + tcp_syn_linear_timeout= s) during the > > > > > > + * handshake. > > > > > > * > > > > > > * - FIN_TIMEOUT: if a FIN segment was sent to tap/guest (flag= ACK_FROM_TAP_DUE > > > > > > * with TAP_FIN_SENT event), and no ACK is received within t= his time, reset > > > > > > @@ -342,8 +340,7 @@ enum { > > > > > > #define WINDOW_DEFAULT 14600 /= * RFC 6928 */ > > > > > > > > > > > > #define ACK_INTERVAL 10 /* ms */ > > > > > > -#define SYN_TIMEOUT_INIT 1 /* s */ > > > > > > -#define ACK_TIMEOUT 2 > > > > > > +#define RTO_INIT 1 /* s, RFC= 6298 */ > > > > > > #define FIN_TIMEOUT 60 > > > > > > #define ACT_TIMEOUT 7200 > > > > > > > > > > > > @@ -588,13 +585,13 @@ static void tcp_timer_ctl(const struct ct= x *c, struct tcp_tap_conn *conn) > > > > > > } else if (conn->flags & ACK_FROM_TAP_DUE) { > > > > > > if (!(conn->events & ESTABLISHED)) { > > > > > > if (conn->retries < c->tcp.syn_linear_tim= eouts) > > > > > > - it.it_value.tv_sec =3D SYN_TIMEOU= T_INIT; > > > > > > + it.it_value.tv_sec =3D RTO_INIT; > > > > > > else > > > > > > - it.it_value.tv_sec =3D SYN_TIMEOU= T_INIT << > > > > > > + it.it_value.tv_sec =3D RTO_INIT <= < > > > > > > (conn->retries - c->tcp.s= yn_linear_timeouts); > > > > > > } > > > > > > else > > > > > > - it.it_value.tv_sec =3D ACK_TIMEOUT; > > > > > > + it.it_value.tv_sec =3D RTO_INIT << conn->= retries; > > > > > > > > > > Same as on 3/4, but here it's clearly more convenient: just assig= n > > > > > RTO_INIT, and multiply as needed in the if / else clauses. > > > > > > > > I guess we can't just assign RTO_INIT. Maybe assign it only when > > > > retries=3D=3D0, otherwise multiply as it.it_value.tv_sec <<=3D1. > > > > > > Why can't you do that? Say: > > > > > > it.it_value.tv_sec =3D RTO_INIT > > > if (!(conn->events & ESTABLISHED)) { > > > if (conn->retries >=3D c->tcp.syn_linear_timeouts) > > > it.it_value.tv_sec <<=3D (conn->retries - > > > c->tcp.syn_linear_tim= eouts); > > > > > > but anyway, see below. > > > > > > > But it seems more complicated. What do you think? > > > > > > Or maybe, building on my latest comment to 3/4: > > > > > > int factor =3D conn->retries; > > > > > > if (!(conn->events & ESTABLISHED)) > > > factor -=3D c->tcp.syn_linear_timeouts; > > > > > > it.it_value.tv_sec =3D RTO_INIT << MAX(factor, 0); > > > > > > ? > > > > Yeah, I understand this part now. > > > > > > > > > > > > > > > > } else if (CONN_HAS(conn, SOCK_FIN_SENT | TAP_FIN_ACKED))= { > > > > > > it.it_value.tv_sec =3D FIN_TIMEOUT; > > > > > > } else { > > > > > > > > > > The rest of the series looks good to me. > > > > > > > > > > It might be slightly more practical to factor in directly the RTO > > > > > clamp, and I don't think it's complicated now that you have the h= elper > > > > > from 2/4, but it's not a strong preference from my side, as the s= eries > > > > > makes sense in any case. > > > > > > > > Reading tcp_rto_max_ms can be easy with the helper. My concern is > > > > about the way we get the total time for retries. > > > > > > > > I used to do it like this in v2, > > > > https://archives.passt.top/passt-dev/20251010074700.22177-4-yuhuang= @redhat.com/: > > > > > > > > +#define RETRY_ELAPSED(timeout_init, retries) \ > > > > + ((timeout_init) * ((1 << ((retries) + 1)) - 2)) > > > > > > > > Though the formula is not quite right, we could refine it as below: > > > > > > > > #define RETRY_ELAPSED(retries) ((RTO_INIT) * ((1 << ((retries) + 1)= ) - 1)) > > > > > > > > Does it make sense to get the time this way? > > > > > > Well, it also depends on c->tcp.syn_linear_timeouts, right? > > > > Not really, it's only used for data retransmission, so > > syn_linear_timeouts is not relevant. > > Hmm, no, why? RFC 6298 covers SYN retries as well, and that's the one > stating: I meant RETRY_ELAPSED was only used for data retransmission, which uses exponential backoff timeout directly, so syn_linear_timeouts was not relevant. > > (2.5) A maximum value MAY be placed on RTO provided it is at least 60 > seconds. For SYN retries, as we used linear backoff + exponential backoff, and also limited by TCP_MAX_RETRIES, the possible max RTO is far less than 60s. So we didn't clamp it. Do you think we need to clamp it as well? > > ...the only thing that I don't see implemented in this version of the > patch is paragraph 5.7: > > (5.7) If the timer expires awaiting the ACK of a SYN segment and the > TCP implementation is using an RTO less than 3 seconds, the RTO > MUST be re-initialized to 3 seconds when data transmission > begins (i.e., after the three-way handshake completes). > > I missed that while reviewing earlier versions. I guess we need to use > a MAX(x, 3) clamp if (c->conn->events & ESTABLISHED). I think it's > simpler than re-introducing separate starting values (one second and > three seconds). I'm not sure I understand here. If the timer expires, didn't we reset the connection directly? We would never get to the data transmission phase? > > > Probably I should name it more clearly. > > > > > > > > But in any case, do you really need to calculate that explicitly? I w= as > > > thinking that you can just clamp the value when you use it in > > > tcp_timer_ctl(). > > > > > > If c->tcp.rto_max is DIV_ROUND_CLOSEST(x, 1000), where 'x' is the val= ue > > > you read from the kernel, then I guess it's just: > > > > > > --- > > > it.it_value.tv_sec =3D MIN(it.it_value.tv_sec, c->tcp= .rto_max); > > > > After reading the comments in v3 when tcp_rto_max_ms was first > > mentioned again, I realized I got something wrong again. I thought it > > was for the total timeout for all retries, so I need to calculate that > > and decide to reset the connection as in v2. > > I think it actually applies to all the retries. > > > Anyway, you are right. We don't need to do that. Thanks for your patien= ce. > > > > > } ... > > > > > > if (timerfd_settime(conn->timer, 0, &it, NULL)) > > > flow_perror(conn, "failed to set timer"); > > > --- > > -- > Stefano > --=20 Thanks, Yumei Huang