From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=kv18UYa4; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by passt.top (Postfix) with ESMTPS id 37A3D5A0262 for ; Wed, 12 Aug 2026 18:29:20 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-47fde295992so61231f8f.0 for ; Wed, 12 Aug 2026 09:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786552160; x=1787156960; darn=passt.top; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qnZvaIkswr2MrR8VXjUnuVnVVz2eFpbFqRtxi3uqrKk=; b=kv18UYa4C4PIEshMURiozxIDKySw8PFlupwRHEzk+nIqjEtELhEBI08WEFMD/FXGCI BRJkcjCr+cltNS2Wn6ZwqMgnp8bYtn1dkq7BrNWhxJNxDCJdfU7m3eYue9+tf/rV8G+W rwgxa+5FVa33OfFCu4t9ZnZ6A069nFGTPPJQYYeoLXTtfUQC4gCa+qGU9/1W4zC5OMlY tBxIC1hZZvJAj5m70aN2USTIJ7wdXEZVJohWyyZ62ptvIDheHq5HtS8pDVmYQhID/3Fc HVv/PtRhJs4O2gioZyKM0/TZUYRiQSKbn3KPLu1ydNvEA+ez24WiNuYkY2nmKwg7H9ZF 67HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786552160; x=1787156960; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qnZvaIkswr2MrR8VXjUnuVnVVz2eFpbFqRtxi3uqrKk=; b=OX543eQTPzxRffKH0ZOhaS6aP2puNwOlLAfR1aY3X39ik2jtJUY1W/JnoAPoxd1isa edP81/YVJOkgfMYmdQdQYZIuAK1Pe5cjp1g0oFfvCD+swhbA8xs7KSKKyun1mBJBOzwl JRnvO+b/Gbr09gB4A3PhQfrOBOG7tUdqlpvEby5kK5OjkdTK86/VsIH+6TAPzOHdg+XL HYbEy/QkLvZtfER2PVwfolOYO4Msm3Ix/2n3Agm/E8+kD9ABjLFVhMK2UQCblfvlBxsA o37jcOj13pgOdT7pwPYy9XVTvw5/6BIA+xjxOzeeusNf+ltTSEjIFm2wS5qXyyDz2mZS eEIA== X-Gm-Message-State: AOJu0YzTvPirwxkJXjbQlUIDbiXY0lYIZ1DAx1qo5Tx2uNAuVMq5cROC pVPodoScIlUGnA2scYSEmvHqAkcdO3IAeNffx7eH3LABjx8Efdm+ha6HgbSOkgje X-Gm-Gg: AR+sD102YB0w7QeCMgzPrjdf8hbCI2tHmFyBZcqDeGqHsPMapJJ6iRDISTjWTx6JiMf OUG4bCQFiIlcRbd8UcO+dVpOmyTTrhYyYIgcJA/lF0SbhwJQ57UDm7u1SLhW5OeGGdsadiHki/P rz/Ya7hyUKRm8lN7voPrpxrevW2NJe15k8Pr+/rBEdxtUizML4/KKpZ9v0pLlAAdlYSli4ryTTX ShdejlUAwehVgBxxZ+d384oa1Zku+Bxu/5Hc0dbxlO0qzwvKifBi9gLe1eNUTG3WMZVKjMPIczO yvHuGunnlZLB1ksVVEBCPLnEK/p8H99WopnFCHj53jKkpt+rhFAihnDqXbBeUDTuTlD/flhW6K+ uw9nj9gj9PU/8menMwZQNPqPt/Aafqw/t80MZOVUtQs0RXxCstYkwv58W7GdP6Fu3+RWnd8eFKf r2bVUT4IaGmYhIPKC9tX264akDEhadez2zHUKbqkofA1P5eOoU+UTF0wVtVMP0hMHta1pPSH4hJ L72ypkPjUKh3xoL6gupunLH3up9vIPkYfoNtT1LeSU= X-Received: by 2002:adf:e507:0:b0:47f:8cd3:4bed with SMTP id ffacd0b85a97d-48158d57a18mr720532f8f.5.1786552159524; Wed, 12 Aug 2026 09:29:19 -0700 (PDT) Received: from localhost ([196.157.64.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150c08920sm8060123f8f.15.2026.08.12.09.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 09:29:19 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Aug 2026 19:29:17 +0300 Message-Id: Subject: Re: [RFC v3 2/8] udp,tcp: Make protocol specific buffers public From: "Ammar Yasser" To: "David Gibson" , "Ammar Yasser" X-Mailer: aerc 0.21.0 References: <20260802132155.870796-1-aerosound161@gmail.com> <20260802132155.870796-3-aerosound161@gmail.com> In-Reply-To: Message-ID-Hash: RBJHMEDTX65WL225YJXE4FMZFB5TEY45 X-Message-ID-Hash: RBJHMEDTX65WL225YJXE4FMZFB5TEY45 X-MailFrom: aerosound161@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, eperezma@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Aug 7, 2026 at 8:56 AM EEST, David Gibson wrote: > On Sun, Aug 02, 2026 at 01:21:49PM +0000, Ammar Yasser wrote: >> Move the buffers used to split tcp and udp packets coming from the host >> from being static definitions in tcp_buf.c and udp.c to structs exported >> through extern on the their respective header files. >>=20 >> Also move the udp_meta_t definition to the public udp.h file instead of >> it living in udp_internal.h > > This commit message needs more of a rationale as to why this is a > desirable change. I presume it's because something later in the > series needs to access these variables and types, but this commit > message should summarise that for easier review. > > The content looks fine assuming the premise makes sense. Will ensure in the next revision