* [PATCH] udp: Fix signedness warning on 32-bits architectures
@ 2023-02-28 10:17 Stefano Brivio
2023-03-01 3:26 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2023-02-28 10:17 UTC (permalink / raw)
To: passt-dev; +Cc: David Gibson
When a ssize_t is an int:
udp.c: In function ‘udp_sock_handler’:
udp.c:774:23: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘ssize_t’ {aka ‘int’} [-Wsign-compare]
774 | for (i = 0; i < n; i += m) {
| ^
udp.c:781:43: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘ssize_t’ {aka ‘int’} [-Wsign-compare]
781 | for (m = 1; i + m < n; m++) {
|
Change 'i' and 'm' counters in udp_sock_handler() to signed versions,
to match ssize_t n.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/udp.c b/udp.c
index 20a9ea0..b7cbfdc 100644
--- a/udp.c
+++ b/udp.c
@@ -754,7 +754,7 @@ void udp_sock_handler(struct ctx *c, union epoll_ref ref, uint32_t events,
in_port_t dstport = ref.r.p.udp.udp.port;
bool v6 = ref.r.p.udp.udp.v6;
struct mmsghdr *mmh_recv;
- unsigned int i, m;
+ int i, m;
if (!(events & EPOLLIN))
return;
--
@@ -754,7 +754,7 @@ void udp_sock_handler(struct ctx *c, union epoll_ref ref, uint32_t events,
in_port_t dstport = ref.r.p.udp.udp.port;
bool v6 = ref.r.p.udp.udp.v6;
struct mmsghdr *mmh_recv;
- unsigned int i, m;
+ int i, m;
if (!(events & EPOLLIN))
return;
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] udp: Fix signedness warning on 32-bits architectures
2023-02-28 10:17 [PATCH] udp: Fix signedness warning on 32-bits architectures Stefano Brivio
@ 2023-03-01 3:26 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2023-03-01 3:26 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
On Tue, Feb 28, 2023 at 11:17:51AM +0100, Stefano Brivio wrote:
11;rgb:ffff/ffff/ffff> When a ssize_t is an int:
>
> udp.c: In function ‘udp_sock_handler’:
> udp.c:774:23: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘ssize_t’ {aka ‘int’} [-Wsign-compare]
> 774 | for (i = 0; i < n; i += m) {
> | ^
> udp.c:781:43: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘ssize_t’ {aka ‘int’} [-Wsign-compare]
> 781 | for (m = 1; i + m < n; m++) {
> |
>
> Change 'i' and 'm' counters in udp_sock_handler() to signed versions,
> to match ssize_t n.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/udp.c b/udp.c
> index 20a9ea0..b7cbfdc 100644
> --- a/udp.c
> +++ b/udp.c
> @@ -754,7 +754,7 @@ void udp_sock_handler(struct ctx *c, union epoll_ref ref, uint32_t events,
> in_port_t dstport = ref.r.p.udp.udp.port;
> bool v6 = ref.r.p.udp.udp.v6;
> struct mmsghdr *mmh_recv;
> - unsigned int i, m;
> + int i, m;
>
> if (!(events & EPOLLIN))
> return;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-01 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 10:17 [PATCH] udp: Fix signedness warning on 32-bits architectures Stefano Brivio
2023-03-01 3:26 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).