Re: [PATCH 1/5] qrap: Fix limits for PCI addresses

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

On Fri, Feb 24, 2023 at 07:49:45PM +0100, Andrea Bolognani wrote:
> The pci.0 bus on a pc machine has 32 slots.
> 
> For q35 machines, we don't expect devices to be plugged into
> pcie.0 directly, so technically we could have a very large
> number of slots by adding many pcie-root-ports, but even in
> this scenario 32 is a reasonable number.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  qrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qrap.c b/qrap.c
> index 287198e..2443fa3 100644
> --- a/qrap.c
> +++ b/qrap.c
> @@ -89,13 +89,13 @@ static const struct pci_dev {
>  		"pc-q35", "virtio-net-pci",
>  		"bus=pci.", ",addr=0x0",
>  		"\"bus\":\"pci.", ",\"addr\":\"0x0\"",
> -		3, /* 2: hotplug bus */ 16
> +		3, /* 2: hotplug bus */ 31
>  	},
>  	{
>  		"pc-", "virtio-net-pci",
>  		"bus=pci.0,addr=0x", "",
>  		"\"bus\":\"pci.0\",\"addr=0x", "",
> -		2, /* 1: ISA bridge */ 16
> +		2, /* 1: ISA bridge */ 31
>  	},
>  	{
>  		"s390-ccw", "virtio-net-ccw",

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]