From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id E24B85A0082 for ; Mon, 27 Feb 2023 01:00:40 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PQ0xx313Jz4x8x; Mon, 27 Feb 2023 11:00:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1677456037; bh=2D48rrWw6FZ5AOyxAe8bX8R+9v3+rV/UMOs1JH4Eq8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hZjYiloWNswMaveTNAvEgX2nPy4gwb/qaBiZaCsvBKNdpleXzr7s4BbjVb/m5OcE/ ILgEQrOJIN0siv6tAqlisqvWYsISfOULPYJxKYhqMOZRzvw/f4xXI3uQIn51uNq1ZF IKvW3OowzWK9PqhrMWm2edGYBkRzDmH3oMVXVMZY= Date: Mon, 27 Feb 2023 10:54:23 +1100 From: David Gibson To: Andrea Bolognani Subject: Re: [PATCH 1/5] qrap: Fix limits for PCI addresses Message-ID: References: <20230224184949.518615-1-abologna@redhat.com> <20230224184949.518615-2-abologna@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pICto1cKrDp+qW9K" Content-Disposition: inline In-Reply-To: <20230224184949.518615-2-abologna@redhat.com> Message-ID-Hash: ZCS2VUOBNZCBDXP4JVEJY4HLF33XNRI6 X-Message-ID-Hash: ZCS2VUOBNZCBDXP4JVEJY4HLF33XNRI6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --pICto1cKrDp+qW9K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 07:49:45PM +0100, Andrea Bolognani wrote: > The pci.0 bus on a pc machine has 32 slots. >=20 > For q35 machines, we don't expect devices to be plugged into > pcie.0 directly, so technically we could have a very large > number of slots by adding many pcie-root-ports, but even in > this scenario 32 is a reasonable number. >=20 > Signed-off-by: Andrea Bolognani Reviewed-by: David Gibson > --- > qrap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/qrap.c b/qrap.c > index 287198e..2443fa3 100644 > --- a/qrap.c > +++ b/qrap.c > @@ -89,13 +89,13 @@ static const struct pci_dev { > "pc-q35", "virtio-net-pci", > "bus=3Dpci.", ",addr=3D0x0", > "\"bus\":\"pci.", ",\"addr\":\"0x0\"", > - 3, /* 2: hotplug bus */ 16 > + 3, /* 2: hotplug bus */ 31 > }, > { > "pc-", "virtio-net-pci", > "bus=3Dpci.0,addr=3D0x", "", > "\"bus\":\"pci.0\",\"addr=3D0x", "", > - 2, /* 1: ISA bridge */ 16 > + 2, /* 1: ISA bridge */ 31 > }, > { > "s390-ccw", "virtio-net-ccw", --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --pICto1cKrDp+qW9K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmP78RkACgkQzQJF27ox 2Gfe/A/9El5fZMgNKK46X9q11DRU62fZu20EWwpFVDPwwJRKcLnQK/tvcGCEySFr Tx742pi82sIBaIFf2BypdX+7ox7IPwirTShDqZCaVrxk2Cp0+GWy9cmh1wgl4c8O DhdcsPerDRLf2eTL+6XW/XD7PngIaeCjhkRk3qneM0VA14m3kNLrnahEo+eZYqIT Vjfyhu4lCvj+jPAR4YbvFHFJwv2zXUGy7PpLEZ/b7wqqe6sMsPUfO9g5vU4WlChD 1n0cL46aePamtJdhFrhTrrICOZxPX4stEm9gOAIU0zTy0C6TJBmgm8ANadewbMyl +63PGD+KLFsLsFtuqy1F9V/aVsqXZ195Ht3gQ44qiYHWHmj5jR52czf2aQBvi2lw XGhOCwo5nqpSROCTj2uq8vCWSn9xpdqBVrb2HRl8zMA9x2hPndQD5HgUTjk+D1QZ LJvDgxVseQlW0oTCPSIYdAPYFgVYhEkIfGQI6xnHjubUrdG5OtFirdSx0qBfWIlK 96QDsbfvFuE30jHaf2vrdb/NJHY0btPvD1eHVSc6RFHZUhqoW++W6aiSi6f2VItt YDXBACgSn7CyGlXgeGP/LzKWSsxo3QhOmCYNZl3V9rkucDQ9cpWXdZ1Fdl8NdusV GcT1mUWX8a0czFTecA0zRPeAqYmiZyRhUIWO8U42KdMBiJXNT2E= =b7Av -----END PGP SIGNATURE----- --pICto1cKrDp+qW9K--