From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2ED765A026B for ; Mon, 27 Feb 2023 01:00:41 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PQ0xx3BwKz4x8y; Mon, 27 Feb 2023 11:00:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1677456037; bh=yht0CTgJ/rmRrxDoF4PNtYb/pqwmHJwkDu14Vjs8Cog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NcwnzLfdF1+6IGteb/3DdEONAApXxEM0pKLZCEH5WaqlGvKfnmKIJOuNDDyMB2ojW SDigJUbtSlQzO+ovu7bic+BN5zznMr0trSCGapcnKlD9pBLJSo+YbK55LpjRYD/v/q twl6QaPzOcyMMx8wp4t0VNpO5gl2jnD/SPthf2i4= Date: Mon, 27 Feb 2023 10:55:20 +1100 From: David Gibson To: Andrea Bolognani Subject: Re: [PATCH 2/5] qrap: Fix support for pc machines Message-ID: References: <20230224184949.518615-1-abologna@redhat.com> <20230224184949.518615-3-abologna@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PIWYRpokw0yDS7eu" Content-Disposition: inline In-Reply-To: <20230224184949.518615-3-abologna@redhat.com> Message-ID-Hash: PEMTI4I32IKA65VRZ4BL4CO3RSPCOXDP X-Message-ID-Hash: PEMTI4I32IKA65VRZ4BL4CO3RSPCOXDP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --PIWYRpokw0yDS7eu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 07:49:46PM +0100, Andrea Bolognani wrote: > The JSON version of the template is incorrect, making qrap > completely unusable when JSON arguments are used together > with the pc machine type. >=20 > Fixes: b944ca185587 ("qrap: Support JSON syntax for -device") > Signed-off-by: Andrea Bolognani Reviewed-by: David Gibson > --- > qrap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qrap.c b/qrap.c > index 2443fa3..5c18cec 100644 > --- a/qrap.c > +++ b/qrap.c > @@ -94,7 +94,7 @@ static const struct pci_dev { > { > "pc-", "virtio-net-pci", > "bus=3Dpci.0,addr=3D0x", "", > - "\"bus\":\"pci.0\",\"addr=3D0x", "", > + "\"bus\":\"pci.0\",\"addr\":\"0x", "", > 2, /* 1: ISA bridge */ 31 > }, > { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --PIWYRpokw0yDS7eu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmP78WEACgkQzQJF27ox 2GeMlg/+KC+Q6F1LBCOk76lpA9vXiOwJEFamNx6laSFNhTCPZHdlBSOuHm/qk29C Hv/EZh8ArT11XH/JrHAENF0TSgyfvOOfB8jU2WnFZmQCihX8DPKKKhLUjhyUk03g 8E1wG5iGadbqu2mdMEhnGOuTJL4REzNmpJT7Yyo31g4Gg2MLTmH2qNwa3VfHg9pE a0hXNFP87/K/T7GCg32teWb2cDBEweQZp5KYdSpI7PmBwg2lWktLSWoIVamferbM uvQlKFTqk2T3XBrhhA1aS1F5oZhOZCbE0CxJlrPgqGYo/Rvc26jCGtY2iwXkJYgU Pbv2w6Zryn/2pt/T6qHx7Tp4HberJJpaJGKa6Da7ouUfrLlx/Nj/0qSn679n4txj JISAhLCPNMz5Z71Y5M/1W/9GYgO6hZdmNJ9n6Fwm4aETOBJ7PuyOPxOicSlatT+c KTFPU5q5AeglEAjkpVm1LJ/B9w6Ohl+ArAhy341Mb74Gj0t+kgOtw6H4vaoeQjBW M0+wnkwF5kqEGHndtZqGe3M3npz+GFzO/gwi3wj/h9cxi74RijUb4jsPPI3ItXYV FFDsvvfKoZs2tGi8Jx2Z5XogR9Na5TPW+p7XKe+8l+W91Bo/VT+D9EV/vJtPVitn sDJ9LjxankSRDNaE0kpsF/7XOEA6YBcCp3ZQR8LSrmlXcfwH2aU= =xHbD -----END PGP SIGNATURE----- --PIWYRpokw0yDS7eu--