Re: [PATCH 3/5] qrap: Drop args in JSON format

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

On Fri, Feb 24, 2023 at 07:49:47PM +0100, Andrea Bolognani wrote:
> When JSON support was introduced, the drop_args array has
> not been updated accordingly.
> 
> Fixes: b944ca185587 ("qrap: Support JSON syntax for -device")
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Oof, drop_args is such a hack.  But I guess all of qrap is.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  qrap.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/qrap.c b/qrap.c
> index 5c18cec..3077944 100644
> --- a/qrap.c
> +++ b/qrap.c
> @@ -57,10 +57,15 @@ static const struct drop_arg {
>  	{ "-netdev",	NULL },
>  	{ "-net",	NULL },
>  	{ "-device",	"virtio-net-pci," },
> +	{ "-device",	"{\"driver\":\"virtio-net-pci\"," },
>  	{ "-device",	"virtio-net-ccw," },
> +	{ "-device",	"{\"driver\":\"virtio-net-ccw\"," },
>  	{ "-device",	"e1000," },
> +	{ "-device",	"{\"driver\":\"e1000\"," },
>  	{ "-device",	"e1000e," },
> +	{ "-device",	"{\"driver\":\"e1000e\"," },
>  	{ "-device",	"rtl8139," },
> +	{ "-device",	"{\"driver\":\"rtl8139\"," },
>  	{ 0 },
>  };
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]