From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 175CB5A0272 for ; Mon, 27 Feb 2023 01:00:43 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PQ0xx3Kkjz4x90; Mon, 27 Feb 2023 11:00:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1677456037; bh=Dys8Ehf08I4RJDpOkOvbEvV6qG42TuU2XCby9z5R2GY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O1P8edk5w9YVjOKZ8Rut1QqqpbQs3NVeeUnGdb1AVBJ74x9AeNdRO4irmleR+Unr7 oSx0oUjAVyudGGudxqC5OR8B1MtiTIF90zBRFhvZBfYW7ed7sqFS0yGwLLYWXSTw5F T1YmQ2SaAwqaQZeKYl4razYEY3kUAMQkU/jqrfyw= Date: Mon, 27 Feb 2023 10:56:19 +1100 From: David Gibson To: Andrea Bolognani Subject: Re: [PATCH 3/5] qrap: Drop args in JSON format Message-ID: References: <20230224184949.518615-1-abologna@redhat.com> <20230224184949.518615-4-abologna@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F4DDzZAimFZUWfwB" Content-Disposition: inline In-Reply-To: <20230224184949.518615-4-abologna@redhat.com> Message-ID-Hash: UGWUXKOVGN2LI4OJ5CEYTOKRZBN3XYHI X-Message-ID-Hash: UGWUXKOVGN2LI4OJ5CEYTOKRZBN3XYHI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --F4DDzZAimFZUWfwB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 07:49:47PM +0100, Andrea Bolognani wrote: > When JSON support was introduced, the drop_args array has > not been updated accordingly. >=20 > Fixes: b944ca185587 ("qrap: Support JSON syntax for -device") > Signed-off-by: Andrea Bolognani Oof, drop_args is such a hack. But I guess all of qrap is. Reviewed-by: David Gibson > --- > qrap.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/qrap.c b/qrap.c > index 5c18cec..3077944 100644 > --- a/qrap.c > +++ b/qrap.c > @@ -57,10 +57,15 @@ static const struct drop_arg { > { "-netdev", NULL }, > { "-net", NULL }, > { "-device", "virtio-net-pci," }, > + { "-device", "{\"driver\":\"virtio-net-pci\"," }, > { "-device", "virtio-net-ccw," }, > + { "-device", "{\"driver\":\"virtio-net-ccw\"," }, > { "-device", "e1000," }, > + { "-device", "{\"driver\":\"e1000\"," }, > { "-device", "e1000e," }, > + { "-device", "{\"driver\":\"e1000e\"," }, > { "-device", "rtl8139," }, > + { "-device", "{\"driver\":\"rtl8139\"," }, > { 0 }, > }; > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --F4DDzZAimFZUWfwB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmP78Z0ACgkQzQJF27ox 2GeOXg//ac+jc3hQNCNSrncOOcgYc5d8AsxI6OsccWJ9KjbVQt4wvBJcGRvJcwN1 Sok7b9K4mBZEkPB0QTWKECTxnhbYxA/EJbuHRGZBY03NDIFv96SCHNlDqIyB4meI JpqiaBoZsj/Thk0v0d3duZuSj++W4P2ph/lOEPG0uPTehnizpYlGAyB7t5WtAX8H YpX08VSWbzBDy9zgn7yul+j9d6EE5VJWzu3lc9cR+aXDRqXnJgMPnUKsumBZO3MZ E+ZiBVxsqRkXnlnUCOl87FGQQiRV7xkeuZ8p6/aA0NfSIykPZ2i3JOV8rs3GS0Gv Kf8qLtsJb7RQGOaQCYH7wUw6ugJPqXDiEnUhv3dLjF78DVDi5ek1LhXx4+4UrtdZ 6zr6iTBUfwRAi4K9gqn84x31bj40pMFVkrYgplyomiCZz93eCYofF5DQ7hiAMXsx HWn44Mmb7ii41fxd0PY3RYr0MtexX9f3J2pk0ftXTXQJyUSS6pzgtfCfL1NLy4Dp lmN2NiPL/frSqpnB5L6FPrrC4WkknUjCuebGPMKpEh/zC0mRQGy+/NrrkZaU7JQD +I0/eK9480Ryf2ZWIdgrNhbpU1213PLYUVyBRkEzhpIYuNAk7/P9aSlA4rQtAbKo EEgzBEkzfaVWJ7Xg0eFyI3P5bI96fPUQuuo4hQMGSE8fv268V4E= =HLTT -----END PGP SIGNATURE----- --F4DDzZAimFZUWfwB--