On Wed, Feb 15, 2023 at 03:24:31AM -0500, Laine Stump wrote: > Nearly all of the calls to usage() in conf() occur immediately after > logging a more detailed error message, and the fact that these errors > are occuring indicates that the user has already seen the passt usage > message (or read the manpage). Spamming the logfile with the complete > contents of the usage message serves only to obscure the more detailed > error message. The only time when the full usage message should be output > is if the user explicitly asks for it with -h (or its synonyms) > > As a start to eliminating the excessive calls to usage(), this patch > replaces most calls to err() followed by usage() with a call to die() > instead. A few other usage() calls remain, but their removal involves > bit more nuance that should be properly explained in separate commit > messages. > > Signed-off-by: Laine Stump Reviewed-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson