From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 7F23D5A026B for ; Fri, 17 Feb 2023 01:43:42 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PHtN84sjxz4x87; Fri, 17 Feb 2023 11:43:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1676594616; bh=9nHiZJRuZT52sfNIbI4oEhXlVSTxkIHycul9XJeXSsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=flkhGjuJXCrh/320VPv8O7kj0Jc1MqsY9mM8VM9u7PKpMAETarNx1+Ig2bG3r7ToS du1cOciJa3KWPOJI8aDQk1uRxdp2BNMAWRhlpR7JGd5Kd2w2LKg6iGPzUrMQzrk0e8 mMZYPSqNScsLKWyMM+G5+SX+drCdhEQeoOg3Qm48= Date: Fri, 17 Feb 2023 09:55:59 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 0/4] Some cleanups to tap and tcp Message-ID: References: <20230216054311.2131853-1-david@gibson.dropbear.id.au> <20230216232207.198224bb@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4J05pmST9MTBcFeT" Content-Disposition: inline In-Reply-To: <20230216232207.198224bb@elisabeth> Message-ID-Hash: MRX2ILBKN5ZA46R6JYAMDPIO2ACE4KOT X-Message-ID-Hash: MRX2ILBKN5ZA46R6JYAMDPIO2ACE4KOT X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --4J05pmST9MTBcFeT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 16, 2023 at 11:22:07PM +0100, Stefano Brivio wrote: > On Thu, 16 Feb 2023 16:43:07 +1100 > David Gibson wrote: >=20 > > This is a handful of simple cleanups which I made while investigating > > https://bugs.passt.top/show_bug.cgi?id=3D41. Note that these don't > > themselves actually address that bug, they're just unrelated cleanups > > that happen to be in adjacent code. > >=20 > > I've run basic tests on these, but not quite the complete test suite: > > I haven't yet had a chance to debug an unrelated problem with the IPv4 > > performance tests failing. > >=20 > > Changes since v1: > > * Minor comment and style fixes > >=20 > > David Gibson (4): > > tap: Don't pcap frames that didn't get sent > > tap: Eliminate goto from tap_handler() > > tcp: Remove 'recvmsg' goto from tcp_data_from_sock > > tcp: Remove 'zero_len' goto from tcp_data_from_sock >=20 > Applied. Hmm.. I'm not seeing them in the tree yet.. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --4J05pmST9MTBcFeT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmPutHkACgkQzQJF27ox 2Gcdlw/9GWsgIvG15slr1BquBh7HCkRAVxFPpDWtuCirfAK6LsOvfgYFxvWzp842 zs2E51O+RxyzpqG38RUsfzYudiY9NMG7X+9CKcTAE7IYV570Fikv3b9AMSIylkJJ kkg93nVY/4AcKYfSfWp8NNRz+hlJkFlWBBxfdUp5O1nBS8ETUkYg25IisrraCfSY vMCxN4sqVyB7jd8yJgXP9Q51CEVsUz3zFyKdVvI1U97qluqQhmmz1TTJiq6MZ6hd YAhHKs2KRrOgioonLvIFIVVSVnXF7IiR1yROH5/vmy8z6VzyML1rhPj3dAW/G0WU yegnmP2ZWiJ8db+cQC29glGhKIyMwEHjVPj9Dkq2UtirmhI+g+RfwycUNHAeGKuF I0Hsr5sNc4L9IPZnaleIGCICgpwLGxCQpl6opwl7e80a6IlDpKqWbQdu6k3wma+n sVehbXiKGjlXaOdPV18p9i8rm1mFixvhlqEJgff40peZxIY2xm84q+C7LYXHsLxS lvvBOhXqOBTLNQHEg3VVgn7UucRKttKgK8J1wX3VvGFVwcqxZakFPAyAH1BbNifP h5PenJxrKTphLt5F8h541wtzjSNWtnidaqNhYWEUX0X2IyhYDHmSqwjA49dc/f0m 5VmdiciNvFAyoQDq1hyQZZLVbsDoa72Y40FwYuXL2568keEhaKI= =X/o0 -----END PGP SIGNATURE----- --4J05pmST9MTBcFeT--