Re: [PATCH v2 3/5] qemu_passt: Make passt report errors to stderr whenever possible

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Thu, Feb 16, 2023 at 05:21:48PM +0100, Michal Prívozník wrote:
> On 2/16/23 16:42, Jonathon Jongsma wrote:
> > On 2/16/23 7:32 AM, Michal Privoznik wrote:
> >> Passt has '--stderr' argument which makes it report error onto
> >> stderr rather to system log. Unfortunately, it's currently
> >> impossible to use both '--log-file' and '--stderr', so pass the
> >> latter only if the former isn't passed. Then, use the stderr to
> >> produce more user friendly error message on failed start.
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> >> ---
> >>   src/qemu/qemu_passt.c | 22 +++++++++++++++++++---
> >>   1 file changed, 19 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c
> >> index c082c149cd..881205449b 100644
> >> --- a/src/qemu/qemu_passt.c
> >> +++ b/src/qemu/qemu_passt.c
> >> @@ -171,8 +171,13 @@ qemuPasstStart(virDomainObj *vm,
> >>       if (net->sourceDev)
> >>           virCommandAddArgList(cmd, "--interface", net->sourceDev, NULL);
> >>   -    if (net->backend.logFile)
> >> +    if (net->backend.logFile) {
> >>           virCommandAddArgList(cmd, "--log-file",
> >> net->backend.logFile, NULL);
> >> +    } else {
> >> +        /* By default, passt logs into system logger. But we are
> >> interested
> >> +         * into errors too. Make it print errors onto stderr. */
> > 
> > s/into/in the/ ?
> 
> Honestly, I have no idea. I'm not a native speaker.

I am, and "in the" definitely seems more correct here.

> Maybe it's 'print
> onto paper' but 'print into a stream'?

Fwiw, s/onto/to/ also reads slightly better.

> 
> Anyway, fixed locally. Thanks.
> 
> Michal
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]