From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])
	by passt.top (Postfix) with ESMTPS id 666B05A0082
	for <passt-dev@passt.top>; Wed, 15 Feb 2023 02:09:20 +0100 (CET)
Received: by gandalf.ozlabs.org (Postfix, from userid 1007)
	id 4PGg2h3D0Hz4x7W; Wed, 15 Feb 2023 12:09:16 +1100 (AEDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gibson.dropbear.id.au; s=201602; t=1676423356;
	bh=Gm1mZG1cFO++BEUypVBKkCwYpYG8nwYhFpdY9ZhIZMc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=JMewlQAxFVBBeFc1+UgQn8DrFcf5d4tFDeDSKMWE5LURAZB4zg1/Nl9mnjqFu1yDi
	 HyB1C4CUN/MhluBuFq7Y7Uio2/Fxa6NB1w83d7YXr5GNuVSwzA6X5NeOq2NyWcUEOh
	 8G03IA1eZNmD3Os7aAlRiOtc9zATc6VVStjFuRnM=
Date: Wed, 15 Feb 2023 10:53:39 +1100
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH] Makefile: Explict int type in FALLOC_FL_COLLAPSE_RANGE
 probe
Message-ID: <Y+wfA8+6ouJT0HUK@yekko>
References: <20230214163005.2099650-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="7D1jsY6b0sS+viF+"
Content-Disposition: inline
In-Reply-To: <20230214163005.2099650-1-sbrivio@redhat.com>
Message-ID-Hash: TNIBXJ4H3MAXZLTXOKAJNIXNHX2QDOBW
X-Message-ID-Hash: TNIBXJ4H3MAXZLTXOKAJNIXNHX2QDOBW
X-MailFrom: dgibson@gandalf.ozlabs.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top, Florian Weimer <fweimer@redhat.com>
X-Mailman-Version: 3.3.3
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/Y+wfA8+6ouJT0HUK@yekko/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/TNIBXJ4H3MAXZLTXOKAJNIXNHX2QDOBW/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>


--7D1jsY6b0sS+viF+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 14, 2023 at 05:30:05PM +0100, Stefano Brivio wrote:
> From: Florian Weimer <fweimer@redhat.com>
>=20
> Future compilers will not support implicit ints by default, causing
> the probe to always fail.
>=20
> Link: https://bugs.passt.top/show_bug.cgi?id=3D42
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
> I'm just posting Florian's patch here for ease of review -- I just applie=
d this
> by the way. Thanks Florian for the report and for the patch!
>=20
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Makefile b/Makefile
> index dd222a8..080c748 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -101,7 +101,7 @@ ifeq ($(shell :|$(CC) -fstack-protector-strong -S -xc=
 - -o - >/dev/null 2>&1; ec
>  	FLAGS +=3D -fstack-protector-strong
>  endif
> =20
> -C :=3D \#define _GNU_SOURCE\n\#include <fcntl.h>\nx =3D FALLOC_FL_COLLAP=
SE_RANGE;
> +C :=3D \#define _GNU_SOURCE\n\#include <fcntl.h>\nint x =3D FALLOC_FL_CO=
LLAPSE_RANGE;
>  ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo =
$$?),0)
>  	EXTRA_SYSCALLS +=3D fallocate
>  endif

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--7D1jsY6b0sS+viF+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmPsHugACgkQzQJF27ox
2Ge++A/+IgMBQAOFDovvT0nFDemclznIa3pV9SJoY/Fe3IttDFLH4Vg128jX+fYV
2iIEid/vKDEH93zeRErFtisA9IKcjCWWQ2odLSpnA4XD/DB9ZEMKZt7iKxNucZc6
jAfUf59kaggY5HyEXBh7oXs1X7in7GT9k7NXCh7B7xQnjPJtSD+KWsep/MguhqfP
0ss0DRo3F2Owb+1khONzZ73v7qdtZKhzLlQ7y/bikxvFRi6tTftcCp8dZ17YJ850
5ieivU8uWUU/SH8TdulkzSnnOEA47M+16ITnyoH4Cq62zma6AqRjkFMRoExafndh
xHWAynk82kokpnkNWkmpZJgSiDCWWg7VBP8aQb8wnjIZTDsyZae5nkAC4WHN2NpC
bfWJRVZ2evCGvr+fAVgIrAwJNATqnu35gxfO9KVYbgkhAJjYlTcwtmCgRk/877j7
3p6Xbep7AF7DJI48/P2XCEWcvd42a+7BXaDPsgBjS/JVz/yhsoIdyaITvrlQHf9H
WN4PnkTi3gW5gYEoSNMm/qHaSJutoNlUnTsIpFSH8ehXYTVzm9t3xTM9/M2YB4t5
ZT6sd2qeMrHHtcCzzXXqBJI45Ics3ROlBHPXkp5m6DB6IXji8CQi8Qw3zxEN3ND+
r7BxlREHKQluYsEmAfaB6Ip1fzyZ1wbWTbQ6N4ngWX5XFPINFEk=
=1iN0
-----END PGP SIGNATURE-----

--7D1jsY6b0sS+viF+--