From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 08/14] tap: Remove unhelpeful vnet_pre optimization from tap_send()
Date: Tue, 18 Oct 2022 23:07:29 +1100 [thread overview]
Message-ID: <Y06XAUZLCitWSEb1@yekko> (raw)
In-Reply-To: <20221018050513.04fae95b@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
On Tue, Oct 18, 2022 at 05:05:13AM +0200, Stefano Brivio wrote:
> On Mon, 17 Oct 2022 19:58:01 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > Callers of tap_send() can optionally use a small optimization by adding
> > extra space for the 4 byte length header used on the qemu socket interface.
> > tap_ip_send() is currently the only user of this, but this is used only
> > for "slow path" ICMP and DHCP packets, so there's not a lot of value to
> > the optimization.
>
> Not anymore, definitely. It used to look quite bad in perf(1) when I
> shuffled connection data around.
Yeah. In any case I think I can get an equivalent optimization back
at some point.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-18 12:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 8:57 [PATCH 00/14] Clean up checksum and header generation for inbound packets David Gibson
2022-10-17 8:57 ` [PATCH 01/14] Add csum_icmp6() helper for calculating ICMPv6 checksums David Gibson
2022-10-18 3:01 ` Stefano Brivio
2022-10-18 12:05 ` David Gibson
2022-10-17 8:57 ` [PATCH 02/14] Add csum_icmp4() helper for calculating ICMPv4 checksums David Gibson
2022-10-18 3:01 ` Stefano Brivio
2022-10-18 12:06 ` David Gibson
2022-10-18 12:28 ` Stefano Brivio
2022-10-17 8:57 ` [PATCH 03/14] Add csum_udp6() helper for calculating UDP over IPv6 checksums David Gibson
2022-10-18 3:02 ` Stefano Brivio
2022-10-18 12:06 ` David Gibson
2022-10-17 8:57 ` [PATCH 04/14] Add csum_udp4() helper for calculating UDP over IPv4 checksums David Gibson
2022-10-18 3:03 ` Stefano Brivio
2022-10-18 12:06 ` David Gibson
2022-10-17 8:57 ` [PATCH 05/14] Add csum_ip4_header() helper to calculate IPv4 header checksums David Gibson
2022-10-18 3:03 ` Stefano Brivio
2022-10-18 12:07 ` David Gibson
2022-10-17 8:57 ` [PATCH 06/14] Add helpers for normal inbound packet destination addresses David Gibson
2022-10-18 3:04 ` Stefano Brivio
2022-10-18 12:07 ` David Gibson
2022-10-17 8:58 ` [PATCH 07/14] Remove support for TCP packets from tap_ip_send() David Gibson
2022-10-17 8:58 ` [PATCH 08/14] tap: Remove unhelpeful vnet_pre optimization from tap_send() David Gibson
2022-10-18 3:05 ` Stefano Brivio
2022-10-18 12:07 ` David Gibson [this message]
2022-10-17 8:58 ` [PATCH 09/14] Split tap_ip_send() into IPv4 and IPv6 specific functions David Gibson
2022-10-18 3:06 ` Stefano Brivio
2022-10-18 12:07 ` David Gibson
2022-10-17 8:58 ` [PATCH 10/14] tap: Split tap_ip6_send() into UDP and ICMP variants David Gibson
2022-10-17 8:58 ` [PATCH 11/14] ndp: Remove unneeded eh_source parameter David Gibson
2022-10-17 8:58 ` [PATCH 12/14] ndp: Use tap_icmp6_send() helper David Gibson
2022-10-17 8:58 ` [PATCH 13/14] tap: Split tap_ip4_send() into UDP and ICMP variants David Gibson
2022-10-18 3:06 ` Stefano Brivio
2022-10-18 12:07 ` David Gibson
2022-10-18 12:27 ` Stefano Brivio
2022-10-18 23:54 ` David Gibson
2022-10-17 8:58 ` [PATCH 14/14] dhcp: Use tap_udp4_send() helper in dhcp() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y06XAUZLCitWSEb1@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).